Easy Item Stack 'n Split v2.7.4 [Unmaintained]

[Dangerb0y]

wow new version nice
as always it rocks !! 5/5

Hey thanks man, for the rep + rating too, much appreciated . Let me know if you ever need any help with it, I'm always free to lend a hand.

light bolt30 is right - that's pretty much how you do it. You can also do it by hitting the little rep icon on the far top-right of the first page of any resource.

 

[xorkatoss]

nice to see that your system still updates

TESTERS:
- Some guy whose name I forgot

that made me laugh to hell xD

also did you know that now your system is added to a very popular map?
http://sites.google.com/site/jungletrolls/
that map was awesome and now with your system it's even better !! ;D
keep up the good work man

 

[Dangerb0y]

Nice to see you're still one of my top supporters and reppers

The main developer of Jungle Trolls Reborn is actually a beloved bug finder for this system, so we've helped each other's projects a bit. It is definitely an awesome map.

I finally remembered that guy's name

Thanks again for the support xorkatoss. You kick ass!

 

[Dangerb0y]

also did you know that now your system is added to a very popular map?
http://sites.google.com/site/jungletrolls/

I just saw that you recommended my system to them. I think i should hire you to spread the word of Easy Item Stack 'n Split thanks again man, you've definitely got some +rep coming your way!

 

[xorkatoss]

I just saw that you recommended my system to them. I think i should hire you to spread the word of Easy Item Stack 'n Split thanks again man, you've definitely got some +rep coming your way!

well i noticed that the stacking system in the Jungle Trolls Reborn map was not that good...
and also that it could't split items and etc.
so i suggested your system since it would make the map way better

 

[7h30]

It's nice.

 

[creativeRPG]

Syntax fault?

Hey,

thx for your system!

But i get this fault if i simply open the map and want it to save:


Could anybody help me?
thx

(I have JNGP-5d and I think everthing else also ok)

But it's ok, i now use the GUI-Version - everything works well.
Nevertheless I am wondering...

Greets and merry x-mas

 

[Dangerb0y]

Hey,

thx for your system!

But i get this fault if i simply open the map and want it to save:
http://www.picfront.org/d/7YzR

Could anybody help me?
thx

(I have JNGP-5d and I think everthing else also ok)

You're not doing anything wrong - the problem you're having is because, for some reason, the latest JNGP doesn't come with the latest JassHelper, and the old version can't parse static ifs. You can get the latest version HERE. There's also a link in the description.

Merry xmas to you too

 

[chanckaka]

If this system not need to use ClearTextMessages,it would be more better..

 

[Dangerb0y]

If this system not need to use ClearTextMessages,it would be more better..

If you don't want it to clear text messages, just disable the error message in the system's parameters - that's what it's there for

 

[Aasfresser]

Okay at first I have no idea of Jass! So now I downloaded ur system and tried to integrate it into my map. Until now all was nice, than I wanted to test it and the Editor said that over 100 errors are in ur system o.0!!!!!! What did I wrong?

 

[xorkatoss]

You're not doing anything wrong - the problem you're having is because, for some reason, the latest JNGP doesn't come with the latest JassHelper, and the old version can't parse static ifs. You can get the latest version HERE. There's also a link in the description.

Dude thnx!! you are a life saver
I tried many times to install JNGP but failed xD
But your link helped a lot and now i can use vJASS!! +rep ;D

 

[Dangerb0y]

If this system not need to use ClearTextMessages,it would be more better..

You're totally right. I've removed the full inventory error message in the new version. It's not worth the ClearTextMessages.

Okay at first I have no idea of Jass! So now I downloaded ur system and tried to integrate it into my map. Until now all was nice, than I wanted to test it and the Editor said that over 100 errors are in ur system o.0!!!!!! What did I wrong?

lol. This system comes with 2 versions - one in GUI (the one you want to use) and the other in vJASS (you need JNGP for this one).

To get this system working, download the new version and follow the directions ONLY for the GUI version. You can't go wrong.

Dude thnx!! you are a life saver

You're always welcome xorkatoss

 

[Aasfresser]

I'm sorry, but I have no clue how to import a GUI trigger into a map with other triggers already.

 

[Dangerb0y]

I'm sorry, but I have no clue how to import a GUI trigger into a map with other triggers already.

It's easier than you think. Just open up my system in World Editor, go to the Trigger Editor, then in the folder called "For the GUIers" literally just click on the trigger "EasyItemStacknSplitGUI" and hit CTRL+C. Then you can open your own map in World Editor, go to Trigger Editor and hit CTRL+V to paste it in. Before you paste it though make sure to go to File > Preferences... and tick "Automatically create unknown variables while pasting trigger data" under the General tab.

 

[xorkatoss]

yay an update!! xD
i think your system after all these updates will finaly reach perfection!!

SUPPORTERS AND PROMOTERS:
- xorkatoss

yay im in the list


Offtopic:
aren't you going to work or anything new?
a new system maybe?

 

[gadina_prokleta]

A wonderful, perfectly working system.
Thanks again

 

[88WaRCraFT3]

dangerb0y : suggestions : ask moderator to review your system again, second, now work on something other

 

[Dangerb0y]

aren't you going to work or anything new?
a new system maybe?

dangerb0y : suggestions : ask moderator to review your system again, second, now work on something other

lol. i guess this system has been going for over a year... i'm actually working on a playable map right now (and have been for half a year), but i've come to realize there's a big difference between working on a map, and FINISHING it. so until then, this system is all she wrote..... if i think of a good idea for a system i'll probably make it, but these days everything's been done like 20 times over.

 

[xorkatoss]

man i got an idea for your system!!
i came up with this idea when i was playing Jungle Trolls Reborn!!
i had 132 gold coins and i wanted to split them in order to have an item with 100 charges and another item with 32 charges...
(it was a pain in the ass to do it -.-)
so i came up with this awesome (i hope) idea!!
how about make your system when splitting items able to set a custom amount?
for example. -split amount 30 and when you try to split it splits 30 charges instead of 1
(and if not enough charges it does nothing)
also another idea is to make the splitting set to default(1) after using it!!
example. i split an item with the split amount set to 27, for the next splitting the split amount in reseted to 1 again...
so what you think about my idea?
EDIT:
also don't forget to set the custom split amount value private for each player!!

 

[88WaRCraFT3]

Epic idea xorkatoss, dangerb0y, i'll suggest you to make that splitting more eyecandy if you want i can do that with dialog buttons, if you don't know. For example you have an spell, that would work like change split, and than, when you activate it, you get dialog buttons, 1. Enter new splitting number. 2. Back splitting number to ONE. 3. Close. What ya think?

 

[Orcnet]

DotA can really use your system bro, its better than what there doing right now, nice System 10/10!

 

[88WaRCraFT3]

DotA can really use your system bro, its better than what there doing right now, nice System 10/10!

LOL... Have you tested dota :O it's so damn cool, and it has damn stack system, and split is unneeded for it, anyway WHY DOES EVERYBODY WANTS TO TALK ABOUT DOTA!!!! Talk about something way better, like unbelieveble project Dark Wind, or projects that are on hive!

 

[Orcnet]

well they got similarities with that stacking system except the splitting, anyways I really like this one, its much more useful for any game types

 

[Dangerb0y]

Fudging awesome idea, xorkatoss I was wondering when you'd come up with something.. In the interest of simplicity, i've just made it so that consecutively split items will stack together - try it out.

88WaRCraFT3, dialogs would definitely get the job done, but they're a bit intrusive IMO.

Glad you like the system Orcnet

 

[Orcnet]

Glad you like the system Orcnet

yeah this system is just epic, I will use this in my project, then again, nice system!

 

[ABM]

I Hope you did get my last message about the bug from the new version in GUI...
Good luck on fixing it...
i hope my explanation helped you to find where exactly it is located...

full inventory, item type A max stack except in one slot
and pick up item that make the slot Max stack too and redrop the excedent item
but fail recovering the correct charge, and give all charge of all items of type A
instead of doing (all charge of type A - charge of all item type A in inventory) = excedent charges

 

[maddeem]

Looks good 5/5 +rep

 

[ABM]

you must be pretty busy Dangerb0y...
but listen when you fix the bug here is something you could do as well...

a) splitting
when you double click an item, it split 1 charge and put it in an empty slot
the second time you double click it add the charge to the first(splitted) item...
(you already done this in 2.7)

when you click an item and move it to empty slot you split item in half (charge rounded up in the taken item) //instead of splitting 1 charge like you did//

b) pick up
when you pick up an item you add charge from the item to already not full item in inventory, then add left charge to empty slot...
if inventory full while there are still charge left in item, drop item on the floor (correct the bug here where the dropped item charge are incorrect)
when you pick up an item with more than max charge automatically add the charge to already possessed item of same type that are not full, then add the item to an empty slot but give the item only max charge, if charge left repeat in every empty slot until no more slot or no more charge...if charge left drop item in pack of item with max stack.

Ex: i have inventory with:
slot1 3 stone(max5)
slot2 5 stone(max5)
slot3 5 Meat(max10)
slot4 empty
slot5 empty
slot6 empty

i pick up a stone with 23 charges (normaly you can't reach that but with trigger you can make any charge number, and i need your trigger to make max stack pack for me needed for my recipe system in JTR)

first 2 charges are added to slot1 (become 5 stone), then 5 charges are added to slot4 (become 5 stone), then 5 charges are added to slot5 (become 5 stone), then 5 charges are added to slot6 (become 5 stone)...
(2+5+5+5=17 --> 23-17=6 charges left)
drop a stone with 5 charges on floor, drop another stone with 1 charge on floor...
(no more charge left)

 

[Dangerb0y]

Geez, i've really gotta stop drinking so much coffee when i code... bug fixed.

@ABM: I'm super busy at the moment, but I'll get around to your suggestion B as soon as i get a free moment. I'm not quite sure what you mean about making a stack of items split when u move it to another slot?? But many thanks for the detailed feedback! You've been credited.

@maddeem: Appreciate it

 

[xorkatoss]

hmmm...
i had the EasyItem__USEITEMLEVEL = false for unlimited stacks like below..

• -------- Use item levels to determine stack limit? (false = unlimited stacks) --------
• Set EasyItem__USEITEMLEVEL = False

and i was splitting the potion of healing...(in your test map)
and the charges were stacking as they should but...
when the second item reached 10 charges (item level was 10)
it made a new item and added the charges there instead of adding them to the second item...
here is a pic i took...

 

[ABM]

Geez, i've really gotta stop drinking so much coffee when i code... bug fixed.

@ABM: I'm super busy at the moment, but I'll get around to your suggestion B as soon as i get a free moment. I'm not quite sure what you mean about making a stack of items split when u move it to another slot?? But many thanks for the detailed feedback! You've been credited.

@maddeem: Appreciate it

well what i meant is when you move an item to same slot it split into half....
slot 1 move to slot 1 = divide charge in 2
but isn't double click same? i mean is double click same as moving item a from slot 1 to slot 1? if that is the case forget about it, it is just my mistake...
but if it is different then that what i meant...
double click = -1 charge and move to same slot = /2 charge

about (b) that would be really very very helpfull if you do...
i looked at your trigger and i think i know about where in the trigger i should add a change, but i am not sure yet how to do this (would need an if/then/else check) and a divide charge.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • EasyItem__USEITEMLEVEL Equal to True
    • (Item level of (Item being manipulated)) Greater than 0
    • ((Charges remaining in (Item carried by (Triggering unit) in slot EasyItem_slot)) + (Charges remaining in (Item being manipulated))) Greater than (Item level of (Item being manipulated))
  • Then - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Charges remaining in (Item carried by (Triggering unit) in slot EasyItem_slot)) + (Charges remaining in (Item being manipulated))) Greater than ((Item level of (Item being manipulated)) x 2)
      • Then - Actions
        • Set D[0] = ((Charges remaining in (Item carried by (Triggering unit) in slot EasyItem_slot)) + (Charges remaining in (Item being manipulated)))
        • Set D[1] = (D[0] mod (Item level of (Item being manipulated)))
        • Set D[2] = (D[0] - D[1])
        • Set D[3] = (D[2] / (Item level of (Item being manipulated)))
        • For each (Integer A) from 1 to D[3], do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Integer A) Equal to 1
              • Then - Actions
                • Item - Set charges remaining in (Item carried by (Triggering unit) in slot EasyItem_slot) to (Item level of (Item being manipulated))
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Integer A) Equal to 2
                  • Then - Actions
                    • Item - Set charges remaining in (Item being manipulated) to (Item level of (Item being manipulated))
                  • Else - Actions
                    • Trigger - Turn off (This trigger)
                    • Hero - Create (Item-type of (Item being manipulated)) and give it to (Triggering unit)
                    • Item - Set charges remaining in (Last created item) to (Item level of (Item being manipulated))
                    • Trigger - Turn on (This trigger)
        • Trigger - Turn off (This trigger)
        • Hero - Create (Item-type of (Item being manipulated)) and give it to (Triggering unit)
        • Item - Set charges remaining in (Last created item) to D[1]
        • Trigger - Turn on (This trigger)
      • Else - Actions
    • Item - Set charges remaining in (Item being manipulated) to (((Charges remaining in (Item carried by (Triggering unit) in slot EasyItem_slot)) + (Charges remaining in (Item being manipulated))) - (Item level of (Item being manipulated)))
    • Item - Set charges remaining in (Item carried by (Triggering unit) in slot EasyItem_slot) to (Item level of (Item being manipulated))
  • Else - Actions
    • Item - Set charges remaining in (Item carried by (Triggering unit) in slot EasyItem_slot) to ((Charges remaining in (Item carried by (Triggering unit) in slot EasyItem_slot)) + (Charges remaining in (Item being manipulated)))
    • Item - Remove (Item being manipulated)
    • Set EasyItem_slot = (Size of inventory for (Triggering unit))

and also another change in the drop item section too... this is based on the old 2.6 version...
D(0)= total charge of all item of type (item being manipulated)
D(1)= left over from D(0) when divide in pack (item level of item manipulated)
D(2)= round number of D(0) [D(0)-D(1)]
D(3)= number of pack [D(2)/item level of item manipulated)

then it just need to loop acording to number of pack of items with max stack D(3)
and when done add the last pack with left over D(1)
(oups, i forgot to add a check if D(1)=0 no left over, then don't create the item for last pack)

but that's the spirit on how i think to do it

 

[Dangerb0y]

Thanks for picking that up, xorkatoss... Updated.

@ABM: I will add the functionality above as soon as can, i promise. Thanks again for the thorough analysis. I'll have to go through your code in finer detail, but it looks good from what i can see.

P.S. double right-click = move to same slot, unfortunately...

 

[ABM]

Well honestly even if i might do it right...
i would rather wait for you to do it yourself, i still don't understand all of your code especially the new 2.7, so i would fear putting bugs in it...
since you are the one who understand your trigger the best i will wait for you to find a way of doing it correctly...
i know you are busy, so i will wait till you have time to do it...

 

[Steel0RaZoR]

It doesn't stack when i buy an item...

 

[88WaRCraFT3]

How can i know, when i double right clicked item, and when i right clicked 1 item, and right clicked on other one, i need it. pls say me.

 

[Dangerb0y]

It doesn't stack when i buy an item...

That's correct. It's impossible to do that without creating duplicate powerup versions of your items.

How can i know, when i double right clicked item, and when i right clicked 1 item, and right clicked on other one, i need it. pls say me.

You need to use a bit of custom code. Make a trigger like this and move some items around a unit's inventory...

• Untitled Trigger 001
  • Events
    • Unit - A unit Is issued an order targeting an object
  • Conditions
  • Actions
    • Custom script: set udg_IntegerVariable = GetIssuedOrderId()
    • Game - Display to (All players) the text: (String(IntegerVariable))

Well honestly even if i might do it right...
i would rather wait for you to do it yourself, i still don't understand all of your code especially the new 2.7, so i would fear putting bugs in it...
since you are the one who understand your trigger the best i will wait for you to find a way of doing it correctly...
i know you are busy, so i will wait till you have time to do it...

ABM my man, sorry this update has taken such a long time, you probably don't even need it anymore, but anyway here it is.


THANK YOU ALL FOR TESTING, SUGGESTING, BUG FINDING, REPPING, RATING, DOWNLOADING AND USING!!!

 

[88WaRCraFT3]

That was fast answer, ty anyway but i've left wc3 modding Bye, here +rep for your work

 

[Magtheridon96]

Can I overhaul the vJass version so it supports recipes with 7 items? ^^

 

[pks9067]

when you pickup stat books with this system it gives you 2x the stat
please fix it

 

[xorkatoss]

hey dude about the splitting amount...shouldn't the EasyItem__SPLITSIZE be a private value for each player?
that way we could do a trigger like the one below to set the split amount for each player...

Set Split Amount

• Set Split Amout
  • Events
    • Player - Player 1 (Red) types a chat message containing -split amount as A substring
    • Player - Player 2 (Blue) types a chat message containing -split amount as A substring
    • Player - Player 3 (Teal) types a chat message containing -split amount as A substring
    • Player - Player 4 (Purple) types a chat message containing -split amount as A substring
    • Player - Player 5 (Yellow) types a chat message containing -split amount as A substring
    • Player - Player 6 (Orange) types a chat message containing -split amount as A substring
    • Player - Player 7 (Green) types a chat message containing -split amount as A substring
    • Player - Player 8 (Pink) types a chat message containing -split amount as A substring
    • Player - Player 9 (Gray) types a chat message containing -split amount as A substring
    • Player - Player 10 (Light Blue) types a chat message containing -split amount as A substring
    • Player - Player 11 (Dark Green) types a chat message containing -split amount as A substring
    • Player - Player 12 (Brown) types a chat message containing -split amount as A substring
  • Conditions
    • (Substring((Entered chat string), 1, 13)) Equal to -split amount
  • Actions
    • Set EasyItem__SPLITSIZE[(Player number of (Triggering player))] = (Length of (Substring((Entered chat string), 15, 17)))

im just saying that i would prefer it this way but you can do wtv you want, it's your system after all ;p

 

[Dangerb0y]

Can I overhaul the vJass version so it supports recipes with 7 items? ^^

If you can think of a way to do it, go for it

when you pickup stat books with this system it gives you 2x the stat
please fix it

Thanks for picking this up. Fixed.

hey dude about the splitting amount...shouldn't the EasyItem__SPLITSIZE be a private value for each player?
that way we could do a trigger like the one below to set the split amount for each player...

Set Split Amount

• Set Split Amout
  • Events
    • Player - Player 1 (Red) types a chat message containing -split amount as A substring
    • Player - Player 2 (Blue) types a chat message containing -split amount as A substring
    • Player - Player 3 (Teal) types a chat message containing -split amount as A substring
    • Player - Player 4 (Purple) types a chat message containing -split amount as A substring
    • Player - Player 5 (Yellow) types a chat message containing -split amount as A substring
    • Player - Player 6 (Orange) types a chat message containing -split amount as A substring
    • Player - Player 7 (Green) types a chat message containing -split amount as A substring
    • Player - Player 8 (Pink) types a chat message containing -split amount as A substring
    • Player - Player 9 (Gray) types a chat message containing -split amount as A substring
    • Player - Player 10 (Light Blue) types a chat message containing -split amount as A substring
    • Player - Player 11 (Dark Green) types a chat message containing -split amount as A substring
    • Player - Player 12 (Brown) types a chat message containing -split amount as A substring
  • Conditions
    • (Substring((Entered chat string), 1, 13)) Equal to -split amount
  • Actions
    • Set EasyItem__SPLITSIZE[(Player number of (Triggering player))] = (Length of (Substring((Entered chat string), 15, 17)))

im just saying that i would prefer it this way but you can do wtv you want, it's your system after all ;p

Hey man. It would be awesome to do it like this, but then how would people be able to set the default splitsize without having to set it for each player separately?

 

[xorkatoss]

Hey man. It would be awesome to do it like this, but then how would people be able to set the default splitsize without having to set it for each player separately?

well if they want to set the same splitsize for everybody they could use loops

• For each (Integer i) from 1 to 12, do (Actions)
  • Loop - Actions
    • Set EasyItem__SPLITSIZE[i] = 1

 

[TAIL]

how you can set for which items to work and for which not?

 

[Dangerb0y]

how you can set for which items to work and for which not?

The system will work for all items with charges. Normal items without charges are unaffected.

 

[xorkatoss]

The system will work for all items with charges. Normal items without charges are unaffected.

duuuuuuuudeeeeeeeeeeee!!!? when are you going to update your system? -.-
im still waiting for the private custom item split function!! too bad your system is so confusing (and awesome^^) and i can't do it on my own *_*

EDIT:
rofl i was completely ignored...NICE!! ;D

 

[maddeem]

Oh yes, as I said before this is useful and I'm going to use it for sure.

 

[xorkatoss]

YES!! found a "fail" in your trigger...(don't think it's a bug)

• -------- Allow item splitting with double right-click? --------
• Set EasyItem__SPLIT = False

When double right-click is deactivated you can't split items at all...

ill keep working hard to find more fails^^

EDIT:
i have a question...what does this variable do?

• Set EasyItem__SPLITSTACKDELAY = 2.00

i really can't see the use of it...
after setting that value to 100 and stacking items 5-6 times game freezed...

 

[Dangerb0y]

duuuuuuuudeeeeeeeeeeee!!!? when are you going to update your system? -.-
im still waiting for the private custom item split function!! too bad your system is so confusing (and awesome^^) and i can't do it on my own *_*

EDIT:
rofl i was completely ignored...NICE!! ;D

Lol, sorry man, I really dropped the ball on this. Life, hey...

I'll be honest, I don't like the idea of having a "Preference Variable" in a loop. I could make you a custom version that has that, but I really can't promise u an ETA.

YES!! found a "fail" in your trigger...(don't think it's a bug)

• -------- Allow item splitting with double right-click? --------
• Set EasyItem__SPLIT = False

When double right-click is deactivated you can't split items at all...

ill keep working hard to find more fails^^

You'll have to try harder than that. You did find a fail in my comment though. That variable just enables/disables splitting, of any type. (Double right-click is the same as dropping an item on itself. WC3 can't differentiate between the two.)

EDIT:
i have a question...what does this variable do?

• Set EasyItem__SPLITSTACKDELAY = 2.00

i really can't see the use of it...
after setting that value to 100 and stacking items 5-6 times game freezed...

That variable is used in the feature I added where if u consecutively split an item stack (spam right-click!) it splits off into the same pile, instead of separate items of 1 charge. The SplitStackDelay is just the time it takes to "reset". E.g. If you split a stack of 10 four times, you'll have one stack of 6 and one of 4. Then if you wait 2 seconds (or whatever you set the variable to) and split the same stack of now 6, it'll start stacking into a new stack, so you'll end up with 3 stacks. And so on...

 

[Dangerb0y]

For anyone interested, I've decided to consider making a version 3 of the system, in which items will be purchasable from shops regardless of a full inventory.

Before you all jump for joy wink, the reason I haven't added this function to my system yet is simply because the ONLY way to possibly make this work (yes, the only way...) is to use duplicate dummy powerup items of your actual items, and you'd also have to add a line of code (function or variable maybe) into a "Setup" trigger for each item, tying the real item to the dummy item, so to speak.

Now this really isn't toooo difficult, but it does kind of go against the "Easy" part of the system, especially since at the moment it's pretty much copy+paste. So if any of you think it would be a good idea (or bad idea) to add this feature, leave a comment below. If I don't get a good enough response on this, it just won't be worth the time and potential confusion for (new?) mapmakers.

Thanks everyone.

EDIT: I'm also considering a bonus bag system..