Easy Item Stack 'n Split v2.7.4 [Unmaintained]

[Moderator]

11:23, 22nd Dec 2009
TriggerHappy:

Review for Spell

I suppose it can be useful for other GUI users. The other GUI ones IIRC aren't as advanced as this, therefor I will approve this.

Status

Feel free to message me here if you have any issues with my review or if you have updated your resource and want it reviewed again.

Approved

 

[X-OMG-X]

Well. Looks cool from the description. Might be useful.

 

[Narandza]

I think this is really great...

 

[Kingz]

There are loads of systems like this, only thing difrent here is that he has good eye atraction(the collors of the letters and screenshot)

 

[Dangerb0y]

There are loads of systems like this, only thing difrent here is that he has good eye atraction(the collors of the letters and screenshot)

You're right about the eye attraction , but i'm gonna have to disagree with you that there are loads of systems like this... i may be wrong, so if you can find a system like this (as easy to implement, completely bug & leak free, MUI & MPI, and as functional) please post a link so i can tell you why my system is still better

 

[NFWar]

6/5 from me. great idea.

 

[The_Witcher]

You're right about the eye attraction , but i'm gonna have to disagree with you that there are loads of systems like this... i may be wrong, so if you can find a system like this (as easy to implement, completely bug & leak free, MUI & MPI, and as functional) please post a link so i can tell you why my system is still better

well if you ask me like that
My Bag and Advanced Item System
It does the same as yours and many more things and you just need to implement 1 trigger without any variables...

But know serious again:
Your system is very good, too, most for GUI beginners which want to learn!!

 

[Dangerb0y]

well if you ask me like that
My Bag and Advanced Item System
It does the same as yours and many more things and you just need to implement 1 trigger without any variables...

Yeah I've seen your system before. It has 1 or 2 kinks mentioned in the thread, but otherwise very nice. Still quite different to mine though.

But know serious again:
Your system is very good, too, most for GUI beginners which want to learn!!

Thanks dude. That was pretty much what I was going for. Especially the GUI.

 

[Archangel_Tidusx]

Very useful but unoriginal system. It does look better than the rest, and caught my eye. I will definitely dl and use. 5/5

 

[Dangerb0y]

Very useful but unoriginal system. It does look better than the rest, and caught my eye. I will definitely dl and use. 5/5

Sure, it's definitely been done before, just not very well or efficiently from what I've seen... I guess the only real differences are quality and ease of use. Thanks for downloading and rating

 

[Maker]

It doesn't stack items if your inventory is full.

If you have five stacks of 3 mana potions, and one stack of one mana potion, and you try to pick up more potions, it doesn't stack them. It just says inventory full.

But I guess there's no way around it unless you base the thing around runes.

 

[Archangel_Tidusx]

I believe that's because you never changed the max level of the mana potion.

Read the system.

 

[Maker]

Well the level is 3 by default, so it should stack up to 3 potions in the same stack. However if my inventory is full, and I try to pick up a stack of two potions, it doesn't pick it up, even though there is one inventory slot with only one mana potion.

 

[Archangel_Tidusx]

i guess the simple way around that would be:
Drop both stacks.
Pick up stack of 2
Pick up stack of 1
Problem solved. I mean.. the system still is more than what wc3 does for you.
It doesn't tie your shoes and beat halo 3 on legendary for you though.

 

[Maker]

i guess the simple way around that would be...

The simple way around it for me would be to use my own system

 

[Archangel_Tidusx]

Wahey! Problem solved..

 

[Dangerb0y]

Yeah, the plan for this system was never really to solve the full-inventory-stacking problem, its purpose is just to add some much needed inventory capabilities to any map with little effort, and to be easily understandable by the average GUIer. A while ago i coded a system based on this one that gets around the full inventory problem, both with picking up and buying items, but as you mentioned, Maker, it works with runes which makes implementing it not so "easy" anymore...

The simple way around it for me would be to use my own system

I'm still on the lookout for easier ways of overcoming the full inv problem, so if you have a link to your system please post it so we can take a look.

 

[The_Witcher]

I'm still on the lookout for easier ways of overcoming the full inv problem, so if you have a link to your system please post it so we can take a look.

Well I found a way... if youre still looking for a solution, tell me and i'll help you

 

[Dangerb0y]

Sure, what you got?

 

[The_Witcher]

try my bag system again...
you see that you can still pick up stackable items, even if your inventory is full!!
this can be done in GUI, too...

if you are interested in that method i'll tell you, but plz PM me!

 

[DanThanh]

This system is really nice, i like it

 

[Irineos]

I really love this! This is both useful and may be the easiest system to implement. Well done.

 

[Dangerb0y]

try my bag system again...
you see that you can still pick up stackable items, even if your inventory is full!!
this can be done in GUI, too...

if you are interested in that method i'll tell you, but plz PM me!

As soon as i get some free time i'll definitely be interested in GUIing your method. it would be really nice to implement this feature without mapmakers having to make duplicate items and what not. I'll PM you..

Thanks for the comments other people, glad you enjoy the system

 

[Mainywc3sear]

is a stack of such spell =/

 

[NoMoreChallenge]

Extremely useful system!! I will use it on my map. 5/5 +rep

 

[88WaRCraFT3]

Split don't work for me.

 

[Dangerb0y]

Split don't work for me.

That is the weirdest thing ever. I've downloaded this map a couple times myself just for fun and it's worked perfectly every time. Until now. Anyway I've fixed the problem and uploaded the new version, see if it works for you now.

 

[88WaRCraFT3]

Forget to answer, +REP and thanks works now

 

[Tiche3]

This great system maker, please make that you can stack items when your inv is full, thanks, +rep for a great system

 

[Wezthal]

This is great! It's simple yet effective. However I converted it into JASS for better optimization and configureability. I hope it helps somebody.

Here's the code: (I know it's not perfect but it's better than plain GUI anyways, I guess.)

//===========================================================================
//========================= ITEM STACKING ===================================
//===========================================================================
// - Manages items stacking and splitting
//     - To make an item stackable, simple add it's rawcode to the list below
//
// - Credits:
//     - Original GUI system by Dangerb0y
//     - Converted to JASS by Wezthal
//===========================================================================
scope ItemStacking initializer Init
//===========================================================================
    globals
        constant real DEGTORAD = 0.01745327
        private integer array stackable
        private integer orderId = 0
        private constant hashtable StackHash = InitHashtable()
    endglobals
//===========================================================================
function GetItemTypeIdMaxCharges takes integer nItemTypeId returns integer
    local item it = CreateItem(nItemTypeId, 0, 0)
    local integer it_charges = GetItemCharges(it)
    call RemoveItem(it)
    set it = null
    return it_charges
endfunction
//===========================================================================
    private function Setup takes nothing returns nothing
        local integer i = 0
        local integer array it_id
//===========================================================================
//========================== SETUP START ====================================
//===========================================================================
        //List stackable itemtype rawcodes here
        set it_id[0] = 'I001'
        set it_id[1] = 'I006'
        //set it_id[2] = '    '
        //set it_id[3] = '    '
        // . . .
//===========================================================================
//========================== SETUP END ======================================
//===========================================================================
        loop
            exitwhen (it_id[i] == null)
            call SaveBoolean(StackHash, StringHash("IsItemStackable"), it_id[i], true)
            call SaveInteger(StackHash, StringHash("ItemTypeIdMaxCharges"), it_id[i], GetItemTypeIdMaxCharges(it_id[i]))
            set i = i + 1
        endloop
    endfunction
//===========================================================================
    private function CountItems takes unit u returns integer
        local integer i     = 0 
        local integer items = 0
        loop
            exitwhen (i > 5)
            if (UnitItemInSlot(u, i) != null) then
                set items = items + 1
            endif
            set i = i + 1
        endloop
        return items
    endfunction
//===========================================================================
    private function ItemStacking_Conditions takes nothing returns boolean
        local item it
        local integer it_id
        local integer i = 0
        
        if (GetOrderTargetItem() != null) then
            set it = GetOrderTargetItem()
        else
            set it = GetManipulatedItem()
        endif
        set it_id = GetItemTypeId(it)
        
        if (GetItemCharges(it) > 0) then
            if (LoadBoolean(StackHash, StringHash("IsItemStackable"), it_id)) then
                set it = null
                return true
            endif
        endif
        set it = null
        return false
        
    endfunction
//===========================================================================
    private function ItemStacking_Actions takes nothing returns nothing
        local unit    u = GetTriggerUnit()
        local integer pl = GetPlayerId(GetOwningPlayer(u))
        local integer i
        local item    loopItem
        local integer loopItemTypeId
        local integer loopItemMaxCharges
        local integer loopItemCharges
        local item    eventItem = GetOrderTargetItem()
        local integer eventItemTypeId
        local integer eventItemMaxCharges
        local integer eventItemCharges
        local item    newItem
        local real X
        local real Y
        local real facing
        
        if (orderId != 1) then
            set orderId = GetIssuedOrderId()
            
            if (orderId >= 852002) and (orderId <= 852007) then
                if ( CountItems(u) > 0 ) and ( UnitHasItem( u, eventItem ) ) then
                    set i = 0
                    loop
                        exitwhen (i > UnitInventorySize(u) - 1)
                        
                        set eventItem = GetOrderTargetItem()
                        set eventItemTypeId = GetItemTypeId(eventItem)
                        set eventItemMaxCharges = LoadInteger(StackHash, StringHash("ItemTypeIdMaxCharges"), eventItemTypeId)
                        set eventItemCharges = GetItemCharges(eventItem)
                        set loopItem = UnitItemInSlot(u, i)
                        set loopItemTypeId = GetItemTypeId(loopItem)
                        set loopItemMaxCharges = LoadInteger(StackHash, StringHash("ItemTypeIdMaxCharges"), loopItemTypeId)
                        set loopItemCharges = GetItemCharges(loopItem)
                        
                        if ( orderId == 852002 + i ) then
                            if ( loopItemTypeId == eventItemTypeId ) then
                                if ( loopItem != eventItem ) then
                                    if ( loopItemCharges + eventItemCharges > eventItemMaxCharges ) then
                                        if ( eventItemCharges != eventItemMaxCharges ) then
                                            if ( loopItemCharges != loopItemMaxCharges ) then

                                                call SetItemCharges( loopItem, ( loopItemCharges + eventItemCharges ) - eventItemMaxCharges )
                                                call SetItemCharges( eventItem, eventItemMaxCharges )
                                            
                                            endif
                                        endif
                                    
                                    else
                                        
                                        call SetItemCharges( eventItem, eventItemCharges + loopItemCharges )
                                        call RemoveItem( loopItem )
                                    
                                    endif
                                
                                else
                                    if ( eventItemCharges > 1) then

                                        call SetItemCharges( eventItem, eventItemCharges - 1 )
                                        set facing = GetUnitFacing( u )
                                        set X  = GetUnitX( u ) + 100.0 * Cos( facing * DEGTORAD )
                                        set Y  = GetUnitY( u ) + 100.0 * Sin( facing * DEGTORAD )
                                        set newItem = CreateItem( eventItemTypeId, X, Y)
                                        call SetItemCharges( newItem, 1 )

                                        if ( CountItems( u ) < UnitInventorySize( u ) ) then

                                            set orderId = 1
                                            call UnitAddItem( u, newItem )
                                            set orderId = 0
                                        
                                        endif
                                        
                                    endif
                                
                                endif
                            endif
                        endif
                        
                        set i = i + 1
                    endloop
                endif
            else

                set i = 0
                loop
                    exitwhen (i > UnitInventorySize(u) - 1)
                    
                    set eventItem = GetManipulatedItem()
                    set eventItemTypeId = GetItemTypeId(eventItem)
                    set eventItemMaxCharges = LoadInteger(StackHash, StringHash("ItemTypeIdMaxCharges"), eventItemTypeId)
                    set eventItemCharges = GetItemCharges(eventItem)
                    set loopItem = UnitItemInSlot(u, i)
                    set loopItemTypeId = GetItemTypeId(loopItem)
                    set loopItemMaxCharges = LoadInteger(StackHash, StringHash("ItemTypeIdMaxCharges"), loopItemTypeId)
                    set loopItemCharges = GetItemCharges(loopItem)

                    if ( loopItemTypeId == eventItemTypeId ) then
                        if ( loopItemCharges < loopItemMaxCharges ) then
                            if ( loopItem != eventItem ) then
                                if ( loopItemCharges + eventItemCharges > eventItemMaxCharges ) then

                                    call SetItemCharges( eventItem, (loopItemCharges + eventItemCharges) - eventItemMaxCharges )
                                    call SetItemCharges( loopItem, eventItemMaxCharges )
                                    
                                else

                                    call SetItemCharges( loopItem, loopItemCharges + eventItemCharges )
                                    call RemoveItem( eventItem )
                                
                                endif
                            endif
                        endif
                    endif
                    
                    set i = i + 1
                endloop
            
            endif
        endif

        set u = null
        set loopItem = null
        set eventItem = null
        set newItem = null
    endfunction
//===========================================================================
    private function Init takes nothing returns nothing
    local integer i
    local trigger t = CreateTrigger()
    
    call Setup()
    
    set i = 0
    loop
        exitwhen (i > 8)
        if (GetPlayerSlotState(Player(i)) == PLAYER_SLOT_STATE_PLAYING) then
            call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER, null)
            call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_PICKUP_ITEM, null)
        endif
        set i = i + 1
    endloop
    call TriggerAddCondition(t, Condition( function ItemStacking_Conditions ) )
    call TriggerAddAction(t, function ItemStacking_Actions )
    
    set t = null
    endfunction
//===========================================================================
endscope
//===========================================================================

 

[Caedrus]

Well, I've got a bit of a problem with this system. I imported it exactly as the directions suggested (just copied the trigger and variables), and it seems to interfere rather severely with all timers and loops in my game. I can't seem to figure out exactly *why* this is, but it's definitely coming from this system, since disabling the item stack and split trigger fixes everything.

What could be causing such game-breaking interference? Any help would be greatly appreciated; I would love to be able to use this system without utterly breaking the rest of my game

(Link to relevant game: http://www.hiveworkshop.com/forums/maps-564/last-tower-v1-10-a-164641/index3.html)

EDIT: I seem to have found the issue... the "Integer A" loops were interfering with the "Integer A" loops already in the game. Replacing it with a unique variable loop fixed the issue. Perhaps you should consider using a unique variable for your loops (eg loop for integer variable instead of loop for integer A) so that games can't glitch from using the same variable simultaneously when newbies like me import it

5/5 rating and +rep, in any case. Great resource!

 

[Dangerb0y]

Well, I've got a bit of a problem with this system...

Just when I thought I was cruising down bug-free lane Better to find them than not I guess... Many thanks Caedrus. That's quite the esoteric of bugs.

For anyone experiencing what Caedrus was, I've uploaded a new version of the system. Please also check out the IMPLEMENTATION steps again as I've had to add one more variable to properly iron out this bug.

P.S. I played your Last Tower map, Caedrus. Very nice.

 

[Sorceress]

Well this is new.
Usefull when theres no more space for items
in the inventory. Great!

 

[AMARANT]

Very useful system, especially item splitting. Thank you very much for it! 5/5

 

[light bolt30]

Great GUI system, some people may use these in their maps for many uses thus also documenting each part of the trigger, therefore newbs may learn something new.

 

[Caedrus]

Just when I thought I was cruising down bug-free lane Better to find them than not I guess... Many thanks Caedrus. That's quite the esoteric of bugs.

It's not really a "bug" (as there's nothing inherently wrong with using the default A/B loops on their own) so much as it's just more likely to interfere with (or be interfered with by) pre-existing systems when not using a unique variable since many people will use the default "Integer A" or "Integer B" loop triggers (and you can't run more than one of those at the same time).

Anyways, glad I could be of help in any case.

P.S. I played your Last Tower map, Caedrus. Very nice.

Glad you liked it

I'd appreciate hearing your feedback in the comments thread for TLT.

 

[Yoghurt69]

Thank you for this system! I have only one question, i can only make item lvl 8 and no more, and in your map they stack at 10 hm?

 

[Caedrus]

Thank you for this system! I have only one question, i can only make item lvl 8 and no more, and in your map they stack at 10 hm?

Hold shift when clicking on a field in the object editor and you can input whatever value you want (including negative values). You could set the level to 50 or whatever.

 

[Yoghurt69]

Thanks! I never heard of that before!

 

[Caedrus]

Thanks! I never heard of that before!

Glad to be of service, of course

 

[tonyrydland]

can charged items stack even when the inventory is already full?

 

[X-Death]

This system is excellent.

It's flawless, simple to implement, easy to use or modify, and is the most flexible GUI item stacking and splitting system I have ever seen. You can expect me to use this in a few of my projects, and will be crediting you, of course. Thank you!

5/5 + Repped

 

[Dangerb0y]

This system is excellent.

It's flawless, simple to implement, easy to use or modify, and is the most flexible GUI item stacking and splitting system I have ever seen. You can except me to use this in a few of my projects, and will be crediting you, of course. Thank you!

5/5 + Repped

I'm glad you noticed haha. Thanks for the positive response guy, and the rep of course, much appreciated. I'm going to be working on a possible v2.0 of this system, so keep an eye out!

 

[Dangerb0y]

can charged items stack even when the inventory is already full?

Sorry man, I must have missed your post. You can stack charged items that are already in your inventory when it's full, but you can't pick up items when your inventory is full. It's just one of War3's annoying limitations. There are ways to do it of course, but it gets quite complicated.

 

[88WaRCraFT3]

How's going with the update?

 

[xorkatoss]

lol and to think that the last version of this system that i have is 1.4 xD
very nice man this is one of the best systems on hive workshop
keep up the good work with your awesome system ;D

 

[Dangerb0y]

lol and to think that the last version of this system that i have is 1.4 xD
very nice man this is one of the best triggers on hive workshop
keep up the good work with your awesome system ;D

All in a day's work very glad you like it.

How's going with the update?

Did any part of our convo even remotely suggest that there will be an update at all?

That being said, v2.0 is on the way...

 

[xorkatoss]

wow new version nice
as always it rocks !! 5/5
dude can you help me?
i want to give you +rep but i don't know how lol
pls help me

 

[light bolt30]

wow new version nice
as always it rocks !! 5/5
dude can you help me?
i want to give you +rep but i don't know how lol
pls help me

Under the user's avatar, there is a thumbs up icon. Click it to give that user rep! But you have to spread the rep around first in order to rep that person once again.