DisableItems v1.0 (Active ones)

[Moderator]

12:11, 17th Jun 2010
TriggerHappy:

Does what is says it does and the coding is good.

edit
18th December
Magtheridon96:
You should totally update this.
- (Triggering unit) should be cached into a unit variable.
- (Key (Triggering unit)) should be cached into an integer variable via custom script.
- There is a faster way for you to get the slot:

local integer orderId = GetIssuedOrderId() - 7
set slotNumber = orderId - orderId / 7 * 7

It's faster because it involes no strings or function calls.

 

[Pharaoh_]

Oh, I would also like to mention that I was motivated by DeftheLynn to create this, from a question he casted in the World Editor Zone forum.

 

[MortAr]

Looks promising, will test it when I got the time.

 

[VoidLordXtreme]

i actually read that thread...

seems... useful.

 

[Anachron]

This is not useful and way to easy.
You should just remove and readd the item when an spell effect is triggered.

 

[Pharaoh_]

This is not useful and way to easy.

For the second part, I may agree with you, I also added a note that it is uploaded for being useful. For the first part, you really can't say that, when questions like "How to disable active items?" come up in the Warcraft III Modding forums.
And why don't you find it useful? I don't get it. Let's say someone has an ability that disables enemy's items from being used or needs a system, that, when you are in the water, you can't use items. Why are you so utterly against it? You never know when such a system will be needed.

You should just remove and readd the item when an spell effect is triggered.

I tried, it didn't work. The item is already being removed when using charged items, so it doesn't fire the event at all.

 

[Anachron]

I tried and it did work, which event did you use?

 

[PurgeandFire]

It is definitely useful and a cool technique. Size shouldn't matter with usefulness as long as it isn't a well known method. =)

Maybe you should rename "Disable" though to something like "DisableItems" to avoid naming collisions. Also, you could expand this system to disable a slot, which would be neat. But that is up to you. (Basically, instead of just one boolean you can make it an array for 0-5 slots, then you just use the technique if the issued order is that of the slot or whatever, sorry it is a little hard to explain =P )

Overall though, cool. Nice job.

 

[Pharaoh_]

Thank you, PurgeandFire111. Although I did understand what your suggestion is, I'm afraid it gets too specific if I do so, thus I might only post the trigger for that. I mean, a system that will disable active items from being used on a specific slot seems too situational. But please, if you still find it interesting, let me know.
Name changed to look more like a system

 

[ALiEN95]

This is not useful and way to easy.
You should just remove and readd the item when an spell effect is triggered.

how can you detect item you use than?


Pharanoh
can you plz try this,this is actually a combination that i found out myself

-turn off this trigger
-pause unit
-unpause unit
-order unit to stop
-turn on this trigger

turn off/on trigger makes trigger not run twice because of pause and unpause,

pause/unpause allows you to stop units at events
- issued an order targeting a pont/object/no target


and you don´t need to make integers for this
just use IssuedOrderId - 852007

for example:
852008 - 852007 = 1
852009 - 852007 = 2

 

[Pharaoh_]

Moderators seem to dislike Pause/Unpause and sometimes, Stun and Pause cause weird effects (like eternal pausing).

 

[Anachron]

how can you detect item you use than?

Store the item that is being used.

 

[ALiEN95]

Moderators seem to dislike Pause/Unpause and sometimes, Stun and Pause cause weird effects (like eternal pausing).

never happend ...at least not with this i posted

a anyway it seems a lot better than using timers
btw time expire in 0.00 should be enough but i woul rather avoid using timer at all

Store the item that is being used.

but than you have to store it when issuing an order,don´t you ??

 

[Pharaoh_]

btw time expire in 0.00 should be enough but i woul rather avoid using timer at all

0.00 seconds expiration timer isn't enough for the data to be stored on the dummy with the hashtable. 0.01 is the least amount I can use.

 

[DeftheLynn]

hey, you should thank me for giving the inspiration

EDIT : you did on the first post

 

[88WaRCraFT3]

Useful x 2 i love your idea about water, will use it like that

 

[Gekigengar]

it don't work properly when combined with this system
http://www.hiveworkshop.com/forums/...search=item%20split%20and%20stack&d=list&r=20

the useable item split into diffrent parts. well, compatibility is not really an issue, but,


the real problem is...
if the item is permanent, i still be able to cast, but did nothing (and CD.) (try firebolt).

anyways can you help with both of them?

EDIT :
i solved compatibility, now i just need disable for kelen's dagger, and other item abilities without charges.

 

[Pharaoh_]

Yes, it's because it doesn't consider the charges. I will fix it and update, thanks for noticing ^^

 

[Maker]

You could make the ItemUsage2 trigger like this:

Trig

• Item Usage2
  • Events
    • Unit - A unit Is issued an order with no target
    • Unit - A unit Is issued an order targeting an object
    • Unit - A unit Is issued an order targeting a point
  • Conditions
    • Disable Equal to True
  • Actions
    • Custom script: set udg_WhichSlot = GetIssuedOrderId() - 852007
    • Custom script: if udg_WhichSlot > 0 and udg_WhichSlot < 7 then
    • Hero - Drop (Item carried by (Triggering unit) in slot WhichSlot) from (Triggering unit)
    • -------- ---------------- --------
    • -------- The dummy is created to actually make the system function. --------
    • -------- ---------------- --------
    • Set Point1 = (Position of (Triggering unit))
    • -------- ---------------- --------
    • Unit - Create 1 DummyTimer for (Owner of (Triggering unit)) at Point1 facing Default building facing degrees
    • Hashtable - Save Handle Of(Triggering unit) as (Key who) of (Key (Last created unit)) in Hashtable
    • Hashtable - Save Handle Of(Last dropped item) as (Key what) of (Key (Last created unit)) in Hashtable
    • -------- ---------------- --------
    • -------- ---------------- --------
    • -------- Although the slot will always be a positive number, I placed the Abs() function, just in case. --------
    • -------- ---------------- --------
    • -------- ---------------- --------
    • Hashtable - Save WhichSlot as (Key slot) of (Key (Last created unit)) in Hashtable
    • -------- ---------------- --------
    • -------- ---------------- --------
    • Unit - Add a 0.01 second Generic expiration timer to (Last created unit)
    • -------- ---------------- --------
    • -------- ---------------- --------
    • Custom script: call RemoveLocation (udg_Point1)
    • -------- ---------------- --------
    • Custom script: endif

Then you don't need the order id array.

 

[Gekigengar]

now i just need disable for kelen's dagger, and other item abilities without charges.

Yes, it's because it doesn't consider the charges. I will fix it and update, thanks for noticing ^^

have you updated it?

 

[Magtheridon96]

You're constantly repeating the (Triggering Unit) function.

It would be much more efficient if you store it in a variable.

Also,

• (Length of (String(Orders[IntegerLoop])))

You don't need this.

Just use 6 instead (All Order IDs in Warcraft III are 6 digits long.)

You should be ashamed >

Efficiency in GUI is extremely hard to achieve, so it should be taken
seriously.

Good luck ^^

 

[ImperialShadow]

wow it good.this 1 look like in the dota lucifer ulti

 

[ShiroiSenji]

Does this system make your players items disabled for other players? SO they can't use them.

 

[Noobsmoke]

This system is great !
Good idea and well executed
5/5