Dante and Nero spell pack

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Dante and Nero spell pack | Reviewed by Maker | 6th Oct 2013

NEEDS FIX

The waits make the spells not MUI Don't use Pause unit There are leaks Things that leak Hashtables and MUI Dynamic indexing Spell Submission Rules How to get your GUI spell approved

[tr]

 

[FUJI]

Spoiler

Pheww.....

Spoiler

I'm confusing...

Read this: http://www.hiveworkshop.com/forums/...s-279/how-get-your-gui-spell-approved-207625/

 

[Manasurge]

You're leaking positions, you're pausing units, you're using waits, you're not not using variables where you should be, you're using map specific unit id in the triggers.

This is a mess. It needs so many fixes I'm not sure you'd ever get it finished.

Read the link jakeZinc posted and these too:

http://www.hiveworkshop.com/forums/general-mapping-tutorials-278/complete-list-things-leak-126761/

http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/mui-triggers-waits-218354/

http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/variables-5896/

http://www.hiveworkshop.com/forums/...s-279/how-create-spells-gui-beginning-201867/


Normally I'd advice you to post the triggers in the description, but with these spells I wouldn't bother.

 

[Ofel]

@jakeZinc
Come on! don't say like that. Why? cuz the idea taken from one of my favorite game...

Ok, back to the topic...
Just do what these guys said...

 

[Rheiko]

no trigger posted, no review from me

 

[axleion]

that testmap filesize , I sense a lot of unneeded, flashy, eye-catchy imports
will see after finish DL later.

[HIGHLIGHT]EDIT[/code]
ok first of all, about the testmap and triggers:
- the testmap itself in the current state can't be used for testing
- the filesize is purely for imports of 2 model only which is unneeded, without the imports, approx testmap filesize is about ~50kb.
- a lot of tooltips are written in Bahasa Indonesia, and vague descriptions that the only way to understand it is reading through the trigger itself.
- use specific unit event and preplaced unit, transform ability only replace caster with specific other preplaced unit on the edge of right side of map.
- leaks heavily in each trigger, mainly special effect and location leaks
- uses set unit life instead of damage target, causing bounty not given to its proper killer

this is a sample trigger from the testmap, only the most epic sample is taken:

sample trigger

• Trickster
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Trickster
  • Actions
    • Set Arah = (Facing of (Triggering unit))
    • Unit - Hide (Triggering unit)
    • Unit - Move Dante (TRICKSTER) 0008 <gen> instantly to (Position of (Triggering unit))
    • Unit - Make Dante (TRICKSTER) 0008 <gen> face Arah over 0.00 seconds
    • Unit - Unhide Dante (TRICKSTER) 0008 <gen>
    • Unit - Rescue Dante (TRICKSTER) 0008 <gen> for (Owner of (Triggering unit)) and Change color
    • Unit - Rescue (Triggering unit) for Neutral Passive and Change color
    • Selection - Select Dante (TRICKSTER) 0008 <gen>

• Abilities tambahan
  • Events
    • Unit - Dante (TRICKSTER) 0008 <gen> Gains a level
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Level of (Triggering unit)) Equal to 2
        • (Level of (Triggering unit)) Equal to 3
        • (Level of (Triggering unit)) Equal to 15
        • (Level of (Triggering unit)) Equal to 4
        • (Level of (Triggering unit)) Equal to 5
        • (Level of (Triggering unit)) Equal to 7
        • (Level of (Triggering unit)) Equal to 8
        • (Level of (Triggering unit)) Equal to 9
        • (Level of (Triggering unit)) Equal to 10
        • (Level of (Triggering unit)) Equal to 11
        • (Level of (Triggering unit)) Equal to 13
        • (Level of (Triggering unit)) Equal to 14
  • Actions
    • Hero - Learn skill for (Triggering unit): Attribute Bonus

• Trickster 1
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Attacking unit) Equal to Dante (TRICKSTER) 0008 <gen>
    • (Random integer number between 1 and 5) Equal to 1
    • (Level of Trickster for (Attacking unit)) Greater than or equal to 1
  • Actions
    • Floating Text - Create floating text that reads Speed Up at (Position of (Attacking unit)) with Z offset 0.00, using font size 10.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
    • Set Ilmu = (Last created floating text)
    • Floating Text - Change Ilmu: Disable permanence
    • Floating Text - Change the lifespan of Ilmu to 1.50 seconds
    • Floating Text - Set the velocity of Ilmu to 64.00 towards 90.00 degrees
    • Animation - Change Dante (TRICKSTER) 0008 <gen>'s animation speed to (100.00 x 3.00)% of its original speed
    • Special Effect - Create a special effect attached to the origin of (Attacking unit) using Abilities\Spells\Orc\MirrorImage\MirrorImageCaster.mdl
    • Wait 1.00 seconds
    • Unit - Set life of (Attacked unit) to ((Life of (Attacked unit)) - (4.00 x (Real((Strength of (Attacking unit) (Exclude bonuses))))))
    • Animation - Change Dante (TRICKSTER) 0008 <gen>'s animation speed to 100.00% of its original speed
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Attacked unit) is dead) Equal to True
      • Then - Actions
        • Set t = True
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Attacked unit) is alive) Equal to True
      • Then - Actions
        • Set t = False
      • Else - Actions
    • Wait 2.00 seconds
    • Set t = False

• Sword Master 1
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Attacking unit) Equal to Dante (SWORD MASTER) 0000 <gen>
    • (Random integer number between 1 and 10) Equal to 1
    • (Level of Sword Master for (Attacking unit)) Greater than or equal to 1
  • Actions
    • Floating Text - Create floating text that reads Drive at (Position of (Attacking unit)) with Z offset 0.00, using font size 10.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
    • Set Ilmu = (Last created floating text)
    • Floating Text - Change Ilmu: Disable permanence
    • Floating Text - Change the lifespan of Ilmu to 1.50 seconds
    • Floating Text - Set the velocity of Ilmu to 64.00 towards 90.00 degrees
    • Unit - Add Carrion Swarm to (Attacking unit)
    • Wait 0.01 seconds
    • Unit - Order (Attacking unit) to Undead Dreadlord - Carrion Swarm ((Position of (Attacking unit)) offset by 256.00 towards (Facing of (Attacking unit)) degrees)
    • Unit - Set life of (Random unit from (Units in (Region centered at ((Position of Dante (SWORD MASTER) 0000 <gen>) offset by 400.00 towards (Facing of Dante (SWORD MASTER) 0000 <gen>) degrees) with size (300.00, 800.00)) matching (((Owner of (Attacked unit)) is an enemy of Playe to ((Life of (Attacked unit)) + ((Real((Strength of Dante (SWORD MASTER) 0000 <gen> (Exclude bonuses)))) x 4.00))
    • Wait 1.00 seconds
    • Unit - Remove Carrion Swarm from (Attacking unit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Attacking unit) is dead) Equal to True
      • Then - Actions
        • Set s = True
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Attacking unit) is alive) Equal to True
      • Then - Actions
        • Set s = False
      • Else - Actions
    • Wait 2.00 seconds
    • Set s = False

• Fire Power
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Attacking unit) Equal to Nero 0007 <gen>
    • (Random integer number between 1 and 1) Equal to 1
  • Actions
    • Unit - Move Peasant 0005 <gen> instantly to ((Position of Nero 0007 <gen>) offset by 50.00 towards (45.00 + (Facing of Nero 0007 <gen>)) degrees), facing (45.00 + (Facing of Nero 0007 <gen>)) degrees
    • Unit - Move Peasant 0005 <gen> instantly to ((Position of Nero 0007 <gen>) offset by 50.00 towards (Facing of Nero 0007 <gen>) degrees), facing (Facing of Nero 0007 <gen>) degrees
    • Unit - Move Peasant 0005 <gen> instantly to ((Position of Nero 0007 <gen>) offset by 50.00 towards (315.00 + (Facing of Nero 0007 <gen>)) degrees), facing (315.00 + (Facing of Nero 0007 <gen>)) degrees
    • Wait 0.10 seconds
    • Unit - Unhide Peasant 0004 <gen>
    • Unit - Unhide Peasant 0005 <gen>
    • Unit - Unhide Peasant 0005 <gen>
    • Wait 0.10 seconds
    • Trigger - Turn on MajuNero Copy <gen>
    • Wait 0.30 seconds
    • Trigger - Turn off MajuNero Copy <gen>
    • Unit - Move Peasant 0010 <gen> instantly to (Random point in firen1 <gen>), facing (45.00 + (Facing of Nero 0007 <gen>)) degrees
    • Unit - Move Peasant 0005 <gen> instantly to (Random point in firen2 <gen>), facing (45.00 + (Facing of Nero 0007 <gen>)) degrees
    • Unit - Move Peasant 0005 <gen> instantly to (Random point in firen3 <gen>), facing (45.00 + (Facing of Nero 0007 <gen>)) degrees
    • Unit - Hide Peasant 0004 <gen>
    • Unit - Hide Peasant 0005 <gen>
    • Unit - Hide Peasant 0003 <gen>

honestly, this felt like the purpose of this is spreading the model file only. and

clarification

its Gunslinger not Gunliser

 

[Rheiko]

leaks everywhere
i'm not reading the whole thing
but i assume it's not MUI
and.. he is an indonesian?

 

[Ofel]

@Rheiko
By seeing the whole triggers. I think yes...probably

 

[FUJI]

@Ofel

Sorry I didn't test the spell in game map because I've only review the code xDD .
Hide it with a spoiler ^^.