Damage Engine 5.A.0.0

[ThompZon]

do units with 0 auto-attack damage trigger damage event?

Units with 1 damage does, and you can modify it to 0 in the damage event. (set DamageEventAmount to 0)

 

[Rhobox]

Lua damage engine ceases to function 15 seconds after map start when copied into a new custom map. Has happened on a few maps when attempting to use Damage Engine.

Note: Was working exclusively in Lua custom scripts. Could be some interaction with garbage collection?

EDIT:

Any attempt to modify or remove the "Damage Tag" trigger completely breaks the damage engine ~15 seconds into the game.

EDIT 2:
After extensive testing I'd found that any function that does nothing but has the event
"Game - DamageEvent becomes Equal to 1.00"
will fix any problems I have but becomes completely non functional without something of that type.

 

[Ilexa]

First I wanna say, this is a great tool and is greatly improving the quality of my work but I am having 1 problem. Now call me a noob but I can't seem to wrap my head around how I can get the damage engine to detect heals and modify the heal; (for example making rejuvenation scale) if you could point me to the right direction I would be really grateful.

Aside from that, great job! This engine is amazing!

 

[Elprede]

You got his Heal Event for that.

 

[emil23]

i updated the damage engine in my map from very old version to the newest one but i have issue, in the middle or late game the fps sometimes drops to 1.0 has this ever been reported? i need to test it out myself because updating damage engine isnt the only thing i did. i wanted to read comments to find out about it but its almost 80 pages xd

 

[Kakerate]

If I copy and paste all the variables for the new version, it crashes my world editor. How can I import the variables?

 

[pick-a-chew]

If I copy and paste all the variables for the new version, it crashes my world editor. How can I import the variables?

I have had this problem for a while. A solution is to copy over the new engine code and then copy and paste in only the new variables you need. There's something about pasting numerous variables (or copies of variables) that makes the editor freak out, especially in maps that already have a lot of variables.

 

[Elprede]

@Kakerate Move all the folders into a new single folder that can be placed under the Variables folder. This allowed me to copy all variables with no problem. Just try experiencing what works for you.

@pick-a-chew The current setup for variables still crashes for an empty map.

 

[Kakerate]

boolean udg_IsDamageAttack
integer udg_NextDamageWeaponT
boolean udg_NextDamageIsMelee
boolean udg_NextDamageIsRanged
boolean udg_NextDamageIsAttack

Put this in my script header and it compiled, but dmgEvent is not working. I'll try what you suggested and get back to this post @GhostHunter123

edit: Seems to make no difference if I move the Vars folder out of the main folder, it still crashes on c/p.

Additionally, adding function names and variables like mod and dmg, that modders are likely to have already initialized in their maps is kind of a no-no. I see that DamageModiferEvent is a changed feature, but it actually does nothing in my map when function are set to run on it ==1., should check into that.


Lastly, here's where I'm stuck. My dmg handler uses ModEvent==1., and nothing was happening. "Maybe the variables can't be declared in this block of globals I threw it in", so I make the variables in GUI. NOW statements are being cut into global blocks of my code that I'm not putting in there. (Luckily I made a backup before even trying to do this because I knew with the state of WC3 that was once a simple copy paste is now 10 compiles of debugging something painfully rudimentary. Sigh.)
Multiply assigned variables names don't even give a tell as to where they were previously declared anymore.
Does this version of DamageEngine use the variable pflag as well, because just a line down from my declaration of it is where the random text is placed. Stuff like this needs to be in the documentation to prevent this mess.


Takeaway: If youre ever asking if youre doing backups too frequently, the answer is no. Just importing code has seemingly permanently broken this copy of my map. If I had not made a backup, I'd of been frustrated enough to put the WC3 scene behind me forever.

edit2: The problem was a % symbol in a comment. I've had this issue come up before, each time its seemingly random and I've documented a few of these compiler mishaps but don't have them organized together. I should make a post on compiler quirks. Despite this line working in the test map, it doesn't work on my map. I've no clue why, the rest of damageEngine *appears* to be working:

if udg_DamageEventDamageT == udg_DAMAGE_TYPE_NORMAL then

edit3: The initializations for the udg_DamageTypes is in the config funct, it looks like that didn't make it through the paste crash I had trying to import this. Yay

 

[Elprede]

@Kakerate I placed the Vars folders into a single folder and copied that first to my map. Then I copied the rest of the variables to my map. That worked for me. Perhaps, try this method to see if it works for you.

I also placed all the Vars folders into a single new folder. Then I put that new folder back into the main folder. That also was successful in copying the vars to my map without crashes. Be sure to place the new folder into the main folder or it will crash. And you might want to minimize the folders during the copying process.

 

[Eikonium]

@Bribe
Damage Engine [Lua] is crashing my Wc3, whenever two units hit each other.

I attached an example map for you, which is completely empty apart of Damage Engine and two adjacent footmans.
It crashes a second after map start, as soon as the footmans hit with their attacks.

 

[maxodors]

I tried to open the system, but I got "
"Unable to load file 'C:\Program Files\Warcraft III\Maps\High Elves.w3x'
- Level info data missing or invalid.""

 

[maxodors]

Do you still have a version that works for 1.26a?

@Bribe

 

[Av3n]

@maxodors there is a link to one such version if you click the Requirements tab:

• As of 20 June 2020, JNGP users who are still on WarCraft 3 1.26 can benefit from Damage Engine 3A, which integrates many of the design choices added in various stages of Damage Engine 5. This is a special update which only requires the JASS script be replaced (no new GUI variables added). Can be found here: Damage Engine 3A.0.0.0 and 3.8.0.0 | HIVE

 

[maxodors]

@maxodors there is a link to one such version if you click the Requirements tab:

Sorry, I just noticed it as well. Was planning to delete the comment before anyone noticed : )

 

[maxodors]

I got this error for some reason, when I tried to install 3.A version. I just changed damage engine trigger from the one in the file to the 3.A version.

 

[Elprede]

To fix the error, go to the Damage Engine Trigger and then search for method finish. Then change where it says returns nothing to returns boolean.

 

[maxodors]

To fix the error, go to the Damage Engine Trigger and then search for method finish. Then change where it says returns nothing to returns boolean.

I got another error:

 

[Elprede]

Right before the endmethod line, type return false.

By the way, it appears you did not fix your first error. The method finish that you have to made changes to is the one under the struct DamageTrigger.
Your second error is also related to the first error.

@Bribe
Damage Engine [Lua] is crashing my Wc3, whenever two units hit each other.

I attached an example map for you, which is completely empty apart of Damage Engine and two adjacent footmans.
It crashes a second after map start, as soon as the footmans hit with their attacks.

Bribe has left, so you will have to rely on yourself or others to fix the issue.

 

[maxodors]

Right before the endmethod line, type return false.

By the way, it appears you did not fix your first error. The method finish that you have to made changes to is the one under the struct DamageTrigger.
Your second error is also related to the first error.


Bribe has left, so you will have to rely on yourself or others to fix the issue.

I made changes under the struct DamageTrigger this time, but I still get an error "missing return".

 

[Elprede]

You need a return boolean before the endfunction. On the original code, that would be before the endmethod for the method finish that is under the struct DamageTrigger.

I am guessing you added it at the wrong spot. Can you show me your changes, so I can better assist you?

 

[Eikonium]

Bribe has left, so you will have to rely on yourself or others to fix the issue.

Didn't know that, thanks for the info!

 

[maxodors]

You need a return boolean before the endfunction. On the original code, that would be before the endmethod for the method finish that is under the struct DamageTrigger.

I am guessing you added it at the wrong spot. Can you show me your changes, so I can better assist you?

So, I was able to fix the error. However, I am not sure whether it is correct. I changed this:

static method finish takes nothing returns nothing
        if checkLife() and not blocked and udg_DamageEventAmount != 0.00 then
            call DamageTrigger.AFTER.run()
        endif
    endmethod

To this

static method finish takes nothing returns boolean
        if checkLife() and not blocked and udg_DamageEventAmount != 0.00 then
            call DamageTrigger.AFTER.run()
        endif
        return false
    endmethod

I tried to use this system in a simple way, but it doesn't really work. Also, how do you transfer "caster" for damage from another unit?

function Trig_VMR_Attack_Actions takes nothing returns nothing
    if UnitHasBuffBJ(udg_DamageEventSource, 'B00E') and not udg_IsDamageSpell then
        call UnitDamageTarget( udg_DamageEventSource, udg_DamageEventSource, 20.00, true, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_PLANT, null)
    endif
endfunction

//===========================================================================
function InitTrig_VMR_Attack takes nothing returns nothing
    set gg_trg_VMR_Attack = CreateTrigger(  )
    call TriggerRegisterVariableEvent( gg_trg_VMR_Attack, "udg_DamageEvent", EQUAL, 1.00 )
    call TriggerAddAction( gg_trg_VMR_Attack, function Trig_VMR_Attack_Actions )
endfunction

 

[Elprede]

You are issuing damage within a damage detection block, crashing the thread with an infinite loop.

Disable the trigger before issuing the damage and enable the trigger right after.

 

[maxodors]

You are issuing damage within a damage detection block, crashing the thread with an infinite loop.

Disable the trigger before issuing the damage and enable the trigger right after.

1. I didn't quite get you. I want to cause damage to the unit by the caster every time it attacks, while it has debuff. I have another timer function, which makes this debuff.

2. Did I fix DDS correctly?

 

[Beckx]

@Bribe
Damage Engine [Lua] is crashing my Wc3, whenever two units hit each other.

I attached an example map for you, which is completely empty apart of Damage Engine and two adjacent footmans.
It crashes a second after map start, as soon as the footmans hit with their attacks.

I've checked your example... to be honest this system is a mess... it was designed mainly for GUI usage, since GUI map makers cannot create AnyUnit damage event... i mean for coders this system is maybe too complex and not efficient.

damage events is handled through one real global variable, and damage values are handled through globals as well which can cause desyncing when there are too many dmg events in a moment... i mean that system contains everything u can possibly think about when it comes to managing damage encounters, but everyone should ask before using it, do i really need that many features ? Wouldn't it be nice to make something more optimized for my project ?

If you are using lua, that means you don't need system like this and everything u need are natives...

TriggerRegisterAnyUnitEventBJ(trg, EVENT_PLAYER_UNIT_DAMAGED) -- trigger catches dmg event after its recalculated (armor reductions ect...)
TriggerRegisterAnyUnitEventBJ(trg, EVENT_PLAYER_UNIT_DAMAGING) -- trigger catches dmg event before its recalculated (the value which comes into event...)

-- some fundamental natives which catches and sets everything u possibly need...
-- whith those everything other like absorbing system, blocking system or anything else is doable and only limit is your imagination
-- + you don't need to use globals and unsafe real value event ... you are free to run properly scoped function on dmg event... which uses local vars and never desync

BlzSetEventAttackType(attackType)
BlzSetEventDamage(damage)
BlzSetEventDamageType(damageType)
BlzSetEventWeaponType(weaponType)
GetEventDamage()
GetEventDamageSource()
BlzGetEventDamageTarget()
BlzGetEventDamageType()
BlzGetEventWeaponType()
BlzGetEventAttackType()

 

[Eikonium]

If you are using lua, that means you don't need system like this and everything u need are natives...

Right! I hoped to save time by using other modders systems, but self building a system for my needs has its own benefits of course. I do notice that I have to get familiar with the new natives. Thank you very much, Sir! Your time investment is much appreciated!

 

[yobgoblin]

I'm having a difficult time understanding what to set the actual event values to:
How would something like Game - DamageModifierEvent Less than 0.00 be different from if it were Less than -1.00 or Less than 3.00? The description above just says to use 1.00, 2.00, 3.00, but I don't know what the differences would be if any.
A few pages back I see that there is even an example that uses -420.69 (nice), so am I right to assume I can just choose any number I want as long as it's <4 for raw damage and >=4 for reduced damage?

Similarly for the other events, like DamageEvent, LethalDamageEvent, AOEDamageEvent, would these also use the same rules as above?

edit: clarified my second questiono

 

[maxodors]

You are issuing damage within a damage detection block, crashing the thread with an infinite loop.

Disable the trigger before issuing the damage and enable the trigger right after.

Sorry, it was quite stupid by me. I tried to do it before the if statement and after. It still does not work.

function Trig_VMR_Attack_Actions takes nothing returns nothing
    
    call DisableTrigger( GetTriggeringTrigger() )
    if UnitHasBuffBJ(udg_DamageEventSource, 'B00E') and not udg_IsDamageSpell and IsUnitEnemy(udg_DamageEventTarget, GetOwningPlayer(udg_DamageEventSource)) then
        call UnitDamageTarget( udg_DamageEventTarget, udg_DamageEventSource, 20.00, true, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_PLANT, null)
    endif
    call EnableTrigger( GetTriggeringTrigger() )
   
endfunction

//===========================================================================
function InitTrig_VMR_Attack takes nothing returns nothing
    set gg_trg_VMR_Attack = CreateTrigger(  )
    call TriggerRegisterVariableEvent( gg_trg_VMR_Attack, "udg_DamageEvent", EQUAL, 1.00 )
    call TriggerAddAction( gg_trg_VMR_Attack, function Trig_VMR_Attack_Actions )
endfunction

 

[Wrda]

I've checked your example... to be honest this system is a mess... it was designed mainly for GUI usage, since GUI map makers cannot create AnyUnit damage event... i mean for coders this system is maybe too complex and not efficient.

damage events is handled through one real global variable, and damage values are handled through globals as well which can cause desyncing when there are too many dmg events in a moment... i mean that system contains everything u can possibly think about when it comes to managing damage encounters, but everyone should ask before using it, do i really need that many features ? Wouldn't it be nice to make something more optimized for my project ?

If you are using lua, that means you don't need system like this and everything u need are natives...

TriggerRegisterAnyUnitEventBJ(trg, EVENT_PLAYER_UNIT_DAMAGED) -- trigger catches dmg event after its recalculated (armor reductions ect...)
TriggerRegisterAnyUnitEventBJ(trg, EVENT_PLAYER_UNIT_DAMAGING) -- trigger catches dmg event before its recalculated (the value which comes into event...)

-- some fundamental natives which catches and sets everything u possibly need...
-- whith those everything other like absorbing system, blocking system or anything else is doable and only limit is your imagination
-- + you don't need to use globals and unsafe real value event ... you are free to run properly scoped function on dmg event... which uses local vars and never desync

BlzSetEventAttackType(attackType)
BlzSetEventDamage(damage)
BlzSetEventDamageType(damageType)
BlzSetEventWeaponType(weaponType)
GetEventDamage()
GetEventDamageSource()
BlzGetEventDamageTarget()
BlzGetEventDamageType()
BlzGetEventWeaponType()
BlzGetEventAttackType()

You clearly don't know the history behind this system.
Many of these features weren't possible on older patches as in, implementing them in a simple way. This was innovative because it differenciated between spell damage and physical, didn't have to make 1000000 unit takes damage events, handled recursion, and countless more. And no it wasn't made for "GUIers", it was made for people who wanted a complex system.
Sure, many of these features are now possible to do easily, but still some that are a nuisance, e.g.: detect AOE damage, main target and secundary ones; bouncing damage, main target and secundary ones; multi-shot, main target and secundary ones; same unit hit simultaneously by the same source.
Tell me, do all the natives do this work for me? Is it that simple to do?
Also I was unable to find any information about real value event being unsafe and that it cause desyncs, and without any source this will be viewed as some bullshit made up.

 

[Beckx]

You clearly don't know the history behind this system.
Many of these features weren't possible on older patches as in, implementing them in a simple way. This was innovative because it differenciated between spell damage and physical, didn't have to make 1000000 unit takes damage events, handled recursion, and countless more. And no it wasn't made for "GUIers", it was made for people who wanted a complex system.
Sure, many of these features are now possible to do easily, but still some that are a nuisance, e.g.: detect AOE damage, main target and secundary ones; bouncing damage, main target and secundary ones; multi-shot, main target and secundary ones; same unit hit simultaneously by the same source.
Tell me, do all the natives do this work for me? Is it that simple to do?
Also I was unable to find any information about real value event being unsafe and that it cause desyncs, and without any source this will be viewed as some bullshit made up.

Yeah, i don't know backstory behind this system and i really did not want to offend anyone... i've just pointed out that today, one can easily create dmg engine on his own, maybe not this complex, but good eough for their map + many of system logic can by simplified in Lua i mean Lua version of this system is clearly not optimized as good as it could be and that's the reason why i gave advice to Lua coder rather build up his own logic. Warcraft 3 engine (reforged especially) is far from optimized ... and if you can save some CPU power by avoiding existing systems which oftenly contains dozens of logic which u will never use and creating your own to fill your requirements then why the hell not... My statement is this system is MESS for Lua usage that's all... it's perfect for GUI-ers and maybe for JASSers as well, cannot judge since i know jackshit about jass.

 

[maxodors]

You are issuing damage within a damage detection block, crashing the thread with an infinite loop.

Disable the trigger before issuing the damage and enable the trigger right after.

Sorry, I just wanted to follow up on my question. I need this system as air for my project.

 

[emil23]

hey nice system but i have a problem. my hero has multishoot based on vanillia barage and when he attacks it detects his attack with trigger 3 times because he shoots 3 arrows 1 basic one +2 from multishoot. any idea how can i make it so it detects only his main attack? Because then all of my trigger is ruined if it decets his attack 3 times all futher actions dont work propley.


i know about condition ,,is an attack'' that has been aded recently but i cant really use it because when i updated my damage engine my game started to have low fps so i must now take away the new ver of damage engine and test it on old one again to check if it was the reason of low fps.


there are also screenshoots of my problemw ith hero's attack https://cdn.discordapp.com/attachments/311662737015046144/808092454150471680/unknown.png

if its checked 3 times at once then all spells are added too quickly. it should be checked and ran 1 time per heroes attack

 

[OverClocked]

Is it possible to make the damage engine ignore specific players? Cause I have a map with a lot of mobs and I think the damage engine is causing some lag. So I want to have that computer player ignored by it.

 

[emil23]

Is it possible to make the damage engine ignore specific players? Cause I have a map with a lot of mobs and I think the damage engine is causing some lag. So I want to have that computer player ignored by it.

Sadly i dont know answer to your issue but i AM curious about Ur problem. For long time i was using 5.4.2.3 ver of damage engine then łater i updated IT and i had the latest version of damage engine but i noticed that my map started to lag. Do you use the latest damage engine version?

 

[Avatars Lord]

@Bribe
Damage Engine [Lua] is crashing my Wc3, whenever two units hit each other.

I attached an example map for you, which is completely empty apart of Damage Engine and two adjacent footmans.
It crashes a second after map start, as soon as the footmans hit with their attacks.

Try adding the "FastTriggers" script in the demo category to your map, that solved the issue for me.

 

[Eikonium]

Try adding the "FastTriggers" script in the demo category to your map, that solved the issue for me.

Thanks for sharing your finding, much appreciated! Actually, I already removed Damage Engine from my map, since I only need basic stuff that Reforged can do natively, but your suggestion will definitely be useful for the next poor guy having this issue

 

[OverClocked]

Sadly i dont know answer to your issue but i AM curious about Ur problem. For long time i was using 5.4.2.3 ver of damage engine then łater i updated IT and i had the latest version of damage engine but i noticed that my map started to lag. Do you use the latest damage engine version?

Yes, although I doubt it's because of the new version.

 

[Robert Hoang 13690]

How Can I Add Healing Healing detection to the map, I'm new please help me ^^

 

[Achille]

This system has made my life so much easier. Implementing everything from passive damage bonuses to 'procable' abilities on attacks become so easy. This is incredibly easy to use and has been such a great help.

 

[rkemsley]

Hey! Seems to be having a strange inconsistency issue with this DDS.

I have an ability, based on Envenomed Spears, which deals damage based on the attacking units agility, and removes 1 strength every second that the target is poisened.

• EnfeeblingPoisonDamage
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventTarget has buff Enfeebling Poison (Stacking)) Equal to True
    • DamageEventPrevAmt Equal to 5.00
  • Actions
    • -------- Add to EP_UnitGroup --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventTarget is in EP_UnitGroup.) Not equal to True
      • Then - Actions
        • Unit Group - Add DamageEventTarget to EP_UnitGroup
        • Hashtable - Save (Ability: (Unit: DamageEventTarget's Ability with Ability Code: Attribute Bonus )'s Integer Level Field Strength Bonus ('Istr'), of Level: 0) as (Key EP_AttributeHandle.) of (Key EP_TempHandle.) in EP_HastTable.
      • Else - Actions
    • -------- - --------
    • -------- Turn on EnfeeblingPoisonTimer --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (EnfeeblingPoisonTimer <gen> is on) Not equal to True
      • Then - Actions
        • Trigger - Turn on EnfeeblingPoisonTimer <gen>
      • Else - Actions
    • -------- - --------
    • -------- Set Damage --------
    • Set VariableSet DamageEventAmount = (Real(((Integer(((Real((Agility of DamageEventSource (Include bonuses)))) / 10.00))) x (Integer(DamageEventPrevAmt)))))
    • -------- - --------
    • -------- Reduce Strength if total Strength greater than 0 --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Strength of DamageEventTarget (Include bonuses)) Greater than 0
      • Then - Actions
        • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Attribute Bonus )'s Integer Level Field: Strength Bonus ('Istr') of Level: 0 to ((Ability: (Unit: DamageEventTarget's Ability with Ability Code: Attribute Bonus )'s Integer Level Field Strength Bonus ('Istr'), of Level: 0) - 1)
        • Unit - Increase level of Attribute Bonus for DamageEventTarget
        • Unit - Decrease level of Attribute Bonus for DamageEventTarget
      • Else - Actions

• EnfeeblingPoisonTimer
  • Events
    • Time - Every 0.10 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in EP_UnitGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) has buff Enfeebling Poison (Stacking)) Not equal to True
          • Then - Actions
            • Ability - Set Ability: (Unit: (Picked unit)'s Ability with Ability Code: Attribute Bonus )'s Integer Level Field: Strength Bonus ('Istr') of Level: 0 to (Load (Key EP_AttributeHandle.) of (Key EP_TempHandle.) from EP_HastTable.)
            • Unit - Increase level of Attribute Bonus for (Picked unit)
            • Unit - Decrease level of Attribute Bonus for (Picked unit)
            • Hashtable - Clear all child hashtables of child (Key EP_TempHandle.) in EP_HastTable.
            • Unit Group - Remove (Picked unit) from EP_UnitGroup.
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Number of units in EP_UnitGroup) Less than or equal to 0
          • Then - Actions
            • Trigger - Turn off (This trigger)
          • Else - Actions

The problem is that the ability only works with my Blood Mage unit (I was using the Blood Mage initally to test the damage part of the ability). When I add the Ability to other units, the damage and the strength reduction doesn't work.

Wondering what could be the problem!

 

[SebioL]

I congratulate Bribe and all the other contributors for this ingenious and very useful work for the community, you saved the lives of several players! lolol
Although my case was only useful to use a small fraction of all this wonderful work, but for my current modifications, this function was extremely important in order not to cause "Break" in my map and above all, to make it possible to give projects, which previously did not seem to have a solution.
I needed to use only the damage detector for "Melee Damage", trying to identify all attacks from a minimum distance, to create after each attack an additional order of action for all melee units, using only this single event and trigger.

Of course, I could easily develop this on my own, just with triggers in the GUI.
But my problem was the extreme leaks of event objects, due to the infinite amount of each new blow, that would trigger almost every millisecond several shots of the same event.
I expect and believe that this powerful DDS will be able to not cause leaks even in battles of 300vs300 units activating new attacks and receiving new orders simultaneously.

Edit: Once again, I thank this team of coders.

 

[Ugabunda]

Can I somehow distinguish between Pulverize and Cleaving Attack?

Apparently they both use DAMAGE TYPE ENHANCED. In my case, I have an item with Cleaving Attack and an ability which uses Pulverize as base. When Pulverize triggers, it fires triggers specifically for the Pulverize.

Combined however (the hero with Pulverize + item), the trigger of the Pulverize-Ability fires at every single unit hit by the Cleave Attack (which is funny, but I still wanna fix it xD).

 

[chopinski]

Can I somehow distinguish between Pulverize and Cleaving Attack?

Apparently they both use DAMAGE TYPE ENHANCED. In my case, I have an item with Cleaving Attack and an ability which uses Pulverize as base. When Pulverize triggers, it fires triggers specifically for the Pulverize.

Combined however (the hero with Pulverize + item), the trigger of the Pulverize-Ability fires at every single unit hit by the Cleave Attack (which is funny, but I still wanna fix it xD).

You can check for the ATTACK_TYPE. Pulverize has ATTACK_TYPE_NORMAL, meaning spell damage, while cleaving attack do not.

 

[XMI]

Try adding the "FastTriggers" script in the demo category to your map, that solved the issue for me.

Heyo good day, just to be sure do you mean this by "FastTriggers" ?
[Lua] Ridiculously Fast Triggers
Cheers!

 

[Ugabunda]

What exactly constitutes "IsDamageAttack"?

I was under the assumption that this somehow checks if the attack is done via autoattacking. But spells which deal attack type NORMAL and damage type NORMAL also trigger IsDamageAttack. Is this by design?

 

[chopinski]

What exactly constitutes "IsDamageAttack"?

I was under the assumption that this somehow checks if the attack is done via autoattacking. But spells which deal attack type NORMAL and damage type NORMAL also trigger IsDamageAttack. Is this by design?

DAMAGE_TYPE_NORMAL is the damage type dealt when a unit attacks another, so this is a Warcraft standard. If you have in a trigger or in code a UnitDamageTarget() and you set the damage type to DAMAGE_TYPE_NORMAL then it will be seen as an attack. I would recommend not using DAMAGE_TYPE_NORMAL unless you want the trigger damage seen as an attack.

 

[Ugabunda]

Thanks for the quick reply Chopinski.

I want to keep this particular spell doing DAMAGE_TYPE_NORMAL damage, so that it deals more damage with armor reduction. As workaround I added the following line before to the spell and added a condition to another trigger to ignore this type of damage.

• Set VariableSet NextDamageType = DamageTypeCode

That fixed it.

However, a separate problem which very much confuses me:

In my map I use 3 items:
1) 1 which has the standard WC3 Cleave ability
2) 1 which provides life steal. I triggered the lifesteal, to ignore ORB problems
3) 1 which "slows" enemies on damage. This ability is also triggered on damage

The interaction between the 3 items is currently like this:

• Item 1) and 2) completely stack. Meaning if you cleave a group of enemies, you steal a lot more life than when attacking a single one
• Item 1) and 3) do NOT stack. I want them to stack though

Here the 2 triggers of item 2) and 3) for comparison:

Spoiler

LIFE STEAL:

• Mask of Death
  • Events
    • Game - DamageEvent becomes Less than 1.00
    • Game - LethalDamageEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventSource has an item of type Mask of Death) Equal to True
    • (DamageEventTarget is A structure) Equal to False
    • (DamageEventSource belongs to an enemy of (Owner of DamageEventTarget).) Equal to True
    • IsDamageCode Equal to False
  • Actions
    • Special Effect - Create a special effect attached to the chest of DamageEventSource using Abilities\Spells\Undead\VampiricAura\VampiricAuraTarget.mdl
    • Special Effect - Destroy (Last created special effect)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventSource is an illusion) Equal to False
      • Then - Actions
        • Set VariableSet MaskOfDeath_CV = (Custom value of DamageEventSource)
        • Set VariableSet MaskOfDeath_HealValue = (0.15 x DamageEventAmount)
        • Unit - Set life of DamageEventSource to ((Life of DamageEventSource) + (MaskOfDeath_HealValue - (MaskOfDeath_HealValue x HealReduction_Multiplier[MaskOfDeath_CV])))
      • Else - Actions

SLOW ON ATTACK DAMAGE:

• Eye of Skadi
  • Events
    • Game - DamageEvent becomes Less than 1.00
  • Conditions
    • (DamageEventSource has an item of type Eye of Skadi) Equal to True
    • (DamageEventTarget is A structure) Equal to False
  • Actions
    • Set VariableSet HealReduction_CV = (Custom value of DamageEventTarget)
    • Set VariableSet HealReduction_Multiplier[HealReduction_CV] = 0.40
    • Set VariableSet HealReduction_Time[HealReduction_CV] = 15
    • Set VariableSet HealReduction_Buff[HealReduction_CV] = Slowed
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventTarget is in HealReduction_Group.) Equal to False
      • Then - Actions
        • Unit Group - Add DamageEventTarget to HealReduction_Group
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Heal Reduction <gen> is on) Equal to False
      • Then - Actions
        • Trigger - Turn on Heal Reduction <gen>
      • Else - Actions
    • -------- --------
    • Set VariableSet Vertex_CV = (Custom value of DamageEventTarget)
    • Set VariableSet Vertex_Time[Vertex_CV] = 15
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventTarget is in Vertex_Group.) Equal to False
      • Then - Actions
        • Unit Group - Add DamageEventTarget to Vertex_Group
        • Set VariableSet Vertex_Ability[Vertex_CV] = Freeze (Undispellable)
        • Set VariableSet Vertex_Buff[Vertex_CV] = Slowed (Undispellable)
        • Set VariableSet Vertex_Delay[Vertex_CV] = True
        • -------- --------
        • Animation - Change DamageEventTarget's vertex coloring to (50.00%, 75.00%, 80.00%) with 0.00% transparency
        • -------- --------
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (DamageEventSource is A melee attacker) Equal to True
          • Then - Actions
            • Unit - Add Freeze (Undispellable) to DamageEventTarget
            • Unit - Remove Slowed (Undispellable) buff from DamageEventTarget
            • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Freeze (Undispellable))'s Real Level Field: Movement Speed Increase (%) ('Oae1') of Level: 0 to (1.00 x -0.50)
            • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Freeze (Undispellable))'s Real Level Field: Attack Speed Increase (%) ('Oae2') of Level: 0 to (1.00 x -0.50)
            • Unit - For DamageEventTarget, Ability Freeze (Undispellable), Disable ability: True, Hide UI: False
            • Unit - For DamageEventTarget, Ability Freeze (Undispellable), Disable ability: False, Hide UI: False
          • Else - Actions
            • Unit - Add Freeze (Undispellable) to DamageEventTarget
            • Unit - Remove Slowed (Undispellable) buff from DamageEventTarget
            • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Freeze (Undispellable))'s Real Level Field: Movement Speed Increase (%) ('Oae1') of Level: 0 to (1.00 x -0.25)
            • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Freeze (Undispellable))'s Real Level Field: Attack Speed Increase (%) ('Oae2') of Level: 0 to (1.00 x -0.25)
            • Unit - For DamageEventTarget, Ability Freeze (Undispellable), Disable ability: True, Hide UI: False
            • Unit - For DamageEventTarget, Ability Freeze (Undispellable), Disable ability: False, Hide UI: False
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Vertex Coloring <gen> is on) Equal to False
      • Then - Actions
        • Countdown Timer - Start Vertex_Timer as a Repeating timer that will expire in 0.20 seconds
        • Trigger - Turn on Vertex Coloring <gen>
      • Else - Actions

--> I don't understand why Cleave works for 2), but not for 3)

 

[Bribe]

@Ugabunda I think you'll also need to show your Cleave trigger. Additionally, try to add debug messages to show if an if/then/else block was entered or not, in order to determine which part (if any) of your code is run for the subsequently-cleaved targets.

 

[Ugabunda]

Hi Bribe, the item with Cleave (it's called Battle Fury) uses the default "Cleaving Attack" ability, see the settings here:

Battle Fury has only 1 trigger attached to it:

• Battle Fury
  • Events
    • Game - DamageModifierEvent becomes Less than 1.00
  • Conditions
    • (DamageEventSource has an item of type Battle Fury) Equal to True
    • (DamageEventTarget is A structure) Equal to False
    • (DamageEventTarget is A Hero) Equal to False
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventSource is A melee attacker) Equal to True
      • Then - Actions
        • Set VariableSet DamageEventAmount = (DamageEventAmount + 18.00)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (DamageEventSource is A ranged attacker) Equal to True
          • Then - Actions
            • Set VariableSet DamageEventAmount = (DamageEventAmount + 6.00)
          • Else - Actions

What I tried to "debug": I added a "kill DamageEventTarget" at the very beginning of the trigger for the item which doesn't interact with cleave. Result: Only the main Target is instantly killed. All other cleaved targets stay alive. So it already fails at this very early point...

Could it be that when you modify damage, other triggers can no longer recognize it?

Edit: So I experimented some more, and what makes it interact is if I add the Event "Game - LethalDamageEvent becomes Equal to 1.00" to the non-interacting trigger. But I don't understand why.

To illustrate, the following DOES interact with cleave. The other one (see previous post) doesn't.

Spoiler

• Eye of Skadi
  • Events
    • Game - DamageEvent becomes Less than 1.00
    • Game - LethalDamageEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventSource has an item of type Eye of Skadi) Equal to True
    • (DamageEventTarget is A structure) Equal to False
  • Actions
    • Set VariableSet HealReduction_CV = (Custom value of DamageEventTarget)
    • Set VariableSet HealReduction_Multiplier[HealReduction_CV] = 0.40
    • Set VariableSet HealReduction_Time[HealReduction_CV] = 15
    • Set VariableSet HealReduction_Buff[HealReduction_CV] = Slowed (Undispellable)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventTarget is in HealReduction_Group.) Equal to False
      • Then - Actions
        • Unit Group - Add DamageEventTarget to HealReduction_Group
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Heal Reduction <gen> is on) Equal to False
      • Then - Actions
        • Trigger - Turn on Heal Reduction <gen>
      • Else - Actions
    • -------- --------
    • Set VariableSet Vertex_CV = (Custom value of DamageEventTarget)
    • Set VariableSet Vertex_Time[Vertex_CV] = 15
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventTarget is in Vertex_Group.) Equal to False
      • Then - Actions
        • Unit Group - Add DamageEventTarget to Vertex_Group
        • Set VariableSet Vertex_Ability[Vertex_CV] = Freeze (Undispellable)
        • Set VariableSet Vertex_Buff[Vertex_CV] = Slowed (Undispellable)
        • -------- --------
        • Animation - Change DamageEventTarget's vertex coloring to (50.00%, 75.00%, 80.00%) with 0.00% transparency
        • -------- --------
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (DamageEventTarget is A melee attacker) Equal to True
          • Then - Actions
            • Unit - Add Freeze (Undispellable) to DamageEventTarget
            • Unit - Remove Slowed (Undispellable) buff from DamageEventTarget
            • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Freeze (Undispellable))'s Real Level Field: Movement Speed Increase (%) ('Oae1') of Level: 0 to (1.00 x -0.25)
            • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Freeze (Undispellable))'s Real Level Field: Attack Speed Increase (%) ('Oae2') of Level: 0 to (1.00 x -0.25)
            • Unit - For DamageEventTarget, Ability Freeze (Undispellable), Disable ability: True, Hide UI: False
            • Unit - For DamageEventTarget, Ability Freeze (Undispellable), Disable ability: False, Hide UI: False
          • Else - Actions
            • Unit - Add Freeze (Undispellable) to DamageEventTarget
            • Unit - Remove Slowed (Undispellable) buff from DamageEventTarget
            • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Freeze (Undispellable))'s Real Level Field: Movement Speed Increase (%) ('Oae1') of Level: 0 to (1.00 x -0.50)
            • Ability - Set Ability: (Unit: DamageEventTarget's Ability with Ability Code: Freeze (Undispellable))'s Real Level Field: Attack Speed Increase (%) ('Oae2') of Level: 0 to (1.00 x -0.50)
            • Unit - For DamageEventTarget, Ability Freeze (Undispellable), Disable ability: True, Hide UI: False
            • Unit - For DamageEventTarget, Ability Freeze (Undispellable), Disable ability: False, Hide UI: False
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Vertex Coloring <gen> is on) Equal to False
      • Then - Actions
        • Countdown Timer - Start Vertex_Timer as a Repeating timer that will expire in 0.20 seconds
        • Trigger - Turn on Vertex Coloring <gen>
      • Else - Actions