[JASS] call DestroyTrigger(GetTriggeringTrigger())

[darkrider]

i read that the destroy trigger function may cause random crashes in maps, something about indexes stacks or something i dont remember right now...

My question is:

Is destroying a trigger a good or a bad choice?

Note: i have no idea about JASS... im using that function in GUI

 

[Eleandor]

Why would you ever destroy a trigger in GUI?

In certain complex jass systems where you create multiple triggers per unit, it's pretty obvious that you want to destroy those triggers if the unit dies, but it really doesn't matter in GUI.

 

[darkrider]

somebody said once that destroying one-shot triggers was something good

actually i dont remember where i read that


So... i shouldnt do that?

 

[Vestras]

If you're sure that you won't use them again, and want to have some more memory space, then yes.

 

[Captain Griffen]

Don't destroy triggers. The only acceptable usage is once in a long time periodic as part of a damage detection system. Then you should be using a system, and even then it is debateable if the handle index leaks are better than risking it...

In certain complex jass systems where you create multiple triggers per unit, it's pretty obvious that you want to destroy those triggers if the unit dies, but it really doesn't matter in GUI.

No, you don't want to destroy them, because making them in the first place was stupid.

If you're sure that you won't use them again, and want to have some more memory space, then yes.

Not really worth the risk, DestroyTrigger is borked. Memory is cheap, handle index corruption makes maps go boom.

 

[Eleandor]

No, you don't want to destroy them, because making them in the first place was stupid.

Uh...
There really are times when you need to create a trigger for each unit on the map and want to destroy the trigger when the unit is no longer on the map...

 

[PurplePoot]

Only to spread the few specific events: EVENT_UNIT_DAMAGED/_ACQUIRED_TARGET/_TARGET_IN_RANGE(/_STATE_LIMIT if anyone actually knows what the heck it does).

 

[Captain Griffen]

Uh...
There really are times when you need to create a trigger for each unit on the map and want to destroy the trigger when the unit is no longer on the map...

No, there aren't. Give me a real example where you've needed to do that.

 

[darkrider]

ok... thy mr griffen ^^

 

[bountygiver]

Hmm.. to be on the safe side, I'll destroy triggers only at the LAST LINE of the function. That works for JASS though, no idea how will it turn out for GUI.

 

[PurplePoot]

No, it still is no safer than destroying them anywhere else. As if one object kills your map's performance anyways.

 

[Captain Griffen]

No, it still is no safer than destroying them anywhere else. As if one object kills your map's performance anyways.

Actually it is somewhat safer, but we cannot be sure (both for reasons of other threads fire off from it still running, and any other issues we've yet to find a smoking gun for) that it's safe.

 

[darkrider]

well... i was destroying triggers at the end of each trigger... they could not be executed twice coz they were "elapsed game time events" and when a unit learns a skill i checked for it to be lvl 4 and destroy the trigger (as it is an aos map ... skills are learned only once) but ive already deleted all of the destroy trigger function calls

 

[bountygiver]

No, it still is no safer than destroying them anywhere else. As if one object kills your map's performance anyways.

Yes it does. Imagine a targeted immolation spell, and I use a looping trigger or a timer to execute the functions. If the unit dies, but the trigger is still there... Damn, I cant even imagine that.

Even if I disable the trigger, the trigger and its local variables and handles are still there, present in the memory. Of course if won't show much effect with 1 unit. But what with 100 or even 1000 units?

For the sake of memory management I still recommend destroying triggers.

 

[Captain Griffen]

Yes it does. Imagine a targeted immolation spell, and I use a looping trigger or a timer to execute the functions. If the unit dies, but the trigger is still there... Damn, I cant even imagine that.

Even if I disable the trigger, the trigger and its local variables and handles are still there, present in the memory. Of course if won't show much effect with 1 unit. But what with 100 or even 1000 units?

For the sake of memory management I still recommend destroying triggers.

If you're using dynamic triggers at all for that, you're doing it wrong.

 

[PurplePoot]

My statement assumes that you code your map correctly.

 

[bountygiver]

If you're using dynamic triggers at all for that, you're doing it wrong.

Hmm? In which sense?

As far as I know my triggers still work fine for me, regardless in single player testing or online/LAN multiplayer gaming, despite the fact they indeed involves much unnecessary work and looks too complex for direct importing.

------------------------------------------------------------------------------------------------------------------------

EDIT (To topic starter): Anyway, to destroy triggers or not, it's up to you. As long as it does not interfere with your intended functions it should be fine.

 

[PurplePoot]

They're inconsistently buggy, easy to screw up when writing, and generally unnecessary anyways.