07:45, 13th Jun 2014
BPower:
Changes mentioned are made. Approved.

12:43, 21st May 2014
PurgeandFire: Review:
http://www.hiveworkshop.com/forums/2529843-post17.html

 

Ahh you uploaded it at last. Good job on the spell.

 

Where is my requested spells?

 

after reading the configuration, I think I like the concept, code looks perfect, I can't find anything's wrong. Except this:

• Unit - Order BlindDummy to Undead Banshee - Curse TargetUnit

I'm not sure but I think the order need to be stored in variable. Just wait for other's opinion.

Good job ! I haven't checked the object editor data, but seeing from the code, I vote for quick approval

 

I don't think its needed a variable for that :b also, it's nearly 2 bytes of a crappy variable.
But I think it should be only a dummy for the debuff, do it at the init trigger .
Also, the spell can get messy if cast constantly (in terms of whether being able to attack or not).
4/5 good work

 

Lol.

Hey, good job daffa!

 

wait, I think the order DOES need to be stored into variable and added to configuration part, in case user has another "Channel" ability with same order id, it will bugged if user can't configure.. please fix it. still haven't check the file though

also every aspect of floating text should be configurable (fading age, lifespan, size, etc.)

 

The "ability" you are talking about is the dummy's one, it's based on curse, so what you just said doesn't make sense.

 

I know you noticed that part so why you deleted it from your quote? I said it because I had reason: I haven't opened the file. your post 10x makes no sense sir.

 

That is irrelevant, you don't need to check the file to see if it's based on curse or not, and it is a dummy ability, why should it be channel-based?
Anyway, I'm not going to argue about this stupid thing.

 

Why it only can be used on heroes? It didn't work for me when I tried it on a normal unit.

In your trigger "Blind Loop": You store "Picked unit" twice into a variable if the first condition is true.

First you do:

• Set BlindConfuseTargetAttack = False

And then you check a boolean and would also set it to false, that doesnt make sense:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 'IF'-Bedingungen
    • BlindDisablesAttack == True
  • Then - Actions
    • Set BlindConfuseTargetAttack = False
  • Else - Actions

And anyway don't set it before, if you later check a boolean to possibly set it to an other value. You could take usage of the "Else" here.

Same you do with "ShowNewDamageRateText":

• Set ShowNewDamageRateText = True
• ...
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 'IF'-Bedingungen
    • BlindIncreasePhysicalDamage == False
    • BlindIncreaseMagicalDamage == False
    • BlindIncreaseTriggeredDamage == False
  • Then - Actions
    • Trigger - Turn off Blind Damage Text <gen>
    • Set ShowNewDamageRateText = False
  • Else - Actions

Personally I prefer indexing instead of UnitGroups, but I think it's ok here.
Anyway I think using a counter for instances is better to check instead of using the function "Number of Units in Group" so often. (to turn trigger on/off)
Using the count function is less efficient.

Furthermore I think throwing a flashbang or something similar would improve the realistic near a lot, instead of casting an instant spell without any projectile graphics.

Else it worked fine. Code is not very complex, but once all works properly it might be useful. (no rating yet)

 

Just a short statement to the booleans "BlindConfuseTargetAttack" and "ShowNewDamageRateText":

The parser anyway gets to the If/Then/Else part, so it's kind of redundant to set the boolean before. You could only set it in the 'Then' and 'Else' part.

 

you use 0.03125 sec
hihi