Big Rock

This bundle is marked as awaiting update. A staff member has requested changes to it before it can be approved.
Choose a point and a rock will damage and push all the enemies in its path.

One of my firsts spells!

This spell is from this map : League of Heroes Arena v.2.0h - (updated - 26 april 2018) - (from the Ancient hero)


3a5d69ad50872357ec86b1fb67e29c28.gif


Previews
Contents

Big Rock (Map)

Reviews
MyPad
Notes: The spell triggers could use dynamic indexing. Hero_ancient points to a static unit. Care to explain? Implementation leaks a lot of locations. The spell uses a wait on the effect of the spell, which is disliked by most. The spell has some...

MyPad

Spell Reviewer
Level 20
Joined
May 9, 2014
Messages
1,635

Notes:

  • The spell triggers could use dynamic indexing.
  • Hero_ancient points to a static unit. Care to explain?
  • Implementation leaks a lot of locations.
  • The spell uses a wait on the effect of the spell, which is disliked by most.
  • The spell has some performance overhead, which could affect its approval rating.

Reparations:

  • As said, the spell could use dynamic indexing.
  • Have a temporary variable point to the location of the object and remove it.
    • To remove a location, simply type using Custom Script:
      • Custom Script: call RemoveLocation(yourLoc)
  • To destroy a group, simply declare the following function:
    • Custom Script: call DestroyGroup(yourGroup)
  • Include another real variable that acts as the counter for the duration of the spell.
    • This will guarantee accuracy in the measurement of time, which the wait does not generally provide.
  • Try to reduce function calls in the triggers by storing them to temporary variables, or using them minimally.
    • Function calls are those which are in parentheses, such as
      • (Picked unit)
  • There should be a configuration trigger, which does the initialization for the user.
 
Last edited:

MyPad

Spell Reviewer
Level 20
Joined
May 9, 2014
Messages
1,635
Top