Lock On Battle System Version 2.0a

[Moderator]

16:50, 16th Jun 2010
Hanky:
Find an other way to attach the datas to your units. To use the custom value of an unit is the wrong way. You should at least use hashtables.

 

[neku99]

Well here's version 2.0. The first one I submitted got rejected due to noobness(I guess) ._. I do hope this version will suffice.

 

[Kingz]

If the moderator rejected the previous version i do hope you fixed the problems that caused it to be rejected in the first place

 

[neku99]

If the moderator rejected the previous version i do hope you fixed the problems that caused it to be rejected in the first place

Yeah I guess I did, cause everything I did in the first version was wrong haha. But I did make it MUI and added some other stuff in the test map.

 

[f0rsAk3n]

I just quickly went thru your code and here's a few things you can fix.

Don't use

This

• Do nothing

I mean, nothing is nothing right? just leave it blank

In this trigger you don't destroy the group. Add a custom script like this:

Trigger

• Target Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in TargetCasterGroup and do (Actions)
      • Loop - Actions
        • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((TargetCaster[(Custom value of (Picked unit))] is dead) Equal to (==) True) or ((TargetUnit[(Custom value of (Picked unit))] is dead) Equal to (==) True)
          • Then - Actions
            • Unit - Kill TargetDummy[(Custom value of (Picked unit))]
            • Custom script: call RemoveLocation(udg_TargetPoint[GetUnitUserData(GetEnumUnit())])
            • Custom script: call RemoveLocation(udg_TargetCasterPoint[GetUnitUserData(GetEnumUnit())])
            • Unit Group - Remove TargetCaster[(Custom value of (Picked unit))] from TargetCasterGroup
          • Else - Actions
            • Set TargetPoint[(Custom value of (Picked unit))] = (Position of TargetUnit[(Custom value of (Picked unit))])
            • Set TargetCasterPoint[(Custom value of (Picked unit))] = (Position of TargetCaster[(Custom value of (Picked unit))])
            • Unit - Move TargetDummy[(Custom value of (Picked unit))] instantly to TargetPoint[(Custom value of (Picked unit))]
    • Custom script: call DestroyGroup( udg_TargetCasterGroup )

Same deal here:

Trigger 2

• Flare Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in FlareCasterGroup and do (Actions)
      • Loop - Actions
        • Unit - Order TargetCaster[(Custom value of (Picked unit))] to Stop
        • Animation - Play TargetCaster[(Custom value of (Picked unit))]'s attack animation
        • Unit - Make TargetCaster[(Custom value of (Picked unit))] face TargetUnit[(Custom value of (Picked unit))] over 0.00 seconds
        • Special Effect - Create a special effect at TargetPoint[(Custom value of (Picked unit))] using Abilities\Spells\Other\Doom\DoomDeath.mdl
        • Set FlareDamager = TargetCaster[(Custom value of (Picked unit))]
        • Unit Group - Pick every unit in FlareGroup and do (Actions)
          • Loop - Actions
            • Unit - Cause FlareDamager to damage (Picked unit), dealing 50.00 damage of attack type Spells and damage type Normal
        • Unit Group - Remove TargetCaster[(Custom value of (Picked unit))] from FlareCasterGroup
        • Custom script: call DestroyGroup( udg_FlareGroup )
    • Custom script: call RemoveLocation(udg_TargetPoint[GetUnitUserData(GetEnumUnit())])
    • Custom script: call RemoveLocation(udg_TargetCasterPoint[GetUnitUserData(GetEnumUnit())])
    • Custom script: call DestroyGroup( udg_FlareCasterGroup )

 

[X-OMG-X]

Looks nice and i like the idea. The leaks should be fixed thought.

 

[neku99]

I just quickly went thru your code and here's a few things you can fix.

Don't use

This

• Do nothing

I mean, nothing is nothing right? just leave it blank

In this trigger you don't destroy the group. Add a custom script like this:

Trigger

• Target Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in TargetCasterGroup and do (Actions)
      • Loop - Actions
        • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((TargetCaster[(Custom value of (Picked unit))] is dead) Equal to (==) True) or ((TargetUnit[(Custom value of (Picked unit))] is dead) Equal to (==) True)
          • Then - Actions
            • Unit - Kill TargetDummy[(Custom value of (Picked unit))]
            • Custom script: call RemoveLocation(udg_TargetPoint[GetUnitUserData(GetEnumUnit())])
            • Custom script: call RemoveLocation(udg_TargetCasterPoint[GetUnitUserData(GetEnumUnit())])
            • Unit Group - Remove TargetCaster[(Custom value of (Picked unit))] from TargetCasterGroup
          • Else - Actions
            • Set TargetPoint[(Custom value of (Picked unit))] = (Position of TargetUnit[(Custom value of (Picked unit))])
            • Set TargetCasterPoint[(Custom value of (Picked unit))] = (Position of TargetCaster[(Custom value of (Picked unit))])
            • Unit - Move TargetDummy[(Custom value of (Picked unit))] instantly to TargetPoint[(Custom value of (Picked unit))]
    • Custom script: call DestroyGroup( udg_TargetCasterGroup )

Same deal here:

Trigger 2

• Flare Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in FlareCasterGroup and do (Actions)
      • Loop - Actions
        • Unit - Order TargetCaster[(Custom value of (Picked unit))] to Stop
        • Animation - Play TargetCaster[(Custom value of (Picked unit))]'s attack animation
        • Unit - Make TargetCaster[(Custom value of (Picked unit))] face TargetUnit[(Custom value of (Picked unit))] over 0.00 seconds
        • Special Effect - Create a special effect at TargetPoint[(Custom value of (Picked unit))] using Abilities\Spells\Other\Doom\DoomDeath.mdl
        • Set FlareDamager = TargetCaster[(Custom value of (Picked unit))]
        • Unit Group - Pick every unit in FlareGroup and do (Actions)
          • Loop - Actions
            • Unit - Cause FlareDamager to damage (Picked unit), dealing 50.00 damage of attack type Spells and damage type Normal
        • Unit Group - Remove TargetCaster[(Custom value of (Picked unit))] from FlareCasterGroup
        • Custom script: call DestroyGroup( udg_FlareGroup )
    • Custom script: call RemoveLocation(udg_TargetPoint[GetUnitUserData(GetEnumUnit())])
    • Custom script: call RemoveLocation(udg_TargetCasterPoint[GetUnitUserData(GetEnumUnit())])
    • Custom script: call DestroyGroup( udg_FlareCasterGroup )

Wow didn't see that in the Flare Loop. Thanks for clarifying ^^

As for the Target Loop, I was told adding/removing units from a unit group do not leak, so I didn't destroy the group.

EDIT:

Thanks X-OMG-X ^^ I'm having cool Ideas for this system

Ok fixed the group leak in Flare Loop

 

[neku99]

UPDATE: Found a bug that makes flare not activate or it only activates once. Fixing it.

EDIT: Known Bugs and memory leaks fixed

 

[ELxCaigi]

this is a great original system, it can be used for turn based combat systems great idea +rep

 

[Vengeancekael]

neku don't double post, use the

button.

 

[neku99]

this is a great original system, it can be used for turn based combat systems great idea +rep

hehe thanks.

neku don't double post, use the

button.

erm sorry . - . I'll remember that.