12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

11:34, 1st Jun 2011
Bribe:

This has enough leaks to sink the Titanic! Oh, wait.

Too simple

• Venom stomp Variables
• Events
• Map initialization
• Conditions
• Actions
• -------- The max range for cast the venom --------
• Set VS_Range[1] = 300.00
• Set VS_Range[2] = 350.00
• Set VS_Range[3] = 400.00
• Set VS_Range[4] = 450.00
• -------- The duration off the effect --------
• Set VS_EffectDuration[1] = 0.15
• Set VS_EffectDuration[2] = 0.30
• Set VS_EffectDuration[3] = 0.45
• Set VS_EffectDuration[4] = 0.60
• -------- Scale of the effect --------
• Set VS_EffectScale[1] = 100.00
• Set VS_EffectScale[2] = 200.00
• Set VS_EffectScale[3] = 300.00
• Set VS_EffectScale[4] = 400.00
• -------- Turn on/off the effect --------
• Set VS_EffectOnOff = True

Can be done inside the spell trigger.

You'd prefer to initialization all variables on each cast?

Its too simple, and leaks Unit Group.

Set VSRange 250 + 50 x level of....

Marcos DAB said:

Its too simple, and leaks Unit Group.

Click to expand...

It's not. He destroys it at the end.

Can be done inside the spell trigger.

Click to expand...

That's called configuration.



======================================================

Instead of making 'Venom Group' just use the normal 'pick every unit in range matching condition' and put

• Custom script: set bj_wantDestroyGroup = true

before the 'Unit Group' action.

'Position of VS_Caster' leaks, set it to a variable and destroy it when done via:

• Custom script: call RemoveLocation(udg_(YOURVARIABLE))

===================================================

• Set VS_Caster = No unit
  • Set VS_Dummy = No unit

is uneeded.

===================================================

The caster is not dealing the damage, the dummy units are. This can mess up systems - I suggest you change that.

===================================================

Instead of using arrays to make your spell level, create a formula like (250 + (50 x Level)) and it'll scale with the spell's level indefinitely.

• Set VS_Range[1] = 300.00
• Set VS_Range[2] = 350.00
• Set VS_Range[3] = 400.00
• Set VS_Range[4] = 450.00
• -------- The duration off the effect --------
• Set VS_EffectDuration[1] = 0.15
• Set VS_EffectDuration[2] = 0.30
• Set VS_EffectDuration[3] = 0.45
• Set VS_EffectDuration[4] = 0.60
• -------- Scale of the effect --------
• Set VS_EffectScale[1] = 100.00
• Set VS_EffectScale[2] = 200.00
• Set VS_EffectScale[3] = 300.00
• Set VS_EffectScale[4] = 400.00

These can all be done inside the spell trigger with a configurable formula.

• Set VS_Range = (250 + (50 x Level))
• Set VS_EffectDuration = (0.15 x Level)
• Set VS_EffectScale = (100 x Level)

• Unit - Create (Number of units in VS_Group) Venom stomp [Dummy] for (Owner of VS_Caster) at (Position of VS_Caster) facing (Angle from (Position of VS_Caster) to (Position of (Picked unit))) degrees
• //

Look at the part that says "create (number of units in VS_Group)" You are creating as many extra dummy units as there are in the group. Since you only add an expiration timer to one of them, you create a shit storm of extra units based on how many units are targetted. Here's an example, if you have 5 units that are targetted, five picked units times 5 created units equals 25 dummy units, but only 5 of those are destroyed. That means 20 extra units are floating around, taking up RAAM (basically the equation is x^2-x). Not only is this terrible, these extra units aren't even DOING anything. Only the last created unit performs any function.

Also, you have memory leaks in the form of points and groups, but I think archangel covered all of them.

EDIT: Change the group so it isn't in a variable, then use set bj_wantDestroyGroup = true right before the group to clear the leak. Also, you are just using position of the casting unit instead of assigning a variable to it. You need that variable for position so you can clear the memory leak. On an endnote, this spell seems like a bad rip-off of Venomancers ultimate from DotA