12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

02:03, 10th Jan 2015
IcemanBo:
http://www.hiveworkshop.com/forums/spells-569/turn-back-boats-v4-259744/#post2638274

In your Trigger Loop,

Your Unit Groups TBB_Group[TBB_Loop], you must put the Picked Unit in a variable

• Time - Every 0.02 seconds of game time

->>

• Time - Every 0.03 seconds of game time

This is recommended...

• Set TBB_Group[TBB_Loop] = (Units within TBB_detection[(Level of Turn Back the Boats for TBB_Caster[TBB_Loop])] of TBB_TempPoint[TBB_Loop] matching ((((Matching unit) belongs to an enemy of (Owner of TBB_Caster[TBB_Loop])) Equal to True) and ((((Matching unit) is alive) Equal to True)

Put this in ITE (If then Else), to easy to change the condition if need.

The ability and the dummy unit could be stored in a configuration variable.

This should be stored.

• (TBB_distance[TBB_Loop] + TBB_speed[(Level of Turn Back the Boats for TBB_Caster[TBB_Loop])])

The level above should always be stored when the spell is first cast. Otherwise when a unit casts a spell then upgrades it the spell will get the outcome of a higher spell level.

Anything you use twice or more should be stored in a variable. This is for speed and efficiency. Example: (Picked unit) / (Last created floating text)

• Set TBB_TempPoint[TBB_Loop] = (Position of TBB_Dummy[TBB_Loop])
• Set TBB_TempPoint[TBB_Loop] = (TBB_TempPoint[TBB_Loop] offset by TBB_speed[TBB_Level[TBB_Loop]] towards TBB_Angle[TBB_Loop] degrees)

Remove locations when you are done using them (before you set them to another value, to be more precise). In this case you need a second variable for the offset.

• Set TBB_Group[TBB_Loop] = (Units within TBB_detection[TBB_Level[TBB_Loop]] of TBB_TempPoint[TBB_Loop] matching ((((Matching unit) belongs to an enemy of (Owner of TBB_Caster[TBB_Loop])) Equal to True) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) is A Hero) Equ
• Set TBB_Group[TBB_Loop] = (Random TBB_refugees[TBB_Level[TBB_Loop]] units from TBB_Group[TBB_Loop])

Same thing here.

Gismo359 said:

• Set TBB_TempPoint[TBB_Loop] = (Position of TBB_Dummy[TBB_Loop])
• Set TBB_TempPoint[TBB_Loop] = (TBB_TempPoint[TBB_Loop] offset by TBB_speed[TBB_Level[TBB_Loop]] towards TBB_Angle[TBB_Loop] degrees)

Remove locations when you are done using them (before you set them to another value, to be more precise). In this case you need a second variable for the offset.

• Set TBB_Group[TBB_Loop] = (Units within TBB_detection[TBB_Level[TBB_Loop]] of TBB_TempPoint[TBB_Loop] matching ((((Matching unit) belongs to an enemy of (Owner of TBB_Caster[TBB_Loop])) Equal to True) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) is A Hero) Equ
• Set TBB_Group[TBB_Loop] = (Random TBB_refugees[TBB_Level[TBB_Loop]] units from TBB_Group[TBB_Loop])

Same thing here.

Click to expand...

I'm not sure what harm there is overwriting variables rather than using a new one. Is it more likely to bug?

EyeCandy said:

I'm not sure what harm there is overwriting variables rather than using a new one. Is it more likely to bug?

Click to expand...

Locations among other things leak. That means once you lose the reference to them they sit in memory for no reason. That is why you need to destroy the location.

Look at the tutorial Things that leaks. It is on the triggers and scripts main page.

All fixed.
Side-Note:
Looks like the mods won't be getting this approved anytime soon. There are some still pending from August.

This should be calculated and stored.

• (400.00 + (400.00 x (Real(TBB_Level[TBB_Loop]))))

Same with this.

• (Owner of TBB_Caster[TBB_Loop]))

Both of the above will easily be used twice or more in a spell instance.

This needs to be moved into the Then block of the ITE otherwise it leaks when the condition is false.

• Set TBB_TempPoint[TBB_Loop] = (Position of TBB_Dummy[TBB_Loop])

As said above anything used twice or more should be stored. This should be stored.

• (Last created floating text)

Switch these around to make it more efficient.

• Set TBB_CasterLoc = (Position of (Triggering unit))
  • Set TBB_TargetLoc = (Target point of ability being cast)
  • Set TBB_Index = (TBB_Index + 1)
  • Set TBB_Caster[TBB_Index] = (Triggering unit)

Like this.

• Set TBB_Caster[TBB_Index] = (Triggering unit)
• Set TBB_CasterLoc = (Position of TBB_Caster[TBB_Index])
• Set TBB_TargetLoc = (Target point of ability being cast)
• Set TBB_Index = (TBB_Index + 1)[//trigger]

Thanks for the optimising. Now I hope that was the last leak to close off.

- Don't use PauseUnit.
- The effect should be configurable.
- Trigger the AOE damage yourself, and make it configurable.
- You have potential group leaks.
- FloatingTexts are not needed. At least make them optional, and part of the config.
- Set periodic time to "0.03".
- Explain in SetUp that the speed is linked with your periodic event.
- Settint integer to "0" is not needed onDeindex.
- Setting booleans to "false" is not needed onDeindex.
- Your import instructions are lacking.
- Add some comments. At least for user.
- Tooltip is one big sentence. It can be improved. And somehow the "Turn Back to Boats" name is a strange spell name in my opinion.

Needs Fix