Swarm

Moderator · Mar 18, 2011

12:31, 8th Sep 2011
Vengeancekael:
Status: Rejected

Not a lot of terrain tile variation, add some undead titles and grass, etc.
A lot of memory leaks: Leaks tutorial
The terrain is also too plain, add more heights.

Private message me once you've done the things mentioned

Mumbis · Mar 18, 2011

I think you should set up a credit list here aswell..
Also, your triggers leak!

DW, i'll tell you how to fix it in a second...

EDIT:
Didn't leak as much as I thought, still, you've missed some parts ;O
example:

Civilian Movement Real
- Events
  - Time - Every 10.00 seconds of game time
- Conditions
- Actions
  - Set Civilians_Outside = (Units owned by Player 5 (Yellow) matching (((Unit-type of (Matching unit)) Equal to Civilian) or (((Unit-type of (Matching unit)) Equal to Civilian) or ((Unit-type of (Matching unit)) Equal to Female Civilian))))
  - Unit - Order Civilian 0052 <gen> to Move To (Center of BUILDING Barracks <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - Unit - Order Female Civilian 0051 <gen> to Move To (Center of BUILDING Garrison <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - Unit - Order Female Civilian 0054 <gen> to Move To (Center of BUILDING Refinery <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - Unit - Order Civilian 0053 <gen> to Move To (Center of BUILDING Iron Mine <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - Unit - Order Civilian 0055 <gen> to Move To (Center of BUILDING Power Generator <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - Unit - Order Female Civilian 0049 <gen> to Move To (Center of BUILDING Power Generator <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - Unit - Order Female Civilian 0050 <gen> to Move To (Center of BUILDING Steel Factory <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - Unit - Order Civilian 0048 <gen> to Move To (Center of BUILDING Barracks <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - Unit - Order Civilian 0047 <gen> to Move To (Center of BUILDING Garrison <gen>)
  - Unit - Turn collision for (Last created unit) Off
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Number of units in Civilians_Outside) Equal to 0
    - Then - Actions
      - Trigger - Turn off (This trigger)
    - Else - Actions
      - Do nothing
  - Custom script: call DestroyGroup (udg_Civilians_Outside)

As you may see, this trigger leaks everytime it's turned on!
Need to clear the points here aswell

Anyway, I see you know how to fix it, so no need for me to post a fix.
Seems pretty tight otherwise. I'll take a look at your "known Issues"

EDIT:
All I can see is that some abilities has a buff called "No Buff"? But this must be on intention right?

akrep_ve_su · Mar 18, 2011

Mumbis said:
I think you should set up a credit list here aswell..
Also, your triggers leak!
DW, i'll tell you how to fix it in a second...

EDIT:
Didn't leak as much as I thought, still, you've missed some parts ;O
example:

Civilian Movement Real

Events

Time - Every 10.00 seconds of game time

Conditions

Actions

Set Civilians_Outside = (Units owned by Player 5 (Yellow) matching (((Unit-type of (Matching unit)) Equal to Civilian) or (((Unit-type of (Matching unit)) Equal to Civilian) or ((Unit-type of (Matching unit)) Equal to Female Civilian))))

Unit - Order Civilian 0052 <gen> to Move To (Center of BUILDING Barracks <gen>)

Unit - Turn collision for (Last created unit) Off

Unit - Order Female Civilian 0051 <gen> to Move To (Center of BUILDING Garrison <gen>)

Unit - Turn collision for (Last created unit) Off

Unit - Order Female Civilian 0054 <gen> to Move To (Center of BUILDING Refinery <gen>)

Unit - Turn collision for (Last created unit) Off

Unit - Order Civilian 0053 <gen> to Move To (Center of BUILDING Iron Mine <gen>)

Unit - Turn collision for (Last created unit) Off

Unit - Order Civilian 0055 <gen> to Move To (Center of BUILDING Power Generator <gen>)

Unit - Turn collision for (Last created unit) Off

Unit - Order Female Civilian 0049 <gen> to Move To (Center of BUILDING Power Generator <gen>)

Unit - Turn collision for (Last created unit) Off

Unit - Order Female Civilian 0050 <gen> to Move To (Center of BUILDING Steel Factory <gen>)

Unit - Turn collision for (Last created unit) Off

Unit - Order Civilian 0048 <gen> to Move To (Center of BUILDING Barracks <gen>)

Unit - Turn collision for (Last created unit) Off

Unit - Order Civilian 0047 <gen> to Move To (Center of BUILDING Garrison <gen>)

Unit - Turn collision for (Last created unit) Off

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Number of units in Civilians_Outside) Equal to 0

Then - Actions

Trigger - Turn off (This trigger)

Else - Actions

Do nothing

Custom script: call DestroyGroup (udg_Civilians_Outside)

As you may see, this trigger leaks everytime it's turned on!
Need to clear the points here aswell

Anyway, I see you know how to fix it, so no need for me to post a fix.
Seems pretty tight otherwise. I'll take a look at your "known Issues"

EDIT:
All I can see is that some abilities has a buff called "No Buff"? But this must be on intention right?

Wow, that was quick response! =) Thank you. No Buff is to prevent "tooltip missing" error, although it is being one the major problems in the map is an ironic one =) I'll fix those location leaks, must've forgotten them =)

Mumbis · Mar 18, 2011

@akrep_ve_su
Yeah, I got nothing to do, so i'm rollin thru all pendin maps

Also, I think the problem is your "No Buff" buff.
Since if a buff is blank with text/icons, it will display anyway, displaying "tooltip missing" and if there's no icon, it will show a green one

So change them and make em fit somehow and you "Buff" problem is gone!

akrep_ve_su · Mar 18, 2011

Well actually, "No Buff" thing was the solution we thought of a while ago =) It worked pretty good until this map =)

Mumbis · Mar 18, 2011

Ah, well, then I dunno xD

Landmine · Mar 18, 2011

Forgot to mention in my other post that you should add item stacking (for most items, I don't think ammo stacking is necessary).
Could be like:

Event
- Unit - Unit Acquires item
Conditions
- [Item type of [Item being manipulated]] is equal to X
- Or (any of the conditions)
  - Loop- Actions
    - [Hero manipulating item] has item-type X in slot 1
    - *Repeat above as much as necessary*
Actions
- Item - Set charges of X to [[item being manipulated] + charge of X]
- Item - Remove [item being manipulated]

That's off my head, but the simple way of doing it is this (for as long as I've used it). There are more complicated ways of doing it (the link provided allows you to pick up stack-able items even if you have a full inventory).
Just a suggestion, as its really annoying to do if you want to build a barricade and you only have 2 available slots.

Other than that, I have nothing else to report (yet).

Mumbis · Mar 18, 2011

Yeah, an item combination thing is always usefull

EDIT:
OH, btw forgot,
akrep_ve_su, you should also remove every action called "Do Nothing".
Seen moderators partly complain on having those sometimes, since the action is useless and just uses some extra space...

/Mumbis

akrep_ve_su · Mar 18, 2011

I know; but I can't remove them from those if/then/else without the multiple actions thing. Btw I won't be implementing item stack as I told Landmine that I would. Everytime I open the map, another bug occur (even at things that I don't tinker with) Last time, imported sound files didn't play; game played the original files instead for some of the sounds. This time i opened the editor for adding an item stack trigger, now "Auto-Reload" ability crashes the game. The tooltip missing bug occured the same way -probably-; as tons of other stuff did. Seriously, I am done editing. This is probably the all the map will ever be.

Mumbis · Mar 18, 2011

@akrep_ve_su
Ofc you can remove them from those if then else actions, I do it all the time and my triggers works perfectly

(edit: wut! my nr 200 post!)

Swarm

Swarm (Map)

Moderator

Moderator

Mumbis

Mumbis

Resources

akrep_ve_su

akrep_ve_su

Resources

Mumbis

Mumbis

Resources

akrep_ve_su

akrep_ve_su

Resources

Mumbis

Mumbis

Resources

Landmine

Landmine

Resources

Mumbis

Mumbis

Resources

akrep_ve_su

akrep_ve_su

Resources

Mumbis

Mumbis

Resources

Similar threads