Phantasm

doomhammer99 · Nov 2, 2018

~Reserved

EDIT: Please leave a comment and a rating if you're satisfied

Ofel · Nov 3, 2018

I think some more screenshot would be good.

Daffa · Nov 3, 2018

Why do you add Phantasm Illusion event on-cast?

doomhammer99 · Nov 4, 2018

@Ofel: Copy that

Daffa the Mage said:
Why do you add Phantasm Illusion event on-cast?

I'll move it

Ofel · Nov 4, 2018

Though the idea is simple, but I like it.

Another suggestion from me is that you should use Linked List.

You can search for "Linked List" here. Or I thought you understand JASS syntax, you can see my spell for how to apply this indexing system.

JC Helas · Nov 11, 2018

doomhammer99 said:
@Ofel: Copy that

I'll move it

Unit - Move P__Illusion[P_TempInt] instantly to (Point(P__X[P_TempInt], P__Y[P_TempInt])), facing (Point(P__TargetX[P_TempInt], P__TargetY[P_TempInt]))
Doing this takes ''(Point(P__X[P_TempInt], P__Y[P_TempInt])" inside of a calls? I think you will make a point that cannot be removed.

Do this way instead:

Custom script: call SetUnitX(udg_P__Dummy, udg_P__X[udg_P_TempInt])

Custom script: call SetUnitY(udg_P__Dummy, udg_P__Y[udg_P_TempInt])

Custom script: set udg_P__Illusion[udg_P_TempInt] = GetSummonedUnit()
what is the purpose of scriping this one?

Trigger - Add to Phantasm_Illusion <gen> the event (A unit Spawns a summoned unit)
I think putting this on a cast trigger without condition that has a reason to create it once, you just spam creating that event into your trigger
this will happen

Events
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Unit - A unit Spawns a summoned unit
Conditions
Actions

I suggest to put it right through

doomhammer99 · Nov 11, 2018

JC Helas said:
Unit - Move P__Illusion[P_TempInt] instantly to (Point(P__X[P_TempInt], P__Y[P_TempInt])), facing (Point(P__TargetX[P_TempInt], P__TargetY[P_TempInt]))
Doing this takes ''(Point(P__X[P_TempInt], P__Y[P_TempInt])" inside of a calls? I think you will make a point that cannot be removed.

I think there's no problem with that since I am not storing any variable every call.

JC Helas said:
Custom script: set udg_P__Illusion[udg_P_TempInt] = GetSummonedUnit()
what is the purpose of scriping this one?

The point of this one, Is storing the last summoned unit or illusion into a variable.

JC Helas said:
Trigger - Add to Phantasm_Illusion <gen> the event (A unit Spawns a summoned unit)
I think putting this on a cast trigger without condition that has a reason to create it once, you just spam creating that event into your trigger
this will happen

forgot to upload the updated version, thanks to you

Thank you for your comment, please leave a rating if you find this resource useful.

Pyrogasm · Nov 13, 2018

doomhammer99 said:
I think there's no problem with that since I am not storing any variable every call.

Wrong; you in fact leak two points every time that line is run. Using Point(someX, someY) creates a point (location) object whether you store it or not. If you did it by SetUnitX/Y as @JC Helas suggested, then you would be using the X/Y coordinates directly and wouldn't be 'making' a point, thus no leak. The other advantage of SetUnitX/Y is that they don't take unit model collision or ground pathing into account when placing the unit precisely there.

doomhammer99 said:
The point of this one, Is storing the last summoned unit or illusion into a variable.

No, JC means why write that line as a custom script line instead of a normal GUI set variable line?

doomhammer99 · Nov 13, 2018

Pyrogasm said:
Wrong; you in fact leak two points every time that line is run. Using Point(someX, someY) creates a point (location) object whether you store it or not. If you did it by SetUnitX/Y as @JC Helas suggested, then you would be using the X/Y coordinates directly and wouldn't be 'making' a point, thus no leak. The other advantage of SetUnitX/Y is that they don't take unit model collision or ground pathing into account when placing the unit precisely there.

Already updated, thanks tho

MyPad · Jan 22, 2019

Spell Review:

Notes:

There is a certain variable that would be better off being declared as another GUI type, since one can't guarantee that the imported spell has the same rawcode. udg__P_Dummy_Ability
In trigger Phantasm Loop, there is a For Group subroutine that also utilizes the FirstOfGroup native instead of the GUI provided (Picked unit). Is this intended or a functional error?
In the filters within the For Group subroutine (mentioned above), the conditions behave in an odd manner, such that the filtering system only compares the unit state of a target unit to the flag, and not act as a switch, whereby the aforementioned comparison will only be made if the filter flag is false. [1]

Overview:

The spell functions properly, and does not have leaks, as of the most recent version. There might be a few logical flaws, but these are not of great bearing that they bring the spell to Awaiting Update. As referenced in index [1]:

The filters are like this
unit.getState(unitstate) == filterFlag

and not like this
filterFlag or (not filterFlag and (unit.getState(unitstate) == false))

Status:

Approved

Oljin · Apr 13, 2019

the spell is quite nice! i use it in my map.
I like that the it does AoE damage and then stays for a while

But the first cast always lags, is it possible to preload somehow the models such that the first one does not lag?

Pyrogasm · Apr 13, 2019

Oljin said:
But the first cast always lags, is it possible to preload somehow the models such that the first one does not lag?

Have a dummy unit cast the spell in an unoccupied corner of the map on map init.

Phantasm

Just another Warcraft III map (Map)

Spell Review:

Notes:

Overview:

Status:

Similar threads