Approved
Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
22:41, 18th Jul 2012
Magtheridon96:
This is in need of a lot of work.
Maybe this will help.
IcemanBo: Too long as NeedsFix. Rejected.
22:41, 18th Jul 2012
Magtheridon96:
- You're leaking the fog modifiers. They should be stored upon creation and then destroyed when you don't need them anymore.
- The "Wait" inside the ViewFeatTree trigger should be removed. If you need a delay, you need to use a different method for it.
- You're leaking a fog modifier in the trigger that disables vision over the area. This is bad. You should be using only one array of fog modifiers, meaning one for each player, and you should only enable these fog modifiers and disable them. Don't create/destroy lots of them.
- This is totally not MUI/MPI as you're using variables in inappropriate places where you can't guarantee the fact that they have a certain value. In order to rid this resource of problems, you need to read a couple of tutorials about making systems/spells MUI/MPI, using periodic triggers, using arrays, hashtables, and a lot of other things.
- It would've been quite better if the Primary/Secondary/etc... triggers were split into many different triggers. Usually, one trigger per spell is best because it's easier for you to go through them.
This is in need of a lot of work.
Maybe this will help.
