Come to hell V1.0

Moderator · May 9, 2011

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

10:48, 9th May 2011
Bribe:

Six location leaks per cast because of the loop:

Special Effect - Create a special effect at ((Position of A_Caster[A_Index[1]]) offset by A_MaxRange[A_Index[1]] towards ((Real((Integer A))) x 60.00) degrees)

And additional location leak and also a region leak:

Set A_Region[A_Index[1]] = (Region centered at (Position of A_Caster[A_Index[1]]) with size (30.00 30.00))

Because you never remove the region later on.

The periodic trigger leaks plenty. You need a bj_wantDestroyGroup = true line before this:

Unit Group - Pick every unit in (Units within A_MaxRange[A_Index[2]] of (Position of A_Caster[A_Index[2]])) and do (Actions)

Two location leaks here:

(Distance between (Position of A_Caster[A_Index[2]]) and (Position of (Picked unit))) Greater than A_MinRange[A_Index[2]]

Two location leaks here:

Special Effect - Create a special effect at (Position of (Picked unit)) using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of (Picked unit)) using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl
Special Effect - Destroy (Last created special effect)

You don't need "And" here as all conditions are already checked before proceeding by default.

And - All (Conditions) are true
- ((Picked unit) is A structure) Equal to false
- ((Picked unit) is alive) Equal to true
- ((Picked unit) belongs to an enemy of (Owner of A_Caster[A_Index[2]])) Equal to true
- ((Picked unit) is in A_Group[A_Index[2]]) Equal to false

Archangel678 · May 9, 2011

Special Effect - Create a special effect at (Position of A_Caster [A_Index [2]]) using Abilities \ Spells \ Human \ Flamestrike \ FlameStrike1.mdl
Wait 1.50 seconds
Special Effect - Destroy (Last created special effect)

Waits

Either use a local, integer array, or hashtable to fix that...

You leak points... (Position of Unit) leaks...
Set them to variables, and destroy them...

Set POINTA = Position of Unit
--------------------------------------
Custom script: call DestroyLocation(udg_POINTA)

Unit groups leak, use

Custom script: set bj_wantDestroyGroup = true

That before the unit group to remove the leak...

I don't see you turning of "Come to hell effects" trigger when the spell is done, and you could merge it with the normal loop...

Make these constants a variable in map initialization, as it makes the spell more configurable... (Eg 4 + 2 x DAMAGE) -> (Variable + Variable2 x DAMAGE)

Set A_Damage [A_Index [1]] = (75.00 + (125.00 x (Real ((Level of Come to hell for A_Caster [A_Index [1 ]])))))
Set A_Duration [A_Index [1]] = 10.00
Set A_Time [A_Index [1]] = 0.00
Set A_Velocity [A_Index [1]] = (2.00 x (Real ((Level of Come to hell for A_Caster [A_Index [1 ]]))))
Set A_MaxRange [A_Index [1]] = (125.00 + (125.00 x (Real ((Level of Come to hell for A_Caster [A_Index [1 ]])))))
Set A_MinRange [A_Index [1]] = 100.00
Set A_Group [A_Index [1]] = (random 0 units from (Units in (Playable map area)))
Set A_Region [A_Index [1]] = (Region centered at (Position of A_Caster [A_Index [1]]) with size (30.00, 30.00))

Don't use

For each (Integer A) from 1 to 6, do (Actions)

Use:

For each (YOUR VARIABLE) from 1 to 6, do (Actions)

Its uses fewer function calls...

What correlation does

nice, best, greater, than, better

Have with this spell?

Also, I have no idea if you indexing system is working... try the spell on like 6 units at random times... and see if it works...

~~It seems to work~~
Effect works, SFX don't.

HStyleV · May 9, 2011

Normal loop is every 0.03 seconds, and a special effect every 0.03 seconds is so much, thats generate laggy. :S

I use wait for destroy the special effect, because the effect is long, and if I don't use wait the effect don't exist! :O, sorry for my fucking english, I'm argentinian(Messi) Languaje: Spanish :S

I don't use set bj_wantDestroyGroup

I think
Pick every units in (UnitGroup)
Remove (Picked units) from (UnitGroup)

is better than script.

Archangel678 · May 9, 2011

Normal loop is every 0.03 seconds, and a special effect every 0.03 seconds is so much, thats generate laggy. :S

You... use an integer count... every (.03) seconds you increase it to one... until its greater than 33. Then you reset it to 0, and create the SFX effects... Alas, the loops are merged...

I use wait for destroy the special effect, because the effect is long, and if I don't use wait the effect don't exist! :O, sorry for my ~~fucking english,~~ I'm argentinian(Messi) Languaje: Spanish :S
Pretty sure it works fine without the wait, if it doesn't, use a:
-Hashtable
-Local
-Integer Array
to fix the problem... waits... will screw up unless you're using locals...

Also, your English is considerably good.

I don't use set bj_wantDestroyGroup

I think
Pick every units in (UnitGroup)
Remove (Picked units) from (UnitGroup)
is better than script.
Sure, you remove the units, but you don't remove the unit group that was created... variable set unit groups you don't have to destroy, but:

Unit Group - Pick every unit in (UnitGroup) and do...

That leaks.

Custom script: set bj_wantDestroyGroup = true

That removes the leak, if you set it before the (UnitGroup) action...

It goes in the order of worst to best:
GUI < Custom Script < Jass < vJass < Narwhals

Red = My comments.

Also, I'd suggest fixing your other spells first, or deleting them if they are deemed unfixable, before uploading more spells.

Responding = Win
Not responding = Frowny Face

Adiktuz · May 9, 2011

take a look at this:

Set A_Index [0] = 0
Set A_Index [1] = 0
Set A_Boolean [A_Index [1]] = False
If (All Conditions Are True) then do (Then Actions) else do (Else Actions)
- If: Conditions
  - A_Index [0] Equal to 0
- Then: Actions
  - Trigger - Turn on Come to hell Loop <gen>
  - Trigger - Turn on <gen> Effects Come to hell
- Other: Actions

you set A_Index[0] to 0, and still check if that value is zero... what the?

and from this, I could say that this isn't MUI... coz after that line you set those vars into their value + 1, so that would be 1, which is the index that you use to save the objects, and for each cast, the index used is always 1...

Archangel678 · May 9, 2011

No, the spell is not MUI... the 'pull' seems to be MUI, but the SFX effects lack being MUI.

The spell... its an AoE hook that's more of an effect then a hook.

To clarify, all you're doing is pulling units towards the caster and inflicting damage at the center, while making warstomp effects at every 45 degrees, and a flamestrike at the center, creating a 'portal'.

Its not MUI because the warstomp effects don't work when cast multiple times... everything else works...

This could be simplified, by creating a dummy unit to cast flamestrike with 0 damage, and it'll even have a birth animation....

Here's my rating...

-Below average triggering = 0
-Not MUI = 0
-Decent visuals = +1
-Decent effect = +1
-Not really unique but somewhat useful idea* = +1

Verdict: 3/5.

Fixing = Increase in rating.

*Dante's Inferno, (Most) Mythologies, and (Most) Religions use the same idea...

Adiktuz · May 9, 2011

Archangel678 said:
No, its not MUI

exactly what I said...xx

Archangel678 · May 9, 2011

Constantly updating messages = win

Adiktuz · May 9, 2011

Archangel678 said:
Constantly updating messages = win

I updated it before you posted... ^_^

and I never said that it was MUI...

Archangel678 · May 9, 2011

and I never said that it was MUI...

Nope, I did

Its 50% MUI.

The 'pull' effect is MUI. The SFX is not. -> more for the spell maker to see, and what to fix.

Adiktuz · May 9, 2011

there's no such things as %MUI... and what do you mean by the pull effect being MUI? is that because it can pull a lot of units? that part should be a given... there's no point in saying that it is MUI for that...

and it still only works for 1 caster... because A_Index[1] will always be 1 when the triggers are running...

Archangel678 · May 10, 2011

The pull effects work, or seems to... the SFX part does not. That's because the wait action fails... or maybe I'm blind.

50% MUI = Half MUI... main part works, extra bs doesn't.

Adiktuz · May 10, 2011

have you tried it with two casters? coz it doesn't work for me when using at least two casters because of the index problem (only the latest caster will work...)

Come to hell V1.0

Come to hell (Map)

Moderator

Moderator

Similar threads