Combo - Complete

Moderator · Feb 12, 2011

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

Bribe:

Set leak = ((Position of (Picked unit)) offset by KBDistance towards KBAngle degrees)

Not witholding any irony, this leaks.

Instead of "Elapsed game time is 0.00 seconds" use "Map Initialization" as it doesn't consume as much RAM or map file size.

"Selects a unit" is not a very good event to have in a practical-application, public spell.

This is only MPI, but a spell needs to be MUI in order to be approved.

Efficiency needs a bit of work. (Key (Picked unit)) should be stored into a variable before repeat-referencing, so should (Key (Casting unit)) and (Casting unit) should be (Triggering unit).

Marsal · Feb 12, 2011

poooost da triggeerrrz

RaijinSpark · Feb 12, 2011

I don't know what this thing can do -.- and the post above..

Marsal · Feb 12, 2011

as I see on the pic, you pause units also you said it's just MPI then it won't be approved

Marsal · Feb 12, 2011

WarManta said:
RaijinSpark that is why you download and test...

Marsal2000 pausing is required for what it does and what do you mean it won't be approved since it can't be MUI? Did you even test?

There is no way for it to be MUI...

I also do not know how to post the triggers.

trigger->copy as text-> paste between these=>

JASS:

[TRIGGER][/TRIGGER]

I am not sure if it could be MUI.

pausing is required

why? it's never required

do you mean it won't be approved since it can't be MUI?

yes... read the rules dude

Marsal · Feb 12, 2011

1: post these fking triggers
2: IF IT'S NOT MUI IT WON'T BE APPROVED
3: not MUI + pauses units = why the hell should I test it? IT'S FKING WRONG
4: a proper description is required

D4RK_G4ND4LF · Feb 12, 2011

you can make it mui
just replace this weird selection event with "unit starts effect of ability" and add an ability to your hero
did you test this with shared units in multiplayer?
I think some weird things might happen (which could be solved with an ability instead of selection)

spell does not work for player 10, 11 and 12 by the way
you can create events more easily with:
for each integer i from 1 to 12
add to <trigger> the event: player(i) select a unit

better turn the triggers of instead of using conditions (so the trigger does not have to run at all if the spell is not cast)

use a real variable to store the time instead of an integer so you can run the loop trigger more often than once per second (at worst the casting time will be 1 second shorter)

you are using many unnecessary variables where you could have used the hastable values directly

don't run the knockback trigger 100 times per second
every 0.03 sec will look smooth enough

using units to create special effets is a huge waste of performance
either recycle the units or create special effects directly

you really should not use "pause unit" because it will overwrite other "pause unit" effects
either make a custom system to handle the pause state properly or stop the unit every 0.0x seconds or disable attack damage and movement

also I would recommend a better spell desciption so you know that you have to select your hero again and again in order to make the spell work

and I got 748 hits
it is very easy to abuse this spell with clickspamming tools
if you were using a spell to fire this instead you would have casting delay and therefore an inbuilt protection against that

nice idea and not too bad coding
but keep on improving it

Marsal · Feb 12, 2011

you must be somewhere between slow and stupid...
"IF IT'S NOT MUI IT WON'T BE APPROVED" the rule says upload spells that are MUI

Marsal · Feb 12, 2011

these are systems and not spells dumb...

x3GlikE · Feb 12, 2011

Firstly post the triggers or screenshot them so we can help you..

RaijinSpark · Feb 12, 2011

Post above, and stop being a smartass.

Besides, your the spell maker why don't you even know if it's MUI or not.. -.-

D4RK_G4ND4LF · Feb 12, 2011

WarManta said:
I made it F1 key for a reason because I wanted it to be that as well making it MPI only...

why don't you want to make it better if you can?

WarManta said:
Just tested with shared units and there is no problem because I use the correct event to fix this... no need for a ability..
The units seem to be fine and don't get perma paused as well after 10 seconds they unpause as well so it seems fine.

just that you can't press F1 to select your mate's hero so you have to click manually
cmon...just use a spell event
also you can't always simulate the behavior online with shared units

WarManta said:
What do you mean you got 748 hits? Could you show me a replay or a screenshot of this and what clickspamming tool?

these few lines of c code are enough to screw it (compiled with wxDev-C++)

Code:

#include <windows.h>

int main(){
    while(1){
        if (GetAsyncKeyState(VK_TAB)){
            keybd_event(VK_F1, 0, 0L, 0L);
            keybd_event(VK_F1, 0, KEYEVENTF_KEYUP, 0L);
        }
        Sleep(1);
    }
    return 0;
}

every time you create a unit you will leak a little memory and it is not possible to clean this leak (but "Remove unit" is way better than "Kill unit" or using an expiration timer which kills the unit after some time)
special effects have a similar problem so the best way is to create a unit which has a certain effect as a model, play it's death animation (or any animation you like) and hide it after a desired duration next time you don't have to create a new unit but you can use the old one, unhide it and play its animation instead of leaking again

I've attached the executable and the code so you can try yourself

Catch_ya · Feb 12, 2011

WarManta said:
I made it F1 key for a reason because I wanted it to be that as well making it MPI only...

Why the hell don't you want it to be MUI? MUI automaticaly makes it MPI. So I don't see a reason not to make it MUI, is it because you lack the skills to make it MUI?

Marsal · Feb 12, 2011

WarManta said:
Why do the idiots always post.....

Ohhh... the irony...

Vlad727 · Feb 12, 2011

WarManta,
at the hive we try to help the other warcrafters to improve their work that's all.
so no offence but just stop being a "smart-ass" and accept that people like D4RK_G4ND4LF
try to help you by providing feedback.
Also if you would just post your triggers, then other people can check your work and look for leaks and mistakes, just to help you improve your work.
People do not always have the time (or the space) to download, that's why we've got the preference of posting triggers.

This is just to help :wink:

Vlad727

Cihparg · Feb 12, 2011

You must be the stupidest person of all in the Spell Section.
Everything can be made MUI.

wiki.thehelper.net said:
MUI stands for Multi-Unit Instance-ability, that is, whether or not code can be run with multiple units at the same time without bugging. Contrary to popular belief, there isn't really any specific way of defining a code as 'MUI'. Instead, code is deemed not-MUI when it bugs with multiple instances of the code running, usually caused from variables being overwritten. When it is said that a script or trigger is MUI, it means that multiple instances can be running at a time with no bugs. Any code that is executed instantly is automatically MUI.

I'll help you out here, actually, I could even redo this rejected spell in MUI.

~ Here is a examble of how this system would be done MUI with ease and in your method;
Player selects a unit.
Unit is in a group, do actions. ( Can be done of hashes or indexing )

GIANT_CRAB · Feb 13, 2011

Just post the triggers, it's really simple and easy.

Edit: WarManta, take advice from other people, nobody is perfect, and there is always somebody better than you.

To the others, stop being so not nice, use a nicer tone.
Having so much caps won't help, you need patience, quit raging.

WarManta · Feb 14, 2011

There is no further reason for hostility because I now know the true nature of the community here and it is just useless to attempt anything here...

Marsal · Feb 14, 2011

If you really think this you should open your eyes... Just take a look at my first and second post, is there any offense? No... The third had a very minimal because you were very irritating...
You should think it through...

Marsal · Feb 14, 2011

Ah I give up... You're just one of the asses who can't be helped... Enjoy your faggotry! I'm out!

WarManta · Feb 15, 2011

Where is a giant mirror when you need one...

Catch_ya · Feb 15, 2011

WarManta said:
There is no further reason for hostility because I now know the true nature of the community here and it is just useless to attempt anything here...

Then why not do us a favor and leave?

GIANT_CRAB · Feb 16, 2011

Catch_ya said:
Then why not do us a favor and leave?

Hey, don't be mean unless you wanna be neg-repped

.VTZ. · May 14, 2011

lol this spell is from wc3unlimited created by unknow

Marc Mamales · May 14, 2011

.VTZ. said:
lol this spell is from wc3unlimited created by unknow

yeah

it was made by banditger.
Banditger's system at wc3unlimited

Combo - Complete

Combo (Map)

Moderator

Moderator

Attachments

Similar threads