v1.2f Timed Bomb

Moderator · Feb 20, 2011

Reviewed by Maker, Timed Bomb v1.2f, 17th Feb 2012

Approved.

The floating text can be seen even for players that have the area masked.
Maybe there could be some sort of indication that a unit has a timed bomb attached to it.

Suggested changes

Improve the tooltip

Do "KeyTB2 Equal to 0" comparison only when you subtract from KeyTB2

Maker · Feb 20, 2011

It is MUI and there seems to be no leaks.

Use the location:

Unit - Order (Picked unit) to Patrol To (Center of Region 001 <gen>)

Create a separate trigger for this or remove it, it does not belong to the spell:

Selection - Select The Joker 0001 <gen> for Player 1 (Red)

Same goes for the patrolling thing, do them in some other trigger, that does not belong to the spell.
You set the triggering unit into a variable in BT cast, but then after that you use a function to get the triggering unit. Use the variable.
Set the level of ability into a variable and use the variable.
You could store the target unit's handle id into a variable and use the variable to store the data.
This check

(Number of units in GroupBT) Greater than 0

should be after

Unit Group - Remove (Picked unit) from GroupBT

You only need to have this once

Custom script: call RemoveLocation(udg_TargetLoc)

Not in both THEN and ELSE. Move it to be the last action inside the unit group loop.
Forgot to use a variable for the hash:

Hashtable - Save (Duration - 1.00) as (Key Duration) of (Key (Picked unit)) in (Last created hashtable)

Why is succes chance a real?
You could store the handle id of picked unit into a variable and use that instead of constantly using a function to get it.
Make the tooltip text (normal and extended) more like in Blizzard's abilities.

defskull · Feb 20, 2011

Thanks for comment !
Will change them

baassee · Feb 20, 2011

This is neat I must say yet there are a few flaws.

Serperate the map's init trigger with the triggers' init trigger. The selecting, the moving dummies, the point, move all that into another trigger and create the hash at map init.

Gosh I hate hashtables so this is how it goes. This spell cannot stack onto the same unit twice or more as the parent key "of target unit" will be overwritten and due to that, the previous instance will be lost.

You can always check if the loop is already on as you did in the loop when you checked the amount of units.

This only supports integers, not real values to the duration. Why not make it even better and support values above 0.03?

The pickedloc is not necessary. Just create the special effect attached to the picked units' origin.

Else you got my approval.

defskull · Feb 20, 2011

Maker said:
It is MUI and there seems to be no leaks.

Use the location:

Unit - Order (Picked unit) to Patrol To (Center of Region 001 <gen>)

Create a separate trigger for this or remove it, it does not belong to the spell:

Selection - Select The Joker 0001 <gen> for Player 1 (Red)

Same goes for the patrolling thing, do them in some other trigger, that does not belong to the spell.
You set the triggering unit into a variable in BT cast, but then after that you use a function to get the triggering unit. Use the variable.
Set the level of ability into a variable and use the variable.
You could store the target unit's handle id into a variable and use the variable to store the data.
This check

(Number of units in GroupBT) Greater than 0

should be after

Unit Group - Remove (Picked unit) from GroupBT

You only need to have this once

Custom script: call RemoveLocation(udg_TargetLoc)

Not in both THEN and ELSE. Move it to be the last action inside the unit group loop.
Forgot to use a variable for the hash:

Hashtable - Save (Duration - 1.00) as (Key Duration) of (Key (Picked unit)) in (Last created hashtable)

Why is succes chance a real?
You could store the handle id of picked unit into a variable and use that instead of constantly using a function to get it.
Make the tooltip text (normal and extended) more like in Blizzard's abilities.

baassee said:
This is neat I must say yet there are a few flaws.

Serperate the map's init trigger with the triggers' init trigger. The selecting, the moving dummies, the point, move all that into another trigger and create the hash at map init.

Gosh I hate hashtables so this is how it goes. This spell cannot stack onto the same unit twice or more as the parent key "of target unit" will be overwritten and due to that, the previous instance will be lost.

You can always check if the loop is already on as you did in the loop when you checked the amount of units.

This only supports integers, not real values to the duration. Why not make it even better and support values above 0.03?

The pickedloc is not necessary. Just create the special effect attached to the picked units' origin.

Else you got my approval.

This check

(Number of units in GroupBT) Greater than 0

should be after

Unit Group - Remove (Picked unit) from GroupBT

How do I actually do this ?
Re-trigger the conditions back at the starting point ?
Because that unit group action is in the Else function

Gosh I hate hashtables so this is how it goes. This spell cannot stack onto the same unit twice or more as the parent key "of target unit" will be overwritten and due to that, the previous instance will be lost.

What does this means ?
Unstackable, as... ?

Further changelogs will be made, time to hit the hay

baassee · Feb 20, 2011

You just put an if after that action to see if there are any units left and if so, you turn the trigger off.

Try to cast 2 or more spells on the same target with multiple units. There will be only one boom.

defskull · Feb 20, 2011

Same target unit, 2 different casting unit owned by different player, eh ?
Btw, do Indexing allows it to stack instead of hashtable ?

baassee · Feb 20, 2011

For MUI it doesnt matter which player it is, it should work for every player and for a certain amount of units. Indexing allows stack yes. Yet it has a limit of instances, the maximum array size 2^13 but as you don't count in 0 it will just be 2^13 - 1

Maker · Feb 20, 2011

You could make it stackable with hashtables also. Just don't overwrite the key or flush the child hashtable if another instance is still going on.

You could update a stack count value for each unit and then use keys tied to the stack count. Concatenate the keys like:

count = LoadInteger( hash , id , StringHash("count"))
SaveReal( hash , id , StringHash("duration" + I2S(count)) , duration )
SaveInteger( hash , id , StringHash("count") , count + 1 )

This way keys for the first instance will be xxx0, for second instance xxx1 and so on. In the unit group loop, loop from 0 to count for each unit.

Though indexing is a viable alternative.

baassee · Feb 20, 2011

Hanky made a nice template for dynamic indexing with hashtables. Look it up in the spells section.

Magtheridon96 · Feb 20, 2011

nice spell

i found no problems with your code, good job

5/5

defskull · Feb 21, 2011

And if you guys can, please rate

Yeah, I watched Hanky's tutorial, very, very useful for new learner

mckill2009 · Feb 21, 2011

great now you're doin it bro!...

but some things I noticed...you cant cast this spell on the same target coz it will bug...I mean you can but it will bug...

solution;
1. Make a dummy unit and store everthing to it then do this...

Unit Group - Add (Last created unit) to GroupBT

2. Make a condition if value of hashtable exist, like this...then put the actions in the 'ELSE' part...

((Key Duration) is stored as a Real of (Key (Target unit of ability being cast)) in HashBT) Equal to True

other than that, good job 5/5

baassee · Feb 21, 2011

I don't know what to rate as I said, this is kind of bugged for the people who didn't notice this.

defskull · Feb 22, 2011

Maybe it bugs, only because of hashtable usage ?
Nevertheless, Maker's way seems far too advance for me >.<
I suppose Indexing can make things better, eh...
Thanks for the feedbacks !

mckill2009 · Feb 22, 2011

Hashtable is easier than indexing, an expert said that indexing can sometimes a bit messy, also if you dont recycle well, then it will bug if index is +8000...hashtable is unlimited and if used properly, then there's no problem...

baassee · Feb 22, 2011

Proper indexing isn't hard at all to learn, just view Hanky's Dynamic Indexing Template in the spell section. Hashtables are useful when the parent key cannot be overwritten, in this case it can and therefore it may have unlimited instances yet it bugs which indexing wouldn't do.

And don't tell me indexing is those noobs we have in the spell section just having an integer variable setting + 1 every single cast, that sure is rubbish and I'm going so much OT right now but if you want a great spell, watch D4RK_G4ND4LF's spells. He got a proper indexing technique with a great recycling, not the most common one but hey, he's one of the best I've seen so far even if he doesn't code vJASS. He is like Paladon was and said once: "What you can make in vJASS, I can make in GUI."

mckill2009 · Feb 22, 2011

off topic (last one)

pardon me, but I didnt say that indexing is hard to learn, I said HT is easier...but well
it depends on what people preffer...I sometimes use indexing for spells but since I learned HT, so I preffered to use it...
Next Im gonna learn JASS & try to think GUI less...

Garfield1337 · Mar 3, 2011

Well,baassee...you said the term SUMI is useless while this spell is MUI,but not SUMI.

baassee · Mar 3, 2011

I say that all my spells are MUI, they can be casted multiple times by the same caster.

mckill2009 · Mar 4, 2011

Unless someone gives a SUMI spell...I dont believe that it exist

...

Garfield1337 · Mar 4, 2011

mckill2009 said:
Unless someone gives a SUMI spell...I dont believe that it exist ...

Many of spells in spell section are SUMI; my spells are; Baassee's too.

baassee · Mar 4, 2011

Well it's not unlimited as indexing got a maximum instances equal to 2^13 instances total - 1 because we don't use 0. Pounce got unlimited instances as it only runs with timers and hashtables.

defskull · Mar 4, 2011

And my notifications never gets old for this thread... Haha

mckill2009 · Mar 4, 2011

like what I said in the other trigger, you cant cast a spell at the same time from the same unit even if cooldown is zero or 0.01...if Im wrong then I stand corrected...

defskull · Mar 4, 2011

DSG said it himself, that a trigger/system can NEVER runs at the same time
It is already hard-coded

baassee · Mar 4, 2011

mckill2009 said:
like what I said in the other trigger, you cant cast a spell at the same time from the same unit even if cooldown is zero or 0.01...if Im wrong then I stand corrected...

it doesnt matter as spells can be traveling/being active during a period which the spell can be re-casted and if you are stupid enough to use the same key of the caster as parent key then the first instance will bug

that's what we are trying to say with our "MUI" talk

defskull · Mar 4, 2011

[broke=*spam click*]c l i c k h e r e t o t e r m i n a t e t h r e a d[/broke]

mckill2009 · Mar 4, 2011

baassee said:
it doesnt matter as spells can be traveling/being active during a period which the spell can be re-casted and if you are stupid enough to use the same key of the caster as parent key then the first instance will bug

that's what we are trying to say with our "MUI" talk

Good thing though that I am now aware of the bug that you mention,

...peace bro!...

Off topic finished...

defskull · Jun 3, 2012

Spells have been re-uploaded, hope moderators can re-moderate this, thank you.

EyeCandy · Jun 3, 2012

lols whats with the %chance to defuse? It would be better if had a dummy invisibility ability that gets removed whenever a enemy unit gets within 100aoe (bomb becomes visible) if its explosion aoe is 250.

-my suggestion of a realistic Modern Warfare spell.

defskull · Jun 3, 2012

If I change the concept instead of triggering, I would be making your spell, and it's not original.

But thanks for the idea though.

eubz · Jun 6, 2012

Great spell man. I really like this one.

Oljin · Apr 13, 2019

works fine, spell is good

v1.2f Timed Bomb

Timed Bomb (Map)

Moderator

Moderator

Similar threads