Underground wave v1.4

Moderator · Dec 22, 2009

16:59, 22nd Dec 2009
TriggerHappy:

Review for Spell

The effect was really nice, not the most original but it was better done than most.
I also couldn't notice any issues within the code.

Status

Feel free to message me here if you have any issues with
my review or if you have updated your resource and want it reviewed again.

Approved

zadelim · Dec 22, 2009

First comment.
The knockback will knock them into deep water and out of bound. Made them cannot move around.

Bluebay · Dec 22, 2009

I know that. Do you suggest to make them land directly to the ground if they go out of bounds or in deep water ? I don't know how to do else.

Kingz · Dec 22, 2009

No custom models in the spell submisions, that is the rule, get rid off the imported stuff and update this.

EDIT:

Reduce the Effects please, casting it more than 2 times can cause serious lag, please make it less with effects.

EDIT2:

First of all if you are angry cause i modified the spell tell me and i will remove the following attachment.

A simple integer comparison could reduce the effects by a lot and make it nice at the same time.
In the map attached below i used a comparison between a (Random Integer between 1 and 4) and checked if it is 1.
If it was 1 i created and destroyed the effect, if not nothing hapened.
I hope you do consider this as your spell would look more original(look at the attachment) and would cause much less lag.

Here is an example how to reduce the effects and remove that import:

X-OMG-X · Dec 22, 2009

Yea Kingz is right. No imports and you should reduce the effects too.

Bluebay · Dec 22, 2009

Ok, I fixed the 'lags' and removed the imported stuff. (9 ko)
But now, my spell looks odd :-/

Kingz · Dec 22, 2009

It looks odd for 1 reason:

You put the comparison for effects under 1 if, use 1 if for every special effect and it actualy looks really cool

Well the lag is significaly reduced but using 3 if's and a wider integer range(from 1 to 3-4) would make the spell look better if you ask me, try it out, it looks like a underground wave should, random

Bluebay · Dec 23, 2009

Okay, i'll fix it right now

EDIT : Fixed.

Kam · Dec 23, 2009

Excellent spell, I shall use it in my race. +rep

Guderian · Mar 24, 2011

Excellent spell i will also use it, but im a bit concerned about units falling in bush areas.

Kam · Jul 14, 2012

It would be better if this had deep water detection.

Virus-X · May 22, 2019

Underground wave v1.4

Underground wave (Map)

Moderator

Moderator

zadelim

zadelim

Resources

Bluebay

Bluebay

Resources

Kingz

Kingz

Resources

Attachments

X-OMG-X

X-OMG-X

Resources

Bluebay

Bluebay

Resources

Kingz

Kingz

Resources

Bluebay

Bluebay

Resources

Kam

Kam

Resources

Guderian

Guderian

Kam

Kam

Resources

Virus-X

Virus-X

Similar threads