12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.

Here's a tip, for your movement trigger:

Create a unit variable called 'temp' and set in custom script to:

• Custom script: set udg_temp = GetEnumUnit()

And use that variable instead of GetEnumUnit() for the 2 lines (GetUnitX/Y)

Also,
Create an integer variable and set it to:

• Custom script: set udg_Integer = GetHandleId(udg_temp)

Then use that integer instead of using Key(Picked Unit) in the rest of the trigger.


In your DamagePeriodic trigger, instead of setting a group then enumerating and destroying it,
you shiould put this:

• Custom script: set bj_wantDestroyGroup = true

Then, you'd "Pick every unit in (Entire Map) .....

This is for efficiency.

In your InCombat trigger, you should use a temp unit variable,
set it to (Damage Source),
use it as (Damage Source),
set it to (Triggering Unit),
use it as (Triggering Unit).

This means you should also change the order of the actions.

Also, in your DamagePeridic trigger, why are you adding all units in TempGroup to DamageGroup if they were supposed to be in DamageGroup initially to be in TempGroup?

Btw, how does this ability work?
It fires for all units on the map?

Magtheridon96 said:

Also, in your DamagePeridic trigger, why are you adding all units in TempGroup to DamageGroup if they were supposed to be in DamageGroup initially to be in TempGroup?

Btw, how does this ability work?
It fires for all units on the map?

Click to expand...

@Also, in your DamagePeridic trigger, why are you adding all units in TempGroup to DamageGroup if they were supposed to be in DamageGroup initially to be in TempGroup?
The temp group was checking to see if the unit is in damage group, if the unit is not it adds the unit to the damage unit group. (idk what you were thinking xD)

@Btw, how does this ability work?
It fires for all units on the map?
The ability works like this: If a unit with this spell is not moving or hasn't been attacked in the past 5 seconds, that unit has bonus regeneration. I thought something like this would be useful for an rpg. Hope that answered your second question.

I have updated it to your requests.

The temp group was checking to see if the unit is in damage group, if the unit is not it adds the unit to the damage unit group. (idk what you were thinking xD)

Click to expand...

Yeah I just noticed that you used (Is In DamageGroup Equal to [highlight]False[/code])

edit
For the second "Pick every unit .." in the Periodic trigger, you don't have to add that "Is In DamageGroup condition" because at that point, every unit in the map will be in the group
Same for the 3rd "Pick every unit.."
And in the third one, are you checking if the unit is alive? (I'm only reffering to the posted code as always )

Why is it called Troll Regeration?

@Magtheridon96 Lol yeah thanks for pointing that out and all the other stuffs, you're like a moderator =)
Ill update teh unit group conditions now.

Edit: Updated at Magtheridon96's request and Maker's request.

Pretty good spell! 5/5

very creative spell, could be very handy for any rpg map

Updated again so that picking of the unit groups don't leak. (Changed Entire map to Playable map)

Awesome. Period.

"You're still doing a very inefficient unit detection. You loop from 1 to 12 and filter too many units.
Only use units that have the ability, don't detect them every 0.03 seconds. Create a group for them, never destroy the group."

I'll fix the amount of units it goes though. But as for not detecting them every .03 seconds, that could be bad an cause some issues. Since usual triggers (That move units) are in a 0.03 periodic event as well. If it is 0.06 then it could save the unit as not moving and a unit could regenerate in air. Which is not good. Of course, if you have any suggestions on how to fix such a problem please supply them.

Ok I fixed what you have required to be fixed.

Damage periodic trigger is not efficient enough. Find a way to make it check less units.

Hmmz... I'll try.

Mkay I hope with will suffice.
~Updated~

Genji Lone said:

Why is it called Troll Regeration?

Click to expand...

For the lack of a better spell name. Lol it's random I know but you can easily change it to fit your needs.

Good idea, but for me spell doesn`t work