Thievery v1.4

Moderator · Sep 12, 2010

12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.

Bribe -

The spell effect art doesn't really fit. A treasure box from a Paladin mixed with really evil orb sounds followed by a very orcish warstomp. Fixing up the art would help to show off the mechanics a lot better.

You don't need GetSpellTargetLoc. Use GetSpellTargetX/Y instead of locations.

You could simplify this:

JASS:

    private function Calculate takes unit u returns real
        local real r
        local integer level = GetUnitAbilityLevel(u,ABILITY_ID)
        set r = FINAL_DMG*level // Deals FINAL_DMG*level of ability final damage (simple math will do this and you could do this in the way you like. This is just a sample
        // FINAL_DMG should be set in your globals or use a custom one if you want
        return r
    endfunction

Into this:

JASS:

    private function Calculate takes unit u returns real
        return FINAL_DMG*GetUnitAbilityLevel(u,ABILITY_ID) // Deals FINAL_DMG*level of ability final damage (simple math will do this and you could do this in the way you like. This is just a sample
        // FINAL_DMG should be set in your globals or use a custom one if you want
    endfunction

This line: if ENABLE_RECYCLING == true then should be static if ENABLE_RECYCLING then

MortAr · Sep 12, 2010

JASS:

        set r[1] = 100
        set r[2] = 200
        set r[3] = 300
        set r[4] = 400
        set r[5] = 500

Can be:

JASS:

local integer i
loop
exitwhen (i >= 5)

set r[i] = i * 100
set i = i + 1

set t = PolarProjectionBJ(p,RANGE,r)
Should be avoided.

set f = FirstOfGroup(g)
Those are bad.

jim7777 · Sep 12, 2010

about the last 2 .. how could I fix those i don't know how and I know it could be but how could I make dat.caster damage the group?? when calling it in a function instead of FirstofGroup and fixing polarprojection

and the damage is based on the user so I just made it that way because they can change it whatever they want but its from my map and the damage calculation is different so i change it that way..

EDIT:
ok currently fixing polarprojection using the straight one @@

looking for fixing firstofgroup in dealing damage >.>

Adiktuz · Sep 12, 2010

jim7777 said:
about the last 2 .. how could I fix those i don't know how and I know it could be but how could I make dat.caster damage the group?? when calling it in a function instead of FirstofGroup and fixing polarprojection

and the damage is based on the user so I just made it that way because they can change it whatever they want but its from my map and the damage calculation is different so i change it that way..

EDIT:
ok currently fixing polarprojection using the straight one @@

looking for fixing firstofgroup in dealing damage >.>

polar projection can be fixed by using the functions that it calls...

for FOG you can use a group loop... you can save the struct instance into a global variable and then create a local instance of the struct and make it equal to the global variable to use it inside the group loop...

HBKph · Sep 12, 2010

how to make jass integers?

jim7777 · Sep 12, 2010

i saw up a function in the forums regarding the polar projection for fixing it..

i can't upload it right now having some problems @@

EDIT:
Updated

MortAr · Sep 12, 2010

Now it looks much better, but I still think you've to change the calculation for "r".

busterkomo · Sep 12, 2010

MortAr- said:

JASS:

        set r[1] = 100
        set r[2] = 200
        set r[3] = 300
        set r[4] = 400
        set r[5] = 500

Can be:

JASS:

local integer i
loop
exitwhen (i >= 5)

set r[i] = i * 100
set i = i + 1

No, that would not even compile properly.

watermelon_1234 · Sep 12, 2010

Code Review:

Don't use locations, use GetSpellTargetX/Y instead
Using DestroyGroup makes GroupUtils pointless. Use ReleaseGroup.
You can use ENUM_GROUP instead of a local group.
I'm pretty sure you should just use GroupEnumUnitsInArea instead of GroupUnitsInArea
~~I don't know why busterkomo said you don't need the local struct but I think you do.~~
Alternatively, instead of having a global integer data, you could have a static member of your struct type in your struct and use that instead.
Example:
JASS:
```
static thistype data
```
You could use a global array for the spell's damage and use Calculate just as a configuration function.
You could just use radians directly to avoid needless conversions.

You don't really need r in ShowSFX.

JASS:

        loop
            exitwhen(i > 4)
            set x = GetUnitX(u) + RANGE * Cos(1.570796*i) // 1.570796 is 90 degrees. 
            set y = GetUnitY(u) + RANGE * Sin(1.570796*i) 
            call DestroyEffect(AddSpecialEffect(SFX2,x,y))
            call DestroyEffect(AddSpecialEffect(SFX3,x,y))
            set i = i + 1
        endloop

It may be a good idea to use local variables for storing the unit's coordinates.

The == true is not really needed in your damage functions.

busterkomo · Sep 12, 2010

watermelon_1234 said:
I don't know why busterkomo said you don't need the local struct but I think you do.

No he doesn't. He uses the global to pass his struct to the function but still uses a local to reference the global.

watermelon_1234 · Sep 12, 2010

Unless I'm misunderstanding something, he's using integer data as the global right? He uses the local variable to typecast it into his struct type.

Edit: Ah never mind.

jim7777 · Sep 13, 2010

ok ok sorry i really codes to messy in structs

fixing my errors yeah and I will try watermelons' static thistype data because i still need to add something (the toss coin effect, but not still this time because i still need to get this code right before adding that coz its somewhat over..)

and about the releasegroup.. sorry because in my Map, i don't use the GroupUtils because I have a function for it

I just copy pasted that part from my map .. gotta get going

Bribe · Feb 10, 2011

S2I("thiefcastables") won't work, needs to be StringHash("thiefcastables")

Also, if you're going to make something a requirement, make it a library, not a scope. The naming convention "library" is there for anything that's more complicated than a standalone snippet.

jim7777 · Jun 9, 2011

oh sorry it took so long to update this one

Magtheridon96 · Jun 9, 2011

Hashtables AND structs??!?!??!
This just defies the laws of nature

You could create another struct (that extends an array) and add a static method operator if you want to store some basic data..

type handle extends nothing

Thievery v1.4

Thievery v1.4 (Map)

Moderator

Moderator

Similar threads