Stormstrike v1.02 by palaslayer

Moderator · Jan 27, 2009

20:35, 15th Feb 2009
Hanky:

Evaluation

Rating Points

Advice: 5 points are the highest rating and 1 point is the lowest rating.

Documentation: 5
Visual Effects: 5
Triggering: 4
Idea: 3

Total:

Rating Comment

The triggering is ok but how you use the integer variable "y" is just senseless and could bug. But else the triggering seems to be leakless and MUI.

The documentation is ok, but you could maybe write instead of "u" just a normal "you". All in all well done, I just can recommend to use this spell if you are searching something like this GUI spell.

Advice: If you didn't understood my rating or if you maybe have questions because you don't know how to fix bugs or leaks etc. You can always send a private message to me. I will answer as soon I got time.

Kingz · Jan 27, 2009

Well great animations, except it hapens too fast i am suprised you had time to take the screenshot...
Add special effects! The spell looks empty and the damage effect(blue explosion) is barely visible...
If you do that and maybe add nicer effects like bleeding or such to units that get slashed...

sfuzzy · Jan 28, 2009

please post what it does?

SrebrniLav · Jan 28, 2009

Wow , rhis spell is excellent! Great job Palaslayer!

Palaslayer · Jan 28, 2009

i will, thx

accelerates at lightning speed towards the direction of the target, slashing through all enemies in the heroes way.

Deals blah damage

^^

jadegolem · Feb 1, 2009

omg add this in dota and we have a better juggernaut =O

Palaslayer · Feb 2, 2009

n rly

have to fix a few bugs in next time

problem with muiness cause trigger seems to interpret an action wrong OO

and a special effect is created without a action oO
i guess i removed it but the trigger still runs the action, lol

i will redo it thx for comments

Palaslayer · Feb 3, 2009

updated

TheBlooddancer · Feb 3, 2009

IMO, it would be better, if he just charged in the facing direction, or that you could still choose where, but he would stop when he reached that place.

Kingz · Feb 3, 2009

Now that deserves a 5/5,i found no bugs/leaks and nice using of special effects this time...
Though better screenshot would be nice^^ and a little explanation text...
EDIT:
Voting to get this aproved...

Palaslayer · Feb 3, 2009

hehe thx kingz

blood, i know what ya mean, with spot and so on
but, rly, i wanted the spell to work like this, cuz it needs more skill to use it in maps

Palaslayer · Feb 15, 2009

finally approved! (sry for double post)

Paladon · Feb 15, 2009

Palaslayer said:
finally approved! (sry for double post)

Burn for it.

Nice.

Dark_Dragon · Feb 15, 2009

funny trigger don't you think?

die
- Events
  - Unit - A unit Dies
- Conditions
  - Or - Any (Conditions) are true
    - Conditions
      - (Unit-type of (Triggering unit)) Equal to TimeChargeDummy
- Actions
  - Set point_c[0] = (Position of (Triggering unit))
  - Special Effect - Create a special effect at (Center of (Playable map area)) using Abilities\Spells\Undead\AbsorbMana\AbsorbManaBirthMissile.mdl
  - Special Effect - Destroy (Last created special effect)
  - Custom script: call RemoveLocation(udg_point_c[0])
  - Unit - Remove (Triggering unit) from the game

you store and remove variable which is never used + you leak one location per each dummy death...

+ your or any condition is true makes stuff slower coz it increases lines of code and adds pointless functions in jass which are called for nothing...

you use variable names like x, y... which is a great chance that somebody else uses which will cause problems for thous who don't know what is wrong...

that is why we in vjass use stuff like public, private members and scopes...

and instead of using a lot of group variables which does leak one group coz when you create group variable you leak one group if not destroyed + you have to do manual destroy after code so just simple use bj_wantDestroyGroup

the thing with killing destructables is not working as you think it does as pick every dest in circle does this
example:

r = 200
loc = (10, -3)

will create region like next:

Rect(x-r, y-r, x+r, y+r)

as you can see even if destructable is not in circle it will be killed coz its in region.

so you must do if then else calculation to check if destructable is in circle

math formula:

Code:

(x-a)^2 + (y-b)^2 <= r^2

this is math circle formula so use it to check is destructable in circle...

the last of all i really don't like how you call variables and triggers there names are really bad if you ask me...

Now about spell style, must say i like it, is mui and almost leakless pretty good, well i named all i didn't like so for now 3.7/5

Fix rest if you find time!
~Dark Dragon

Jack_Sparrow93 · Feb 16, 2009

Looks good, but u haven't changed screenshot for this vers...

Palaslayer · Feb 16, 2009

Dark_Dragon said:
funny trigger don't you think?

die

Events

Unit - A unit Dies

Conditions

Or - Any (Conditions) are true

Conditions

(Unit-type of (Triggering unit)) Equal to TimeChargeDummy

Actions

Set point_c[0] = (Position of (Triggering unit))

Special Effect - Create a special effect at (Center of (Playable map area)) using Abilities\Spells\Undead\AbsorbMana\AbsorbManaBirthMissile.mdl

Special Effect - Destroy (Last created special effect)

Custom script: call RemoveLocation(udg_point_c[0])

Unit - Remove (Triggering unit) from the game

you store and remove variable which is never used + you leak one location per each dummy death...

+ your or any condition is true makes stuff slower coz it increases lines of code and adds pointless functions in jass which are called for nothing...

you use variable names like x, y... which is a great chance that somebody else uses which will cause problems for thous who don't know what is wrong...

that is why we in vjass use stuff like public, private members and scopes...

and instead of using a lot of group variables which does leak one group coz when you create group variable you leak one group if not destroyed + you have to do manual destroy after code so just simple use bj_wantDestroyGroup

the thing with killing destructables is not working as you think it does as pick every dest in circle does this
example:

r = 200
loc = (10, -3)

will create region like next:

Rect(x-r, y-r, x+r, y+r)

as you can see even if destructable is not in circle it will be killed coz its in region.

so you must do if then else calculation to check if destructable is in circle

math formula:

Code:

(x-a)^2 + (y-b)^2 <= r^2

this is math circle formula so use it to check is destructable in circle...

the last of all i really don't like how you call variables and triggers there names are really bad if you ask me...

Now about spell style, must say i like it, is mui and almost leakless pretty good, well i named all i didn't like so for now 3.7/5

Fix rest if you find time!
~Dark Dragon

first i have to rofl a little "roflrofl"

now, hehe, fixing that funny trigger

about destructable = nobody does that if he doesnt use jass

yes u named a lot of things u dont like ^^
+rep for huge documentation, i liek that amount of feedback

i will try to fix some things soon, cuz i want to change some anyway

thx again!

Dark_Dragon · Feb 16, 2009

heh np thats my job to give feedback!

but what do you mean nobody does do circle calculations in GUI?
look its very simple just change your code to this:

Destructible - Pick every destructible within 200.00 of SS_Location4[(Integer A)] and do (Actions)
- Loop - Actions
  - Set TempLoc = SS_Location4[(Integer A)]
  - Set TempLoc2 = (Position of (Picked destructible))
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - ((Power(((X of TempLoc) - (X of TempLoc2)), 2.00)) + (Power(((Y of TempLoc) - (Y of TempLoc2)), 2.00))) Less than or equal to (Power(200.00, 2.00))
    - Then - Actions
      - Destructible - Kill (Picked destructible)
    - Else - Actions
  - Custom script: call RemoveLocation(udg_TempLoc2)

any way i am glade i helped you out.

Greets!
~Dark Dragon

Palaslayer · Feb 16, 2009

thx again, my new system is coming tomorrow!!

f0rsAk3n · Apr 1, 2009

Really Useful Spell with good instructions. 4/5

Palaslayer · Aug 10, 2009

This resource/tutorial will be removed in three days! Bye!

Bogdan-x · Feb 15, 2010

Man i have a big problem.
I tryed to copy 2 spells in my map and the spells fusioned(omg) , now i tryed to copy your spell and now all 3 spell had fusioned (wtf) why all spells are equal with carriown swarm???? Pls help!(2 spells are like blink speed and 1 is like beastmaster dota ultimate)
....Sry for my english....help with spells

tsiga · Jun 16, 2011

sweeeeet 5/5

Stormstrike v1.02 by palaslayer

Noch eine WARCRAFT-III-Karte (Map)

Moderator

Moderator

Similar threads