Thanks for the submission to the spell section, this is a pretty neat system but there's a few things I wanted to point out:
V1.0:
- I'm not sure how appropriate the name "stealth system" is for this, given that nothing pertaining to stealth is involved, at most it's just a potential application for the system to be used in a stealth based map
- The "UNITDATA Hashtable Values" is not as much a requirement of the system as the configuration of the system especially since it's a must for new units to have their data added to it, also why do unit attack ranges need to be stored in it?
- You've forgotten to destroy your temp group in your last trigger so that's leaking
- Please attach a version number to your system so we can keep track of changes made and make it easier to know which version we're reviewing
- I presume the vision adjust trigger can be averted entirely if all units have their default day/night vision as 150? (this isn't an issue, just something I wanted to check, since all units need their vision added to the system manually it wouldn't be considered unreasonable to do that)
- Your description has "GUI Faction System" in it, I assume this was left there by mistake
- How does this interact with changing the time of day manually? such as use of a moonstone
- Really units shouldn't be able to look up cliffs, but even if you leave this limitation in, it should be listed as such
- You have a location leak in Temploc[1]
-
Set STESYS_TempLoc[1] = (Position of STESYS_Unit[1])
-
Set STESYS_TempLoc[1] = (STESYS_TempLoc[1] offset by STESYS_TempReal[2] towards STESYS_TempReal[3] degrees)
Leaks, you will have to use a different location for the second - setting it to something else without destroying the first location causes a leak