Stealth System

ZiBitheWand3r3r · Jun 28, 2017

I like this idea.
However cliffs may be a problem:

and please consider use Unit Event which replaced UnitIndexer
GUI Unit Event v2.3.0.0

streetpunk · Jun 28, 2017

ZiBitheWand3r3r said:
I like this idea.
However cliffs may be a problem:
View attachment 272034

and please consider use Unit Event which replaced UnitIndexer
GUI Unit Event v2.3.0.0

Should vision on cliffs be fog masked too ? Maybe I can come with something for a option to enable/disable this function.

Tank-Commander · Jun 28, 2017

Thanks for the submission to the spell section, this is a pretty neat system but there's a few things I wanted to point out:

V1.0:
- I'm not sure how appropriate the name "stealth system" is for this, given that nothing pertaining to stealth is involved, at most it's just a potential application for the system to be used in a stealth based map
- The "UNITDATA Hashtable Values" is not as much a requirement of the system as the configuration of the system especially since it's a must for new units to have their data added to it, also why do unit attack ranges need to be stored in it?
- You've forgotten to destroy your temp group in your last trigger so that's leaking
- Please attach a version number to your system so we can keep track of changes made and make it easier to know which version we're reviewing
- I presume the vision adjust trigger can be averted entirely if all units have their default day/night vision as 150? (this isn't an issue, just something I wanted to check, since all units need their vision added to the system manually it wouldn't be considered unreasonable to do that)
- Your description has "GUI Faction System" in it, I assume this was left there by mistake
- How does this interact with changing the time of day manually? such as use of a moonstone
- Really units shouldn't be able to look up cliffs, but even if you leave this limitation in, it should be listed as such
- You have a location leak in Temploc[1]

Set STESYS_TempLoc[1] = (Position of STESYS_Unit[1])
Set STESYS_TempLoc[1] = (STESYS_TempLoc[1] offset by STESYS_TempReal[2] towards STESYS_TempReal[3] degrees)

Leaks, you will have to use a different location for the second - setting it to something else without destroying the first location causes a leak

Bribe · Jul 1, 2017

ZiBitheWand3r3r said:
I like this idea.
However cliffs may be a problem:
View attachment 272034

and please consider use Unit Event which replaced UnitIndexer
GUI Unit Event v2.3.0.0

Unless a script needs the specific extra features in Unit Event, it's unnecessary to change it in a demo map. I still use Unit Indexer a la carte in my demo maps because there's no need for the extras.

streetpunk · Jul 4, 2017

Tank-Commander said:
Thanks for the submission to the spell section, this is a pretty neat system but there's a few things I wanted to point out:

V1.0:
- I'm not sure how appropriate the name "stealth system" is for this, given that nothing pertaining to stealth is involved, at most it's just a potential application for the system to be used in a stealth based map
- The "UNITDATA Hashtable Values" is not as much a requirement of the system as the configuration of the system especially since it's a must for new units to have their data added to it, also why do unit attack ranges need to be stored in it?
- You've forgotten to destroy your temp group in your last trigger so that's leaking
- Please attach a version number to your system so we can keep track of changes made and make it easier to know which version we're reviewing
- I presume the vision adjust trigger can be averted entirely if all units have their default day/night vision as 150? (this isn't an issue, just something I wanted to check, since all units need their vision added to the system manually it wouldn't be considered unreasonable to do that)
- Your description has "GUI Faction System" in it, I assume this was left there by mistake
- How does this interact with changing the time of day manually? such as use of a moonstone
- Really units shouldn't be able to look up cliffs, but even if you leave this limitation in, it should be listed as such
- You have a location leak in Temploc[1]

Set STESYS_TempLoc[1] = (Position of STESYS_Unit[1])

Set STESYS_TempLoc[1] = (STESYS_TempLoc[1] offset by STESYS_TempReal[2] towards STESYS_TempReal[3] degrees)

Leaks, you will have to use a different location for the second - setting it to something else without destroying the first location causes a leak

° I decided to call it "Stealth System" because it adds a new strategy to the game, where you can take a enemy army by surprise if you come behind it;
° Changed UNITDATA to configuration and removed attack range values;
° Destroyed the temp group and removed the leaks;
° Version number attached;
° Vision Adjust trigger is now configurable in the STESYS Pre Config trigger;
° Removed "GUI Faction System" which was mistankenly placed because I used the same description template as I did on my "Faction System";
° The system works well with both player set time of day and moonstone;
° I'm working on something for the cliffs but I guess it's beyong my capabilities (I think I would need a pathability checker or something for that) also the cliff issue is listed on "cons" list;
° Fixed Location leak.

Bribe said:
Unless a script needs the specific extra features in Unit Event, it's unnecessary to change it in a demo map. I still use Unit Indexer a la carte in my demo maps because there's no need for the extras.

Thanks for pointing that out! I like the "Unit Indexer" because it's a single trigger (easy to CnP) and because of it's simplicity.

Bribe · Jul 4, 2017

streetpunk said:
Thanks for pointing that out! I like the "Unit Indexer" because it's a single trigger (easy to CnP) and because of its simplicity.

Yeah me too. I hate copying abilities when importing systems. I wish World Editor would automatically copy the abilities from the source map when referenced by a trigger.

KILLCIDE · Dec 18, 2017

Neat system, but as Tank-Commander suggested, calling it Stealth System is extremely misleading. Something like "Vision System" or w/e would have been way better. Having to manually register ever unit's day and night vision will be tedious, but it can be useful.

Needs Fixed

Nothing

Suggestions

Documentation would have been nice. You have a lot of magic numbers (especially in Vision Adjust) that don't really make sense to me
I would use a custom integer variable instead of Integer A just to avoid possible collisions
Please add STESYS_SightAbility as a configurable variable. Having to change that reference in Vision Adjust 18 times sounds like hell compared to the one time you would have to do it if it were just a configurable variable.

Status

Approved

streetpunk · Feb 8, 2018

Version 1.02 is out! Check the changelog for info on what's new!

Daffa · Feb 8, 2018

does this account moonstone?

streetpunk · Feb 8, 2018

* The system works well with both trigger/player set time of day and also works with moonstone; Also there was already a hero in the map to test moonstone usage.

Hazop · Feb 9, 2018

its not working ._.

streetpunk · Feb 9, 2018

Can you please specify what's not working ?

Hazop · Feb 9, 2018

streetpunk said:
Can you please specify what's not working ?

I am not sure, the trigger is fine, and nothing is disabled.

streetpunk · Feb 9, 2018

I'll test it, be right back!

EDIT:
All right, so here's what going on:
#1: You are using the function

Melee Game - Use melee time of day (for all players)

Which will cause the system to not work.
#2: On the trigger "STESYS Pre Config" you need to set the right ability (STESYS_SightAbility) into the function

Set STESYS_SightAbility = "Random Ability"

like this

Set STESYS_SightAbility = STESYS_SightAbility

#3 All custom units sight range values must be introduced into the "UNITDATA Hashtable Values" trigger, as descbribed in the instructions, like this:

UNITDATA Hashtable Values
- Events
  - Map initialization
- Conditions
- Actions
  - -------- -----------------------------------------------------------------------------CUSTOM UNITS --------
  - -------- My Custom Unit --------
  - Set UNITDATA_UnitType = My Custom Unit (this is the unit type)
  - Custom script: set udg_UNITDATA_UnitTypeInteger = udg_UNITDATA_UnitType
  - Hashtable - Save 1600 as UNITDATA_SIGHTDAY of UNITDATA_UnitTypeInteger in UNITDATA_Hash
  - Hashtable - Save 500 as UNITDATA_SIGHTNIGHT of UNITDATA_UnitTypeInteger in UNITDATA_Hash
  - -------- ----------------------------------------------------------------------------- --------
  - -------- -----------------------------------------------------------------------------HUMAN --------
  - -------- ----------------------------------------------------------------------------- --------
  - -------- UNITS --------
  - -------- PEASANT --------
  - Set UNITDATA_UnitType = Peasant
  - Custom script: set udg_UNITDATA_UnitTypeInteger = udg_UNITDATA_UnitType
  - Hashtable - Save 800 as UNITDATA_SIGHTDAY of UNITDATA_UnitTypeInteger in UNITDATA_Hash
  - Hashtable - Save 500 as UNITDATA_SIGHTNIGHT of UNITDATA_UnitTypeInteger in UNITDATA_Hash
  - -------- - --------

Diegoit · Jul 25, 2018

It can see through trees n vision obstacles :/

streetpunk · Jul 26, 2018

This is not an error, units are allowed to see what's in front of them. However, in a near future, I plan on having the blocked vision on destructibles and cliff added as an optional feature.

Stealth System

Stealth System v1.02 (Map)

Needs Fixed

Suggestions

Status

Similar threads