12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

23:22, 22nd Aug 2012
Magtheridon96:

Just a quick review:

- All speeds must be MUI and MPI, not just one.
- Instead of repeating function calls like (Owner of blabla), (Picked unit), (Triggering unit), etc..., store them into variables and use those.
- You have a group leak inside the loop trigger when you're getting a random unit. You should set bj_wantDestroyGroup to true right before you get the random unit.
- The "Random unit in (group)" action in GUI is a load of baloney. You can simply just set the unit the variable to FirstOfGroup(udg_yourGroup)
- That 11.11 should be configurable somewhere.

That's all I guess.

I get the feeling it's only MPI, but it could just be my imagination, I'll have to test that. Though I would like to point out "begins casting an ability" shouldn't be used, it -can- if I remember correctly by abused.

Edit: Well yes it's abusable but it seems MUI, that or I can't cast two spells close enough in time as a single player to be able to cause a bug, as it is you can cast the spell without putting it on cooldown by stopping the spell after casting it (if you time it correctly)

Other notes: You need a configuration for this spell, having everything as a constant inside the spell isn't exactly the best of things to have.

Your attack orders I should think are relatively pointless, wouldn't they just retarget on their own? Think this also breaks the authenticity rule by not registering the actual damage source, correcting it is fairly simple, you just do the damage with the triggers, and use the object editor spell to put the stun on only and not deal the damage. really I don't quite follow the point of the loop, it doesn't exactly do anything which effects the game, it's just a whole trigger to make some pretty effects go off, this spell would function the same with or without that

The spell is meant to be used for one hero per player in a desired game.
Any useful criticism would be appreciated.

Edit: Wait... Why didn't I merge the two casting triggers. I'll do that right away.

Your attack orders I should think are relatively pointless, wouldn't they just retarget on their own?

Click to expand...

This spell could be useful for maybe rpgs, AIs or just to confuse the opponent.

really I don't quite follow the point of the loop, it doesn't exactly do anything which effects the game, it's just a whole trigger to make some pretty effects go off, this spell would function the same with or without that

Click to expand...

Just special effects to add to the spell.

Edit2: updated

use the object editor spell to put the stun on only and not deal the damage.

Click to expand...

What would be the point in this exactly?

DeathChef said:

This spell could be useful for maybe rpgs, AIs or just to confuse the opponent.
Just special effects to add to the spell.

Click to expand...

Well it wouldn't really confuse the opponent, they'd retarget on their own, as would well programmed AIs even if you did make them attack other units, Rpgs? Maybe, but what if the new selected target is behind a wall which it cannot get to? it'll try to get to it, but never succeed, not to meantion target structures or units it can't actually attack at all.

DeathChef said:

What would be the point in this exactly?

Click to expand...

So it could be configurable, So that the damage source is recognised, that kind of thing