• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

scorpion182's spellpack 1 v1.1

This is the first release of my spell pack.
I have not found bugs yet but if you do, tell me please.
And if you find any leaks, tell me of that too.

Those spells are:

Broken Phatasm:
Broken Phantasm consists of packing a Noble Phantasm with prana and making it explode when striking the target with it.
Mamaragan:
Creates a thunder storm showers lightning everywhere in target location, that deal massive damage.

~scorpion182~

v1.0
- first released

v1.1
- Deleted Unneeded Variabel
- Added Preload Ability Trigger to Avoid First Time Casting Lag
- Fixed Code Follow xxdingo93xx Suggestion :D
- Fixed Mamaragan Damage Configuration

Keywords:
lightning, thunder, blow, explode, arrow, strike, storm, eneru, archer
Contents

scorpion182's spell pack 1 (Map)

Reviews
21:08, 18th Dec 2008 Hanky: Well the spells are ok so far. The script is ok, also it seems to be leakless and MUI. But you should learn not to use TriggerSleepAction functions because that's not good for multiplayer. Also you should use not much...

Moderator

M

Moderator

21:08, 18th Dec 2008
Hanky:
Well the spells are ok so far. The script is ok, also it seems to be leakless and MUI. But you should learn not to use TriggerSleepAction functions because that's not good for multiplayer. Also you should use not much location function because it would be much more effective to use x/y. Well the visual effects are ok. The documentation is abit to less but I think it's still acceptable.

All in all two good spells with some space to improve. I can just recommend to use this spells if someone searching spells like these.

Possible Improvements:
- get rid of the TimerSleepAction and the location functions
- sometimes the jass could be much more effective used
- also maybe using the function of the JNPG would make the spellpack more alot more effecient
 
Level 17
Joined
Sep 8, 2007
Messages
994
Readme
Note that my rating will not have any influence to moderators reviews.
This review consists out of my personal attidude and opinion about this spell/these spells.
Review

Idea/Creativity: 6/10
Coding: 8/10
Balance: 8/10
Ability Tooltip: 10/10
MUI: Yes (+2/10)
(Yes: +2/10, No: -2/10, MPI: +/-0/10)
Language: Jass (+1/10)
(GUI: +/- 0/10, Jass: +1/10, vJass: +2/10)
Total: 35/40

Medial: 8/10 = 4/5

Viewers Note:
Ahh...good old Jass spells .. ^^ The spell Broken Phantasm is pretty neat, the Mamaragan is rather simple but OK.
Your coding seems to be OK except of some flaws.

1.
JASS:
local location loc=GetUnitLoc(target)
Locations shouldn't be used. As I can see correnctly, you don't even use it. So better delete it ^^
2.
Get rid of the TriggerSleepActions.
3.
JASS:
    local unit dum1
    local unit dum2
    local unit dum3
A unit array would save lines and make it look better. So you can also use a loop.

It is balanced well, though I recommend to define the damage in a seperate function to make it easier configurable. Documentation is well made except of telling about rawcodes.
No need to tell much about the ability tooltip, it is just perfect.
MUI and Jass -> extra score.

All in all neat (good old Jass) Spells, recommendable. Fix the things I mentioned and it would be even better. :thumbs_up:
 
Level 16
Joined
Jun 9, 2008
Messages
734
@xxdingo93xx
thanks for the suggestion, i'll update this spellpack soon. but i can't get rid of the TriggerSleepActions, cause i need it to hold the trigger before the missile hit the target :grin:

@tuantai120
i'll upload those spells someday but not now, please understand :smile:

UPDATED
v1.1
- Deleted Unneeded Variabel
- Added Preload Ability Trigger to Avoid First Time Casting Lag
- Fixed Code Follow xxdingo93xx Suggestion :D
- Fixed Mamaragan Damage Configuration
 
Top