18:24, 20th Sep 2009
The_Reborn_Devil:

Triggering:
There are no leaks now. I would recommend to replace those BJ's with the native versions though, but that is not necessary.
Eye-Candy:
The eye-candy is nice and original.
Idea:
The idea is not that original as I've seen a lot of spells that somehow block or reflect damage.
Tooltip:
The tooltip is good, and gives enough information to the user.
Implementation:
It should be easy to implement, but a little information couldn't do any harm.
Overall:
It got a lot of leaks, and the triggering could certainly get better.
It looks quite nice and I'm sure there are a lot of people who would want this kind of spell in their map.

Spell Approved.
I give this spell the rating useful.

If there's something you feel that's incorrect just PM me.
Remember to have a good reason for why you feel it's incorrect and I might review it again

Why did u take the screenshot in a replay? Just courious...

It leaks locations.

• Unit - Create 1 ReflectDummy for (Owner of (Triggering unit)) at (Position of (Triggering unit)) facing (Position of (Damage source))

wow on the first look it just looks genius, but i think there might be some issues(or i just didnt get it right)

also the i am very thankfull for that trick to make -unit takes damage- available in GUI. i think that might be very usefull to me in the future

first one is in the trigger Trigg Reflect:

• Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Reflect_Users is empty) Equal to True
    • Then - Actions
      • Trigger - Add to Reflect <gen> the event (Unit - (Casting unit) Takes damage)
      • Unit Group - Add (Triggering unit) to Reflect_Users
      • Skip remaining actions
    • Else - Actions
  • Unit Group - Pick every unit in Reflect_Users and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Casting unit) Equal to (Picked unit)
        • Then - Actions
          • Skip remaining actions
        • Else - Actions
          • Unit Group - Add (Triggering unit) to Reflect_Users
          • Trigger - Add to Reflect <gen> the event (Unit - (Casting unit) Takes damage)

why u make the trigger skip the remaining actions, instead of just paste the remaining actions into the else-tree of the first if-then-else function?

• Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Reflect_Users is empty) Equal to True
    • Then - Actions
      • Trigger - Add to Reflect <gen> the event (Unit - (Casting unit) Takes damage)
      • Unit Group - Add (Triggering unit) to Reflect_Users
    • Else - Actions
      • Unit Group - Pick every unit in Reflect_Users and do (Actions)
        • Loop - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • (Casting unit) Equal to (Picked unit)
            • Then - Actions
              • Skip remaining actions
            • Else - Actions
              • Unit Group - Add (Triggering unit) to Reflect_Users
              • Trigger - Add to Reflect <gen> the event (Unit - (Casting unit) Takes damage)

also one well not leak, but not accaptable one is:

• Else - Actions
  • Unit Group - Order (Units in (Playable map area)) to Night Elf Demon Hunter - Deactivate Immolation

because that will make all units turn off the reflect ability (and also other units with immolation)

instead u should make

• Else - Actions
  • Unit - Order (Triggering unit) to Night Elf Demon Hunter - Deactivate Immolation

also i dont get why u create that dummyunit and make it cast that spell. why u just create a special affect at the damage source instead?

also u should remove the waits, because wait is evil (and minimum time for wait is 0.27 seconds acording to some tutorials here). and if you remove the waits and the dummy unit stuff, you could also save the triggering unit as some variable, to take some pressure from the cpu

anyway very good job and +rep btw

EDIT: also i dont get why u use -unit stops casting an ability-, wouldnt -starts the effect of an ability- be better?

also u should add that the "reflect" trigger is turned off when no unit has the ability active, because else every time a unit takes dmg it is checked if it has that buff. thats wasted CPU-power

it doesn't check if a unit has the buff. it will only event trigger if it has events hence why it's always on. this is also my second spell so expect better things to come

@godslayer
thanks for the comments that else deactivate immolation isn't supposed to be used like that probably a minor mistake as i was trying to set up the spell structure
also, the waits are only in there so that the dummy units attack and deal the % damage better on time instead of instant but i thought of another way for the units to deal the damage just now but i probably won't implement it until later.

also, the second skip remaining actions is more so for newer people to understand what's going on.

@jack_sparrow
i took it in replays so i could get the coolest shot that explains the most of what it does. going 1/2 speed is much easier and also teh pause ability

to everyone i'll fix it up though expect update in a few hours or less.

Triggering is poor. Also you use w8 actions. this is not good at all.
It is very strange: you use jass functions and dont know how to clear point leaks.
I dont likeit at all.

deth_lord said:

it doesn't check if a unit has the buff. it will only event trigger if it has events hence why it's always on.

Click to expand...

once the event is addet, it will stay for that trigger. (because it is not beeing removed )

so the trigger will always check. so u have to remove that event again(what is not possible i think) or deactivate the trigger

also i still dont get the dummy units, but lets see what ur next update brings.

mmmk updated fixed the few things and the location leak tell me what you think!
also, godslayer. i use dummy units so that it visually shows the reflection missile not just damage. that's boring
furthermore, it is like that so that it can be mui. so that multiple units could use it. although i recommend not giving this to common scrap units but heroes

@nfwar
what's wrong? details plz.

deth_lord said:

mmmk updated fixed the few things and the location leak tell me what you think!
also, godslayer. i use dummy units so that it visually shows the reflection missile not just damage. that's boring

@nfwar
what's wrong? details plz.

Click to expand...

but u dont need the dummy unit XD
just make create a special affect like:

• Actions
  • Custom script: local unit dummy
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Mana of (Attacked unit)) Greater than or equal to 30.00
    • Then - Actions
      • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) + (Damage taken))
      • Unit - Set mana of (Triggering unit) to ((Mana of (Triggering unit)) - 30.00)
      • Special Effect - Create a special effect attached to the chest of (Triggering unit) using Abilities\Spells\Items\SpellShieldAmulet\SpellShieldCaster.mdl
      • Special Effect - Destroy (Last created special effect)
      • Special Effect - Create a special effect attached to the chest of (Damage source) using Abilities\Spells\NightElf\Blink\BlinkCaster.mdl
      • Special Effect - Destroy (Last created special effect)
      • Unit - Cause (Triggering unit) to damage (Damage source), dealing ((Damage taken) x (((Real((Level of Reflect for (Triggering unit)))) x 0.15) + 0.15)) damage of attack type Spells and damage type Normal
    • Else - Actions
      • Unit Group - Order (Units in (Playable map area)) to Night Elf Demon Hunter - Deactivate Immolation

that is far better than ur dummy unitstuff

mine looks cooler
if you want to change stuff like that go ahead this is just a general spell. very simple to figure out what to change. although the on damage event was a bitc- to figure out T.T

deth_lord said:

mine looks cooler
if you want to change stuff like that go ahead this is just a general spell. very simple to figure out what to change. although the on damage event was a bitc- to figure out T.T

Click to expand...

its not about the effect, its about the triggering: because mine doesnt take dummy units and waits, wich is far better then creating dummy units and make em cast spells.

btw if you want that missile death animation, just create an dummy with the missile graphics at the position of the damage source, and kill it immediately. that would also be better then the casting dummy.
the casting dummy would only be usefull if you want to see a flying missile

Well, idea seems cool I'll check it tomoro if I get the time

the dummy leaves a shadow behind

the idea is basic but nice and there are several things which could be improved
gl improving it

edit:
yay!!! 256 posts!! xD

Maybe heard off nulling locals...? =)

Aww.. and btw maybe instead of this:

• Unit Group - Pick every unit in Reflect_Users and do (Actions)
  • Loops - Actions
    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • 'IF'- Condition
        • (Casting unit) Equal to (==) (Picked unit)
      • 'THEN'-Action
      • 'ELSE'-Action
        • Unit Group - Add (Triggering unit) to Reflect_Users
        • Trigger - Add to Reflect <gen> the event (Unit - (Casting unit) takes damage)

use this...

• Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 'IF'-Bedingungen
    • ((Triggering unit) is in Reflect_Users) Equal to (==) False
  • 'THEN'-Aktionen
    • Unit Group - Add (Triggering unit) to Reflect_Users
    • Trigger - Add to Reflect <gen> the event (Unit - (Casting unit) takes damage)
  • 'ELSE'-Aktionen

k updated dummy no longer has shadow and the if is changed. didn't know there was one or i'd have used it i look but there's no unit-group comparison for some reason T.T
also @Hanky english please

I guess I wrote english?... well after you used those locals null them otherwise they'll cause leak...

But the second point I told you isn't hard to understand, is it?

What hanky is saying, at the end the trigger, null your local variables.
ie: set <somelocal> = null

Do that for all locals except reals, integers, and string


Now my advice:

Use:

• Unit - A unit Starts the effect of an ability (Bad)

Instead of:

• Unit - A unit Begins casting an ability

Also, don't use waits. Because: Avoiding the usage of Wait (Essentials Tutorial)


Also, don't these two conditions do the same thing?

• Trigg Reflect
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Reflect
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Reflect_Users is empty) Equal to True
      • Then - Actions
        • Trigger - Add to Reflect <gen> the event (Unit - (Casting unit) Takes damage)
        • Unit Group - Add (Triggering unit) to Reflect_Users
        • Skip remaining actions
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in Reflect_Users) Equal to True
      • Then - Actions
      • Else - Actions
        • Unit Group - Add (Triggering unit) to Reflect_Users
        • Trigger - Add to Reflect <gen> the event (Unit - (Casting unit) Takes damage)

Well I see coding to be very poor and needing some fixing. Good luck with that.

originally, the coding wasn't like that if you look 2 posts before yours you'll see that. i changed it and just didn't think to delete that part. also, from your tutorial's description the reason we cannot use wait's is because it makes it not mui but my spell uses locals. hence why i do not need to not use wait. as for that first part i will remove it though.

Yes I understand the thing on MUI, but both Wait's are under 0.27 seconds, thus you can't use them :s I explained that in the tutorial too

You allmost got me!
You could add 2 more triggers to this to make it MUI..
AND remove the waits, thats for sure.

I should leave comment here before I could rate this, heheh ^_^

call UnitApplyTimedLifeBJ( 1.00, 'BTLF', dummy )

BTLF what is this it is a unit or spell or what? I found only where is 'u000' but that second its not on ur map

when i copied it ant pasted it it didn´t worked, also there is more than one dummy unit ._.

I think this is a pretty awesome spell but some suggestions:

• Improve the demo map a bit. Give the Jedi a passive icon ability which describes the spell like here in the description of Hive. Otherwise, I have to read it again here. There is some stuff with a defend order and on hero revival but I can't do anything in the demo map with Defend or reviving my hero. Reveal the whole map from start and preplace everything you can do with the system.
• Why are there so many GUI trigger variables? Are they from the dependency libraries? Why aren't they placed in vJass in a globals block?
• Maybe you can list all dependency systems with links in the description on Hive to make it clear.
• Is there a GUI version and a JASS version or is the pure JASS stuff just some code required for the system?
• You can create a constant instead of this one global GUI variable for the Defend ability code.
• Some blocking animation from the Jedi would be awesome. Maybe you need a modified model which can do a block while walking and standing and play the animation whenever the Jedi reflects a shot.

Updated 2009, my man. You can make those changes for your own benefit but I guarantee you this is never being updated.