12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

22:19, 19th Aug 2011
Pharaoh_:
The spell itself is not really creative, but it can be a nice sample for triggering newbies.

•

• Animation - Change Target flying height to (Default flying height of Target) at 0.00

Remove (Default flying height); this skill targets ground units only, of which the fly height will always be 0. This creates a redundant function call; change it to 0.

• Owner of Caster in the Pulverize Cast trigger can be (Triggering player); it in fact procs faster.

• There is an issue that units do not always get damaged; I would advise you to damage them with triggering, because damage should be configurable (and not via the Object Editor). Someone might want to damage the units for Caster's ((Strength + Agility) / 2), for example. Also, use Channel as the base ability and trigger the effects (make them configurable as well).

• In the Pulverize Knockback trigger, you remove the "Point" variable twice; the second removal is not needed, since you don't declare it (it's after the Remove (Picked unit) from the game action).

Everything else looks fine.

• Unit Group - Pick every unit in Enemies and do (Actions)
• Loop - Actions
• Set LoopNumber = (LoopNumber + 1)
• Hashtable - Save Handle Of(Picked unit) as LoopNumber of HandleID in Hashtable
• Unit - Add Storm Crow Form to (Picked unit)
• Unit - Remove Storm Crow Form from (Picked unit)
• Unit - Pause (Picked unit)

You should store (Picked Unit) in a variable so you dont repeat the same function call again and again

Also, you shouldn't add the ability and remove it like that

Use these custom scripts instead:

• Custom script: if UnitAddAbility(udg_YourUnit,'Arav') then
• Custom script: call UnitRemoveAbility(udg_YourUnit,'Arav')
• Custom script: endif

Oh and you should also use variables to reduce function calls in other places too..