Power Embrace ver1.1

Moderator · Oct 4, 2009

19:48, 4th Oct 2009
TriggerHappy187:

Right now it's leakless, and visually appealing. But remember to take in the suggestions I made.

Approved.

Axarion · Oct 4, 2009

Looks nice. I'll test it today.

Septimus · Oct 4, 2009

code seems to be ok. Then again, I am not that good with JASS. Could be wrong about it, though...

hell gate · Oct 4, 2009

why you don't learn vJass?
(the jump is to fast i think)

Shdow89 · Oct 4, 2009

hell gate said:
why you don't learn vJass?
(the jump is to fast i think)

No, that's not it. I'm still learning it, and I have huge problems with installing it.
And I am kinda lazy to learn it, since I'm just enjoying making spells with JASS... Have to find time to learn vJASS

.
Thank you all for your comments, and I hope you like the spell.

Deuterium · Oct 4, 2009

JASS:

call TerrainDeformCrater(x, y, radius, depth, R2I(duration * 1000), false)

This should work just fine

TriggerHappy · Oct 4, 2009

Spell is visually pretty cool, though I'm not sure about the large spike of terrain at the end.

I will list some things that are not improvements, but rather things that are not needed.
- You don't need to null triggers.
- The TriggerRegisterAnyUnitEventBJ is perfectly fine, no need to use the native equivalent.
You should make your timer interval configurable.
Right now your dynamically creating groups, and since your using a hashtable it would be pretty simple (and more efficient) to create a group, store it in the hashtable, and re-use it in your triggers.
Your InitHashtable trigger would be better of in GUI, this way people don't have to manually create the hashtable. If it is in GUI the variable will auto-copy over.

This should work in replacement for that BJ;

JASS:

call TerrainDeformCrater(GetUnitX(dummy), GetUnitY(dummy), Orb_Blast_AOE(), Orb_Crater_Depth_Value()* (-1.0), 500, false)

Deuterium · Oct 4, 2009

TriggerHappy187 said:
The TriggerRegisterAnyUnitEventBJ is perfectly fine, no need to use the native equivalent.

True in this case, but it'll be better if he uses the true boolexpr instead of the "null"

@ TriggerHappy187:
You're a "what" mod?

Spell section?

Shdow89 · Oct 4, 2009

TriggerHappy187 said:
Spell is visually pretty cool, though I'm not sure about the large spike of terrain at the end.

I will list some things that are not improvements, but rather things that are not needed.

You don't need to null triggers.

The TriggerRegisterAnyUnitEventBJ is perfectly fine, no need to use the native equivalent.

You should make your timer interval configurable.

Right now your dynamically creating groups, and since your using a hashtable it would be pretty simple (and more efficient) to create a group, store it in the hashtable, and re-use it in your triggers.

Your InitHashtable trigger would be better of in GUI, this way people don't have to manually create the hashtable. If it is in GUI the variable will auto-copy over.

This should work in replacement for that BJ;

JASS:

call TerrainDeformCrater(GetUnitX(dummy), GetUnitY(dummy), Orb_Blast_AOE(), Orb_Crater_Depth_Value()* (-1.0), 500, false)

First of all thank you all for your comments, I really appreciate them

.
Now, well I'm always using, TriggerRegisterUnitEvent native, since I always believed it was faster. I guess I'll change it. Now, don't triggers extend as handles? I mean, if they do, then I have to null them, won't they leak otherwise?
I would really like to know how to not dynamically create groups. But, I will need some help with this. Do you mean I create a group at the action function of my spell, and then I just LoadGroupHandle in other functions, that are needed. Or do I make a group in the InitHashtable trigger, then it would have to be a global group?
And thank you for TerrainDeformation native

.

TriggerHappy · Oct 4, 2009

triggers extend as handles? I mean, if they do, then I have to null them, won't they leak otherwise?

You only need to null handles that you destroy, and you don't destroy triggers.

I would really like to know how to not dynamically create groups. But, I will need some help with this.

You basically just use a global group and keep enumerating it over and over. No need to destroy it either. Make sure to clear it after (if there are any units left inside of it).

As for using it with the hastable, in your init trigger do something like;

call SaveGroupHandle(hashtable, StringHash("Global Group"), 0, CreateGroup())

And use some constant function like;

JASS:

function GLOBAL_GROUP takes nothing returns group
    return LoadGroupHandle(hashtable, StringHash("Global Group"), 0)
endfunction

True in this case, but it'll be better if he uses the true boolexpr instead of the "null"

Null boolexprs don't leak inside events. I have confirmed it myself as well as seen tests from numerous others.

Shdow89 · Oct 5, 2009

Ok, updated to TriggerHappy187 suggestions. Thank you.

EDIT: Groups can't be loaded withing constant function, it gives tons of errors. So I just used

JASS:

LoadGroupHandle(udg_HashTime, StringHash("Global Group"), 0)

, in all places where I'm enumerating a group.

Atami · Oct 6, 2009

Okay, this spell is very nice...
(+) Looks realy nice
(+) Do this which i have to imagine
(-) Its aint MUI

I hope this helped you to improve.
Happy Mapping
"Atami"

Shdow89 · Oct 7, 2009

Atami said:
Okay, this spell is very nice...
(+) Looks realy nice
(+) Do this which i have to imagine
(-) Its aint MUI

I hope this helped you to improve.
Happy Mapping
"Atami"

Excuse me? It's ain't MUI? That's not possible, I checked the spell and code 20 time for MUI support and it was MUI O_O. I just tried it and it is MUI.

Power Embrace ver1.1

Power Embrace (Map)

Moderator

Moderator

Similar threads