Omnislash JASS Spell 1.3

Moderator · Jul 28, 2009

11:30, 24th Aug 2009
hvo-busterkomo: The spell will need a lot of optimizations in order to be ready for approval. Use GroupUtils instead of a local group, switch from locations to coordinates, and use a single line to create and destroy the effect.

Rmx · Jul 28, 2009

Ok, the spell is very uncreative and many times have been done.

Sorry to say that but you should look at the spell section more often.

I myself included 2 omnishlash kinda spells in hive.

This should help you see better http://www.hiveworkshop.com/forums/spells.php?search=omnislash&d=list&r=20

Could i ask you to be more creative, No offense on anything thought.

Septimus · Jul 28, 2009

This is make in GUI and convert it to JASS.

If my memory serves me right, here leak 16 boolexpr...

JASS:

function InitTrig_Slash takes nothing returns nothing
 set gg_trg_Slash = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(gg_trg_Slash, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(gg_trg_Slash, Condition(function Slash_Condition))
    call TriggerAddAction(gg_trg_Slash, function Slash_Actions)
endfunction

It also a clear sign of you making this in GUI and convert it to JASS.

And nobody going to name a function like this.

function Trig_Untitled_Trigger_001_Func00100200

Thanathos · Jul 28, 2009

Here we have another omnislash, but not very well made
I´ve some complainments about the code:

1.	Replace `IsUnitDeadBJ(SomeUnit)` with `GetWidgetLife(SomeUnit) > 0`
2.	You used some other BJ which can be evaded
3.	Get Rid of the TSA
4.	ATM your spell is a bit hard to configurate i think, you could add some constants to make it easier
5.	That code is hardly readable, do some better indention and add some free lines

And i also noticed if there are some dead units near the caster the spell somtimes bugs...instead of for example 10 slashes the caster slashes only 2 or 3 times

Ironside · Jul 28, 2009

Septimus said:
This is make in GUI and convert it to JASS.

If my memory serves me right, here leak 16 boolexpr...

JASS:

function InitTrig_Slash takes nothing returns nothing set gg_trg_Slash = CreateTrigger() call TriggerRegisterAnyUnitEventBJ(gg_trg_Slash, EVENT_PLAYER_UNIT_SPELL_EFFECT) call TriggerAddCondition(gg_trg_Slash, Condition(function Slash_Condition)) call TriggerAddAction(gg_trg_Slash, function Slash_Actions) endfunction

It also a clear sign of you making this in GUI and convert it to JASS.

And nobody going to name a function like this.

function Trig_Untitled_Trigger_001_Func00100200

Well i'm begginer at JASS.. offcorse i have to convert some stuff still...

Oh btw. what's wrong with BJs anyway?

Septimus · Jul 28, 2009

Oh btw. what's wrong with BJs anyway?

Bj make another call, which are particular slower. For example, if natives makes 1 call to execute 1 action... bj would need to make about 2 calls to execute 1 action. (I cannot remember, I hope I explain it correctly)

Then again, not all bj was evil.

Thanathos · Jul 28, 2009

BJ are bad because the they often just call natives.
For example:

JASS:

function PauseUnitBJ takes boolean pause, unit whichUnit returns nothing
    call PauseUnit(whichUnit, pause)
endfunction

this way of calling functions is slow and can be easily evaded. In my example you just have to remove the BJ. Other BJ as for example TriggerRegisterAnyUnitEventBJ need to be inlined because they do some more stuff than just calling a native.

[Edit]
Oh sorry Septimus was faster..

Septimus · Jul 28, 2009

BJ are bad because the they often just call natives.

Yep, why need to make bj to call natives when you can call natives straight away.

Ironside · Jul 28, 2009

Ok will try fix soon

Cheezeman · Jul 28, 2009

Hey, to be a commonly uploaded DotA spell this isn't very bad, after all it's MUI.
I'm not saying it's good, but it isn't crap.
Anyway here are things I found:

temp_loc is never nulled
temp is only sometimes nulled
blinkEffect and targetEffect are never nulled

Coding:
set blinkEffect = AddSpecialEffectLoc("Abilities\\Spells\\NightElf\\Blink\\BlinkTarget.mdl", GetUnitLoc (caster)) call DestroyEffect (blinkEffect)

can be replaced with:
call DestroyEffect( AddSpecialEffectLoc("Abilities\\Spells\\NightElf\\Blink\\BlinkTarget.mdl", GetUnitLoc (caster)))

Thus avoiding the two variables that wern't nulled.
In first If statment (in the loop) there's an empty "else", just remove it
Uses alot of short TriggerSleepAction() which might cause obscure bugs. If you can, replace it with a Timer.
Replace the IsUnitDeadBJ( GetFilterUnit() ) with GetWidgetLife( GetFilterUnit() ) < 0.405. It's faster and more reliable.
This is a minor issue, but I suggest you use exitwhen count <= 0 instead of == 0, cause if the CPU calculates alot of stuff and happens to "miss" the exitwhen count == 0, you're garantueed that it will still exit (just giving you an additional target)

Improvements:
Setup section? Currently you have to change 3 params if you get another rawcode for the spell. It would be alot more userfriendly

I hope it helps. If you're confused just ask, I'm here to help not judge.

Deuterium · Jul 28, 2009

Well I won't check, but I'd say something:
I've seen some very well done omni-slashes, making this useless to anyone.
I'm not trying to offend you in any way, but spells made for practice, shouldn't be posted here...

Ironside · Jul 28, 2009

Septimus said:
This is make in GUI and convert it to JASS.

If my memory serves me right, here leak 16 boolexpr...

JASS:

function InitTrig_Slash takes nothing returns nothing set gg_trg_Slash = CreateTrigger() call TriggerRegisterAnyUnitEventBJ(gg_trg_Slash, EVENT_PLAYER_UNIT_SPELL_EFFECT) call TriggerAddCondition(gg_trg_Slash, Condition(function Slash_Condition)) call TriggerAddAction(gg_trg_Slash, function Slash_Actions) endfunction

It also a clear sign of you making this in GUI and convert it to JASS.

And nobody going to name a function like this.

function Trig_Untitled_Trigger_001_Func00100200

Thanathos said:
Here we have another omnislash, but not very well made
I´ve some complainments about the code:

1. Replace IsUnitDeadBJ(SomeUnit) with GetWidgetLife(SomeUnit) > 0

2. You used some other BJ which can be evaded

3. Get Rid of the TSA

4. ATM your spell is a bit hard to configurate i think, you could add some constants to make it easier

5. That code is hardly readable, do some better indention and add some free lines

And i also noticed if there are some dead units near the caster the spell somtimes bugs...instead of for example 10 slashes the caster slashes only 2 or 3 times

Cheezeman said:
Hey, to be a commonly uploaded DotA spell this isn't very bad, after all it's MUI.
I'm not saying it's good, but it isn't crap.
Anyway here are things I found:

temp_loc is never nulled

temp is only sometimes nulled

blinkEffect and targetEffect are never nulled

Coding:

set blinkEffect = AddSpecialEffectLoc("Abilities\\Spells\\NightElf\\Blink\\BlinkTarget.mdl", GetUnitLoc (caster)) call DestroyEffect (blinkEffect)
can be replaced with:
call DestroyEffect( AddSpecialEffectLoc("Abilities\\Spells\\NightElf\\Blink\\BlinkTarget.mdl", GetUnitLoc (caster)))
Thus avoiding the two variables that wern't nulled.

In first If statment (in the loop) there's an empty "else", just remove it

Uses alot of short TriggerSleepAction() which might cause obscure bugs. If you can, replace it with a Timer.

Replace the IsUnitDeadBJ( GetFilterUnit() ) with GetWidgetLife( GetFilterUnit() ) < 0.405. It's faster and more reliable.

This is a minor issue, but I suggest you use exitwhen count <= 0 instead of == 0, cause if the CPU calculates alot of stuff and happens to "miss" the exitwhen count == 0, you're garantueed that it will still exit (just giving you an additional target)

Improvements:

Setup section? Currently you have to change 3 params if you get another rawcode for the spell. It would be alot more userfriendly

I hope it helps. If you're confused just ask, I'm here to help not judge.

Deuterium said:
Well I won't check, but I'd say something:
I've seen some very well done omni-slashes, making this useless to anyone.
I'm not trying to offend you in any way, but spells made for practice, shouldn't be posted here...

I have fixed many things of your comments, i think not all yet tho.

Super-Sheep · Jul 28, 2009

You should set movement speed to 0 while Omnislashing or something like that. Its stupid that you can walk a little after every slash. :l

Thanathos · Jul 28, 2009

[offtopic]
Wow this is a mega post^^
Put the quotes in hidden tags...

Roflcoptor · Jul 28, 2009

Super-Sheep said:
You should set movement speed to 0 while Omnislashing or something like that. Its stupid that you can walk a little after every slash. :l

This would be a very novice way to do so....

I'd suggest pause instead

Super-Sheep · Jul 28, 2009

Well it disables the whole hero then.

Thanathos · Jul 28, 2009

Yeah but if you set the movement speed to 0 that doesn´t really mean it´s 0. Every unit has a minimal movement speed. You can´t set the unit movement speed under that value, not even with triggers..(I´ve expierienced this by one of my experiments). Pausing would be the best way aslong you unpause the unit when the spell is done.

Roflcoptor · Jul 28, 2009

OFC it disables the whole hero, but what does the hero during this slah phase, which would cause a bug if you pause him?

Ironside · Jul 28, 2009

Alright the vote is on: pause or other metod

But i'd vote for other metod, since in dota the hero isn't paused either.

Roflcoptor · Jul 28, 2009

Yeah i don't know why you should pause or stop him anyway, even in dota it is possible, that yurnero attakcs enemys while slashing. So the best possibility is to add something, that whenever the caster receives an order, he instantly receives to order to attack the current target

Ironside · Jul 28, 2009

Nah i think it's eventualy ok,
He moves fast enouf, if you move him in the time or so is your prob.

Roflcoptor · Jul 28, 2009

Well, I finally got to test this ingame.

Some things to mention: If you copy something do it good:
-In DotA hero becomes invulnerable
-In DotA attachment stays all the time. Just add the attachment outside the loops and then remove it at the end, and you will have that fancy red "stripe" following him.
-I think the interval is lower.

I think the minimum for TSA's is 0,27

EDIT: One thing I missed with the dota stuff: In DotA it's a traget unit ability
EDIT2: Two more things: First the caster doesn't stop when he is dead, second is the animation. In DotA he plays the slam anim, which looks much better.

Thanathos · Jul 28, 2009

Rofl and we should mention the caster gets unpickable (not by adding locust swarm ability) during the slashing... (tested it in Dota v6.60)

Super-Sheep · Jul 29, 2009

Thanathos said:
Rofl and we should mention the caster gets unpickable (not by adding locust swarm ability) during the slashing... (tested it in Dota v6.60)

Fixed in 6.61... And he can use items while Omnislashing.

Or do you mean unpickable by enemies or the player?

Thanathos · Jul 29, 2009

Super-Sheep you´re right about the 6.61....well in that version the caster gets neither paused nor movement reduction...I think it´s the same as in this version of omni slash so i guess we´re finished with that pause or not problem.

What i meant with unpickable was just, if you pick the hero during omnislash it gets immedeatly unpicked (probably by a trigger or smth).

Ironside · Jul 29, 2009

Roflcoptor said:
Well, I finally got to test this ingame.

Some things to mention: If you copy something do it good:
-In DotA hero becomes invulnerable
-In DotA attachment stays all the time. Just add the attachment outside the loops and then remove it at the end, and you will have that fancy red "stripe" following him.
-I think the interval is lower.

I think the minimum for TSA's is 0,27

EDIT: One thing I missed with the dota stuff: In DotA it's a traget unit ability
EDIT2: Two more things: First the caster doesn't stop when he is dead, second is the animation. In DotA he plays the slam anim, which looks much better.

Fixed so that you can set either the caster should get invuernable or not (by default he is), changed to slam animation, now is a target unit spell (goes on the target unit first)
As for the fire misle on sword, i made it but even i used the call DestroyEffect thing, it still didn't get removed, so had to delete it.

Ironside · Jul 29, 2009

Anymore comments & suggestions ?

Dethadow · Jul 31, 2009

Hey guys try casting omnislash and bladestorm at the same time

Ironside · Jul 31, 2009

I didn't disable it since by DotA as i remember, you can do that too...

Super-Sheep · Jul 31, 2009

Barathrum said:
I didn't disable it since by DotA as i remember, you can do that too...

No. You cant cast spells while Omnislashing, but you can use items.

Thanathos · Jul 31, 2009

Simply cast silence on the caster...this will disable the spell abilities but not the item abilities

Ironside · Aug 10, 2009

Well but i was thinking, i kind of like it more if he can cast spells, it looks funny

Rmx · Aug 10, 2009

Try the ability incernate ? of fire Lord.. this should silence the caster

while omnislashing ...

Super-Sheep · Aug 10, 2009

Incieriate is orb. I assume that you meant Soul Burn.

Rmx · Aug 10, 2009

Ya soul burn .. stupid me

i never used it

Hocus · Aug 16, 2009

Guys i need help ... i downloaded this spell how can i import this to map????

Ironside · Aug 26, 2009

Hocus, copy paste the triggers, the variables will be auto created, then just need a spell in object editor, you can use mine, and your done.

Hocus · Sep 5, 2009

Bara do u can create mini map with omnislash i will only copy this skill.Pls man i'm amator :>.And you'll send me on [email protected]

Cheezeman · Sep 6, 2009

We're all amatures...

Hocus · Sep 7, 2009

Bara u wrote in first message : add my spell but this is a problem how can i add your spell

Omnislash JASS Spell 1.3

Omnislash JASS Spell (Map)

Moderator

Moderator

Similar threads