12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

20:15, 15th Apr 2010
Dr Super Good:
A brief view of your spell has revealed quite a few problems which would prevent it from being approved.

The major problem is with the system AI, it is unresponsive and poor. Melee summons need to be infront of range heroes as they move while ranged ones should be the same level. Secondly this is a spell when the idea should rather have been a system for efficency (maybe a person wants to use it more than once while keeping duplicate code down).
You also lack multi level support, which all spells must have.

As for the code. . .
The JASS version is seriously wrong, leaking handle indexes due to not nulled local handles at the end of the function which still retain a removed object (locations is most noticable). It also uses BJ and GUI like structures which are not acceptable as they do nothing useful (just waste time).
The GUI version is ok as far as I can see, next to the pointless globals.

The JASS version needs a total rewrite while the GUI needs to be improved so the spell provides more useful mechanics.

I seriously advise making a system for this and using a few spells as a demonstration rather than a specific spell.

Simple,but could be useful ^^
Though i noticed that you can spawn minions from dead minion corpses which means you can't lose minions,is that intentional?

thath's just in the testmap, if you use the standard minion units (the skelletons maybe) then you cant, because they don't leave corpses

but good ideaat the next version I fix that ^^

In JASS version there are too many BJs.
Null locations (better don`t use them, use x/y instead). Use local trigger. This can be done after variable declaration Don`t use waits.

GUI
Don`t use waits.

• Set Boneminion_Spawn = No unit

No need to null global variables. Also there is no need to declare global variables

• Custom script: local unit udg_Boneminion_Caster

Like for now that`s all. I didn`t have time to test this in-game so I cannot tell more.

I'm sorry but i dont know how to use no waits (I can use a periodic trigger but I've problems wih recycling indexes)

finaly in the spell selection

gj but you did some mistakes

for example:

• Set Boneminion_Loc = (Position of Boneminion_Caster)

and inside the if you remove it. BUT if the number in the group is 0 the location will never removed. the same with the unit group

Isn't this just like the ability that necromancers have...?

Yes but it should lower the micromanergment you have to perform with them (like the necro in diablo II where the minions can not be microed). However it does so rather poorly, infact it is vurging on better to just control them manually. It does have a use, however, as your minions will atleast all follow you so no risk of one being left behind. Next to that your better ordering them around yourself to attack so they take the damage not your hero.

i think it is very useful, because when you have a Arrow Key Control you can´t see your minions if they are behind you. 3/5



sry for bad english ^^