[tr]

You need to rethink the logic with which units are added to the group in the cast trigger. Also rather than setting life, make the caster deal damage.

Also, this indexing is really simple and potentially horrendous. I don't know why this
style is still being promoted.

The indexing works like this:

Unit casts spell; MaxSize is now 1,
Unit casts spell; MaxSize is now 2,
The first spell finishes, so when the loop starts it iterates over the empty first spell and
then gets to 2.

Now, if the spell overlapped several times, then you are looping over even more
finished spells until you can get to the working ones.

So here's the worst kick with the indexing - if the spells are always being cast, always
overlapping each other, it's doomed. You'll be looping over dozens, then hundreds then
thousands of instances waiting to get to the active ones, then you'll hit index 8191 and
your "MUI" system will completely and utterly fail.

Therefore, you want to use one of the following to make sure this does NOT happen:

Hanky's Dynamic Indexing: http://www.hiveworkshop.com/forums/spells-569/gui-dynamic-indexing-template-144325/

Hashtables: http://www.hiveworkshop.com/forums/...9/complete-beginners-guide-hashtables-197381/

Or Unit Indexer: http://www.hiveworkshop.com/forums/spells-569/gui-unit-indexer-1-2-0-2-a-197329/

13oot-Me,
[1] It's more like burning the mana rather than draining the mana
[2] The loop will turn on everytime when the spell is cast when there are other still active
[3] Ineffective MUI system as Bribe said.

Bribe, I guess it's easier for new MUI learner though. :3

Jay the Editor said:

Bribe, I guess it's easier for new MUI learner though. :3

Click to expand...

Unit Indexer would be the easiest for a new learner IMO. I don't care if he uses hashtables
or hanky's indexing either, but this old system should only be for personal use and not for
public resources due to its issues.

Unless anyone has not covered this not to sure , My bad

But when you use the indexing event;
Dont you normally use ;

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Index1 Equal to 0
  • Then - Actions
    • Trigger - Turn on <gen>
  • Else - Actions

Instead of having it later on in the trigger;
This allows it to detect if any instances of the spell are running?
Then in the second trigger, as i see you do, it turns if off if no one is using the spell;
I think thats right?

Evilcrizpy

I am trying to change the indexing to Hanky's dynamic indexing, but running into a couple problems. Here is my progress.

13oot-Me said:

I am trying to change the indexing to Hanky's dynamic indexing, but running into a couple problems. Here is my progress.

Click to expand...

Ahhh okay;
Possibly for new users like your self look into bribes Unit Indexer;
Unit Indexer
and then look to my spell;
Cloud spiral
For ideas on how to use the Unit indexer into creating spells;
Would be a greater idea, till you understand the use of recycling.

Evilcrizpy

Jay the Editor said:

It's more like burning the mana rather than draining the mana. Ineffective MUI system as Bribe said.

Click to expand...

I made it so that the mana is drained from the targeted units and added to the caster so it's more like drain now. Also, I changed the indexing by using bribes unit indexer.

Spell now runs and works smoothly

13oot-Me said:

I made it so that the mana is drained from the targeted units and added to the caster so it's more like drain now. Also, I changed the indexing by using bribes unit indexer.

Spell now runs and works smoothly

Click to expand...

Shall test it once i get chance to download it;
But from the triggers it looks abit better.
Could do with some polishing off the triggers
Rating 3.5/5
Evilcrizpy

Edit :

Scrap that, just add remove MB_Caster from spell group,
then check if it is empty, and if true destroy spell group.

@EvilCrizpy, ah ok that makes sense, and less variables to work with Thanks for the feedback by the way!

Made the changes below.

• Unit Group - Remove MB_Caster[MB_TempKey] from MB_DamageGroup[MB_TempKey]
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (MB_SpellGroup is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

13oot-Me said:

@EvilCrizpy, ah ok that makes sense, and less variables to work with Thanks for the feedback by the way!

Made the changes below.

• Unit Group - Remove MB_Caster[MB_TempKey] from MB_DamageGroup[MB_TempKey]
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (MB_SpellGroup is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

Click to expand...

No no from the MB_SpellGroup,
and do that trigger outside of the pick all units in MB_SpellGroup
Also i was wrong my bad
dont turn off the trigger after checking just, destroy MB_SpellGroup if it is empty, still using the index to turn off trigger,
But i guessyou can do that way
Less triggers

Oops, I thought I did use MB_SpellGroup. So I should put the trigger below on the top of the actions?

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (MB_SpellGroup is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

Spell looks alot better now,
runs smoothly, Idea is quite nice;
Could be useful for hero maps such as AOS.
Improving my rating to 4/5

Bribe, nope. When I start to learn MUI, I found this old indexing system is easier to understand the concept of how a spell trigger run in MUI. For a new learner, they probably find it harder in understanding custom scripts in your Unit Indexer. :3 Anyway, at least the editor of this spell (Mind Blast) starts to learn Hanky's dynamic indexing system. I guess it's all solve :3

@Jay the Editor, actually I ended up using Bribes Unit Indexer after all. But yes, it was pretty easy to understand the old indexing system.

Well the spell is looking alot bettter now;
Bribes Unit Indexer, can be useful if you know how to use it and i would recommend it for new users, cause it saves them with actual indexing;

However,
Obviously this can change for some people, people find Indexing easier than Bribes Unit Indexer.

That's good :3 Bribe's Unit Indexer is great~

It does do the job;
And the more people use it,
The better, will give a different amount of variety between styles of triggered systems/spells.

Updated the spell!

The idea is good

anything u use twice or more should be stored into a variable and the variable should be used. example: u use picked unit a lot. store it into a tempUnit variable.

i also dont like all the groups u create and destroy by doing it this way. thats more of an opinion. this can be done without all the unit groups and just use an array indexed method.
u also wouldnt need bribes indexer if u dont use the groups.

- No need for MB_Caster[MB_TempKey] = No unit, and alike
- No need for Remove MB_Caster[MB_TempKey] from MB_SpellGroup during cast time
- Greater than or equal to >>> Greater than
- Save the ability level during cast time not in the loop
- The pick magic immune and unit is dead should be filtered at out at casting time or check if magic immune is false and unit is alive then do the damage
- Effects should be configurables

setting variables that may not be used for a while to null is a good idea IMO. if its going to be used again soon then theres no point but its better to null IMO

But it will slow the code and less efficient, one who's not using the spell yet is nulled when it's already nulled...

its really the ops choice for that one lol. it doesnt slow it enough to matter unless they null it at the wrong times.

13oot-Me I have found a bug here. It is when you cast Mind Blast spell on any unit that has a spell of Spiked Carapace or Thorns Aura, it will cause you do deal the damage equal to the target unit that have been damaged.