• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

Judgement Strike [Paladon]

I know, you waited for it.

I proudly present
Judgement Strike
[vJass]

This spell is dedicated to Eccho, Eleandor, Hanky and Dynasti who helped me to get my JNGP working properly.
This spell is created due to a Spellchallenge between Dynasti and me.
A great additional credit goes to Dynasti who taught me the usage of structs.

Judgement Strike
Uses arcane powers to throw a unit over the hero dealing damage in an area upon impact.
Level 1 - Deals 75 impact damage in an area and additionally 8% of the travelled distance in direct damage to the target.
Level 2 - Deals 150 impact damage in an area and additionally 16% of the travelled distance in direct damage to the target.
Level 3 - Deals 225 impact damage in an area and additionally 24% of the travelled distance in direct damage to the target.


*Fixed a leak in the Background System (not spell-related).
*Fixed a couple of smaller flaws.
*updated to work with the current Wc3 patch



Keywords:
Magic, Arcane, Blood, Telekinesis, Spell, Force, Gravity,
Contents

Judgement Strike (Map)

Reviews
23:15, 2nd Jun 2009 hvo-busterkomo: The scripting was pretty good, and the effect was nice, too. My only complaints are the ones I posted earlier today (see my post), before I was able to moderate this.

Moderator

M

Moderator

23:15, 2nd Jun 2009
hvo-busterkomo:
The scripting was pretty good, and the effect was nice, too. My only complaints are the ones I posted earlier today (see my post), before I was able to moderate this.
 
Level 25
Joined
Jun 5, 2008
Messages
2,572
Wow from GUI to vJASS directly....
Anyway i am sure everyone is gonna miss you GUI spells but i have nothing against JASS...
Again a nice idea and great gfx...
Maybe adding more documentation in the future?

[offtopic]
Zog it i was so lazy, i could have learned JASS myself by now if i wasn't just sooooo lazy...
 
Level 25
Joined
Jun 5, 2008
Messages
2,572
Oh yeah i forgot the rating...
What can i say, did at least 1 of your spell got a rating below 5?
I see no point to break the chain so 5/5 from me +rep.

[offtopic]
I know basics about structs,scopes,private functions and so on, i wanted to learn how to implement a parabola function in my JASS spell and now i have a good example how to.
You can expect my JASS spell for 1-2 weeks depending on the school and my free time.
Best of luck on your challenge and your future spells^^
 
Level 15
Joined
Jul 19, 2007
Messages
618
hmm really impressive for first vJass spell. I must say that some parts of code are indeed fast (using always one timer event if there are more casts) thats always my stile of coding and i like it. Again its really awesome for first (jass and vjass spell). I think you now understand how vJass is much easier then jass to learn and thats what i was always talking about. I also wish you best of luck to learn how to properly code in vJass using structs (as OOP), making fully leakless code, improve efficiency as such, ofc that will come with time your to good for beginner and i respect that.

Ill rate this 5/5 and +rep!
~Dark Dragon
 
Level 30
Joined
Dec 6, 2007
Messages
2,228
Thank you all.

@Rmx, Pala, Jack:
I am thinking about adding a GUI and a vJass version to all my future spells.
You are free to choose then :)

Asgard, try to open the map in your JassNewGen Editor and instantly hit the test button without opening any trigger/object editor. It may work then.

This is nice. Even if its Jass your still tne GUI and MUI. Remember that?

The god and the master... LOL! xD
nero, i won't forget that :p
 
Level 14
Joined
Oct 18, 2008
Messages
599
u ppl really overrate paladon spells, everytime i see a spell made by paladon everyone gives it a 5/5 just because its from paladon i bet atleast 50% of those comments are from ppl who didnt even dl the spell lol, but i must admit paladon is the Best spell maker but really overrated.
 
Level 10
Joined
Jan 14, 2006
Messages
160
u ppl really overrate paladon spells, everytime i see a spell made by paladon everyone gives it a 5/5 just because its from paladon i bet atleast 50% of those comments are from ppl who didnt even dl the spell lol, but i must admit paladon is the Best spell maker but really overrated.

I don't get that sentence, if he is the best, why is he overrated? If someone (in your eyes) is the best in smth he deservs an A+.

Edit: Thx Paladon, it worked now. Great Spell and the autocast works pretty fine. Indeed i would like the target to slide a bit, so 4.8/5 from me :)
(Overall this equals a rating of 5 of course)
 
Level 40
Joined
Dec 14, 2005
Messages
10,532
It was decent, but had some problems. A few I noticed:

  • (minor) why bother initializing RectMinX/RectMaxX/(etc) when you set them again anyways?
  • Your AoE detection is not particularly well done - it doesn't take collision into account.
  • Why do you spam static methods without any point? (Just a taste thing)
  • Check if their life is >0, not >.405 (well, doesn't make a difference really, but still).
  • Another taste thing, not tends to be more readable than ==false.
  • You should really be using a create() method instead of GetValues.
  • You don't need to null globals.
  • What's with the badly inlined TriggerRegisterAnyUnitEventBJ? Just use said function.
  • Consider stunning the unit rather than pausing them - or at least make a boolean option. While this might conflict with dispel in some maps, it could be handy in others.
  • Doesn't take terrain height into account.
  • Why do you inline some constants like bj_RADTODEG and bj_DEGTORAD?
  • You needlessly convert to degrees then back to radians.
  • You don't need to null your trigger.
  • You don't seem to take flying/hover units into account for the arc.
 
Level 25
Joined
Jun 5, 2008
Messages
2,572
@Dynasti, Purple Poot
I don't see how can you have influence on someone's other opinion.
Paladon's decision should be his and not encouraged by others.
He is free to make GUI spells even if he knows JASS.
I don't see the problem here, only two user's telling the other to decide between GUI and JASS where there shouldn't be a choice.
I think JASS is efficent but less user friendly so by making JASS spells without GUI how do you expect newbies to learn? By strugling through tutorials and hundred of lines of codes?
This is my view, it isn't suposed to hurt somebody or make someone feel better it's my opinion and it stays like that.
 
Level 30
Joined
Dec 6, 2007
Messages
2,228
I know, especially since i tried to make something in Jass earnestly, that GUI sucks.
But as a lot of people know, i am just doing this for the users.
90% of my submitted spells were requests, thats one fact.
The other fact is, and i admit it, that i liked GUI before.

Well, spells which i've done without requests:
Judgement Strike (first submitted Jass/vJass spell, for a challenge)
Rockfall (Spells and Systems Mini Contest #17)
My Nature Pack, which is, honestly, bad (partially for the Spells and Systems Mini Contest #16)

3 spells out of 17.
 

Rmx

Rmx

Level 19
Joined
Aug 27, 2007
Messages
1,164
Well that is the problem with JASS if some visitor wants to download a spell and copy it and don't know shit about Trigers he will have trouble knowing what JNPG ( Jass new gen Pack ).

Stick to GUI Paladon plzzzz.
Anyway the spells u made in GUI i think they are way more efficient :p ( duhhh can't argue that there is alot enemys *JASSers* )
And also how can u leave such big history in GUI u made the Best systems ever !!!!!
and just leave in a flash :(

Anyway that's up to u ofc , and GUI sexy ;)
 
Level 40
Joined
Dec 14, 2005
Messages
10,532
What I mean to say, Paladon, is why bother making everything in Jass/vJass if you:

  • Limit yourself to GUI's restrictions.
  • Have to do them in GUI anyways.

Also, I really don't see why GUI only users find it so hard to implement Jass spells in their map. It isn't more than copy and paste and changing a few numbers which are commented enough for anyone to understand. Perhaps we need a tutorial, hmm...

But quite frankly, if someone doesn't "know shit about triggers" as Rmx put it, they are incapable of making a proper map with or without downloaded spells.

In general, I would suggest you do your spells in vJass, but if someone requests a spell and they want it GUI'd, there's no harm using GUI (assuming you are willing to put up with it, which you seem to be).

Kingz, yes, I do expect newbies to learn through experience and tutorials, and not through sifting through hundreds of lines of code - that won't help them.

Also, GUI is far less userfriendly if you know Jass (though it obviously is more userfriendly if you don't know Jass).

--

I don't want this into another GUI vs Jass debate where all I do is sit around dismantling strawmen (which is rather boring), so in the future in this thread I won't be referencing any GUI vs Jass stuff. You guys are welcome to continue if you want, but I suggest you don't take it seriously.
 
Level 6
Joined
Sep 13, 2008
Messages
261
I downloaded your spell and the map wouldn't load. I had to disable the PGSystem in your map for a game to start. What a shame too it looked like testing would have been more fun. Anyways good skill. If anyone else has problems just disable the PGsystem trigger before you test the map.

I'm running Warcraft 3 Frozen Throne patch version 1.23.
 
Top