Inventory v1.0.0.0.0.0.0.0.0.0.0.0.0

Moderator · Oct 22, 2011

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

9th Nov 2011
Bribe: Hiding and showing units for local players causes desyncs.

Store "(Player number of TempPlayer)" to a variable so you don't call it so many times.

In a custom script change "GetHandleIdBJ" to "GetHandleId" and "GetLastCreatedDestructable" to "bj_lastCreatedDestructable".

Your system is very very difficult to import because you have so many preplaced units which are dependent on this system. You can have that many units, fine, but you should generate them yourself via script so that all the user has to do is copy some object editor stuff and some triggers. No one should have to copy those <gen> units or regions from your physical map to make your script work.

Adiktuz · Oct 22, 2011

Wow, 500kb? and yeah, its now unknown who made those inventory gray icons...

btw, using All Players is totally fine, no need to set it to a variable..

I don't kinda like going thru GUI so I'll leave the trigger comments for those other guys...

And A HOW TO USE won't hurt...

one thing I hate in this? that you need to make the item models to be the same as the icons... IT LOOKS TOO WEIRD having item icons on the floor...

and for me, its not that user friendly (to the one making the map)...

Switch33 · Oct 22, 2011

one thing I hate in this? that you need to make the item models to be the same as the icons... IT LOOKS TOO WEIRD having item icons on the floor...

I kinda like the idea; I've been watchin him make the inventory over a while. The thing is icons work a lot better if you alpha the icon so it really looks like a claw/sword or wtever when in inventory or on ground without an extra model. And that trigger is seperate from the whole system so you could just disable that one trigger so items are regular.

Adiktuz · Oct 22, 2011

Oh... Its hard to alpha it out coz you use different textures on just one model...

since you add a selection event for all the 12 players, why not just set it up directly on the selection trigger than using a code to add the selection event? Doing so would lessen the functions calls on your set-up trigger

And it seems that adding more than one ability per item would be a pain using this system, am I right?

another thing is that the unit shown on the char panel is static, I think it would have been way better if it matches the unit that is currently using the system...

and give credits to the maker of the Villager with many animations?

one last question since I'm not fond of checking GUI triggers, and I also cannot test it out with someone:
-->this only needs one of those inventory areas, and it will already work bugless for any player?

Noobsmoke · Oct 22, 2011

Name : Inventory v1.0.0.0.0.0.0.0.0.0.0.0.0
Isn't this spam ?

RakEnRoL · Oct 22, 2011

Haha

) I lol'd at the system name.
Oh well, I'm going to try it now.

Marsal · Oct 22, 2011

You forgot a .0

The_Witcher · Oct 22, 2011

Adiktuz said:
... its now unknown who made those inventory gray icons...

sure ? http://www.hiveworkshop.com/forums/spells-569/advanced-equipment-system-save-load-event-133727/

Adiktuz · Oct 22, 2011

you made them?

I'm think I saw them before I even your system... or it could be that I mistook them for something else...

The_Witcher · Oct 22, 2011

Adiktuz said:
you made them?

I'm think I saw them before I even your system... or it could be that I mistook them for something else...

I made them based on templates and the icons used there are those versions

but i agree that the original creator is unknown

Adiktuz · Oct 22, 2011

so that explains it... ^_^

maddeem · Oct 22, 2011

Adiktuz said:
Wow, 500kb? and yeah, its now unknown who made those inventory gray icons...

btw, using All Players is totally fine, no need to set it to a variable..

I don't kinda like going thru GUI so I'll leave the trigger comments for those other guys...

And A HOW TO USE won't hurt...

one thing I hate in this? that you need to make the item models to be the same as the icons... IT LOOKS TOO WEIRD having item icons on the floor...

and for me, its not that user friendly (to the one making the map)...

I was going to make a how to use, but hell, I'm lazy. I'll probably do that later today. As for using all players... that is totally fine. Cuz it only uses units that use the inv spell. As for the size, this was from a map I was working on, I didn't have time to remove everything lol I'll do that soon =p

Oh oh I'll be adding stacks soon enough...

Adiktuz · Oct 22, 2011

as in item stacks?

maddeem · Oct 22, 2011

Yes. Meh actually not. As you have to use an item to put it in your inventory.. No, I wont add stacks. Forget what I said earlier lol

Adiktuz · Oct 22, 2011

I think you could do the stacks just via the hashtable or arrays that ur using, then maybe just show the number of stacks in the multiboard... though you would need to add a note that all items should be charged... then if the unit takes it out, set the item charges to the stack value and vice versa...

Pharaoh_ · Oct 22, 2011

This resource crashes my editor when I try to open it.
Rename the spell to v1.0.

Adiktuz · Oct 22, 2011

It opens on my editor without problems...

btw, how easy for the user would it be to add more slots to this?

maddeem · Oct 22, 2011

Hmm... Probably would take about..
Uhh For a person who doesn't know what this does... (everyone here cuz I didn't explain in much) it would take about 2 hours to figure it out. Once figured, it would take like 1 min to add an extra slot.

Magtheridon96 · Oct 23, 2011

maddeem, it's a standard to use this format for version numbers:
0.0.0.0

0.0.0.0: Unofficial version
1.0.0.0: First release

Adding a 1.0.0.0:
- Changed API (Breaks backwards compatibility)
- Major Changes

Adding a 0.1.0.0:
- Many changes and additions
- Bug fixes

Adding a 0.0.1.0:
- Many small modifications

Adding a 0.0.0.1:
- Anything miscellaneous (Modifying a few lines maybe)

edit

I checked out your triggers...
I think it's time for you to move to Jass

Sorry for the OT, but your GUI-code made me realize this:

Unreadable Jass = Nestharus
Unreadable GUI = maddeem

lol.

Maybe if you place comments and increase the variable name lengths,
your code would look better

Also:
- Always cache stuff into variables if you're going to repeat it more than once. ALWAYS.

Adiktuz · Oct 23, 2011

Maggy said:
Unreadable GUI = maddeem

lol.

Maybe if you place comments and increase the variable name lengths,
your code would look better

though GUI comments aren't that much readable too...

the only thing good in this is that its certainly usable by GUIers...

maddeem · Oct 23, 2011

Magtheridon96 said:
maddeem, it's a standard to use this format for version numbers:
0.0.0.0

0.0.0.0: Unofficial version
1.0.0.0: First release

Adding a 1.0.0.0:
- Changed API (Breaks backwards compatibility)
- Major Changes

Adding a 0.1.0.0:
- Many changes and additions
- Bug fixes

Adding a 0.0.1.0:
- Many small modifications

Adding a 0.0.0.1:
- Anything miscellaneous (Modifying a few lines maybe)

edit

I checked out your triggers...
I think it's time for you to move to Jass
Sorry for the OT, but your GUI-code made me realize this:

Unreadable Jass = Nestharus
Unreadable GUI = maddeem

lol.

Maybe if you place comments and increase the variable name lengths,
your code would look better

Also:
- Always cache stuff into variables if you're going to repeat it more than once. ALWAYS.

Yeah the v1.0.0.0.0.0.0.0.0.0.0.0.0 was a joke =p
Sadly though the only way I could get a complete stranger to understand how to use this would be to put more comments then code xD
But I will do comments.... Soon. It is easy atm to add items though, just about 6 lines of code xD which is in the setup

Adiktuz · Oct 24, 2011

and maybe make it easier to add more than one ability per item?

maddeem · Oct 25, 2011

Adiktuz said:
and maybe make it easier to add more than one ability per item?

You can add 5.

Noobsmoke · Oct 26, 2011

Adiktuz said:
and maybe make it easier to add more than one ability per item?

Use a spellbook :vw_wtf:

Orcnet · Nov 3, 2011

this gui reminds me of Ghosthruster's inventory spell but might check it for future use or so

jxtranghero · Nov 4, 2011

How do the tornado appear in the inventory?

maddeem · Nov 9, 2011

Hiding and showing units for local players causes desyncs.

Not if the player cant select or interact with the unit, and in this system the locally hidden units can do neither. And to back this up, I have tested this in multilayer, many times. No problems or dysncs.

-Kobas- · Apr 8, 2012

You should make jass/vjass version of this. It's cool btw.

maddeem · Apr 8, 2012

Definitely, looking back now I realize that this is so inefficient xD
But if I were to make it vjass, it could never be better then archon's

-Kobas- · Apr 8, 2012

maddeem said:
Definitely, looking back now I realize that this is so inefficient xD
But if I were to make it vjass, it could never be better then archon's

Wrong it can be better

I made one with just a little above 200 lines of code and I have 29 slots all together.
Items and other shits can be displayed with Custom Window or floating texts instead of multiboard. Few imported libraries can save some time as well.

gorillabull · Apr 16, 2012

Items and other shits can be displayed with Custom Window or floating texts instead of multiboard

actually its quite easy (but a lot of work) to make dynamic tooltips, im suprised no one has made this yet. thanks to jnpg you can make very long destructible tooltips which when hovered over will display like:

the tooltips will bug if they are too long i dont know why
oh btw this is ghost's system im using

-Kobas- · Apr 16, 2012

gorillabull said:
actually its quite easy (but a lot of work) to make dynamic tooltips, im suprised no one has made this yet. thanks to jnpg you can make very long destructible tooltips which when hovered over will display like:
-image-
the tooltips will bug if they are too long i dont know why
oh btw this is ghost's system im using

Actually I made that as well.

Maker · Apr 16, 2012

gorillabull said:
actually its quite easy (but a lot of work) to make dynamic tooltips, im suprised no one has made this yet.

For a while I thought you had come up with a method to easily change the tooltip based on item stats. I was excited. But by saying "dynamic" you don't mean changing the tooltip on the fly I suppose.

Please guys, don't post or quote very large images without hidden tags.

-Kobas- · Apr 16, 2012

We all know that wc3 programmers was lazy enough to forget/allow us to edit tooltips with code.
The only way is to create list of tooltips on different objects and then just link them with array or some other way (levels, custom value etc) so we can display them on the screen.

gorillabull · Apr 16, 2012

yea -kobas- is right a dynamic tooltip would have to be something like floating text with string variables in it but that wont look as good as the above tooltips

Inventory v1.0.0.0.0.0.0.0.0.0.0.0.0

Inventory v0.0.1 (Map)

Moderator

Moderator

Similar threads