Awaiting update
- Joined
- May 26, 2009
- Messages
- 1,829
There's some pretty glaring issues with the submission discounting the description though that too is an issue the description should contain the following things as a minimum:
- Explanation of the submission (what the system does and is for)
- Code listings
- API (how to use the system)
- Version number of the system (should be attached to the map & the thread itself)
Your map is also poorly organized, the folder you're storing triggers is in just named "This is (not) a trigger", this should match the submission instead
There should be importing instructions included with the map (this could also be in the description)
The map shouldn't have the word "test" in it, as submissions aren't test pieces, it should match the submission name
I'm not sure if your description is asking for help to fix the system or some such (I don't understand "im new bie plz fix my map.") but at any rate this isn't the section for incomplete works or work you know is not approvable we have the trigger & scripts section for such things but I digress
Issues with the code:
- Only supports one player (this is listed in the "red me" comment
- Your triggers should have a prefix at least 3 characters long followed by a space (such as "HSS ") your variables should also reflect this except use an underscore ("HSS_")
- There is no configuration for this system
- Expanding the system requires adding more triggers specifically 1 more for every new hero - which makes this feel more like a tutorial piece than an actual system (systems ought to be expandable via adding array indexes and changing other configurables and nothing more)
- Store reused references in temporary variables (you do this a lot with (triggering player) and (triggering unit)
- Don't use waits (Trigger Sleep Action) as they are inaccurate
- What's with the multiboard functions? they serve no purpose from what I can tell (and even if they did it wouldn't work for multiple players)
- Your system makes referenced to pre-placed units, this isn't good it would be better if the hero selection table were generated by the code and then were referenced that way instead
Also keep test triggers like map explanations and whatever else in a separate folder - people don't want to import text being added to their map when they want a system
- Explanation of the submission (what the system does and is for)
- Code listings
- API (how to use the system)
- Version number of the system (should be attached to the map & the thread itself)
Your map is also poorly organized, the folder you're storing triggers is in just named "This is (not) a trigger", this should match the submission instead
There should be importing instructions included with the map (this could also be in the description)
The map shouldn't have the word "test" in it, as submissions aren't test pieces, it should match the submission name
I'm not sure if your description is asking for help to fix the system or some such (I don't understand "im new bie plz fix my map.") but at any rate this isn't the section for incomplete works or work you know is not approvable we have the trigger & scripts section for such things but I digress
Issues with the code:
- Only supports one player (this is listed in the "red me" comment
- Your triggers should have a prefix at least 3 characters long followed by a space (such as "HSS ") your variables should also reflect this except use an underscore ("HSS_")
- There is no configuration for this system
- Expanding the system requires adding more triggers specifically 1 more for every new hero - which makes this feel more like a tutorial piece than an actual system (systems ought to be expandable via adding array indexes and changing other configurables and nothing more)
- Store reused references in temporary variables (you do this a lot with (triggering player) and (triggering unit)
- Don't use waits (Trigger Sleep Action) as they are inaccurate
- What's with the multiboard functions? they serve no purpose from what I can tell (and even if they did it wouldn't work for multiple players)
- Your system makes referenced to pre-placed units, this isn't good it would be better if the hero selection table were generated by the code and then were referenced that way instead
Also keep test triggers like map explanations and whatever else in a separate folder - people don't want to import text being added to their map when they want a system
