12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.

14:21, 30th May 2011
Maker:
Make the number of rocks configurable, it can cause lag because of 34 dummies per cast.
EQ RemoveChunks should be turned on/off.
Remove the extra and, it generated unneeded code here:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • EQ_CreateChunks Equal to True
        • EQ_RemoveChunks Equal to True

Make the caster damage enemies, currently the dummies deal the damage.

Maker, 14.07.2011
Causes some serious fps drop even on a good computer when casted on the same spot on two units a few times. It's the terrain deformations.

Picture isn't best, and i forgot to post triggers so Triggers are here :
It's my first time to do spell with indexing
AND Now Changeables
And i again, i hope you like my spell/system.
TRIGGERS UPDATED TO 1.03!!!!!!!

You mispelled destructibles. 1/5....... XD lol jk
Triggering looks good, but you leaked one thing.
You should destroy the locations before you turn on the loops in the EQ Casting trigger.

Testing...

I like the spell!
[+] MUI
[+] Good Triggering
[+] Somewhat Original
[+] Easy to Implement
[+] No leaks (almost)

5/5

One more thing. I'm most probably wrong, but in the second loop trigger (EQ Loop 2), i suggest you use the variable EQ_Loc[3] instead of EQ_Loc[2]. I think it could cause bugs since both loops are constantly overwriting that variable. (am i right or not?)

Good work! Looks so sxy, best 10/5

You learned a bad way of indexing. The indexing will not recycle and will keep on looping dead instances which drops performance. Then when the indexing reaches 8191 + 1 it will stop working as it's the maximum array size (8191 or maybe it is 8190 with [0] counted).

Some nice tutorials.

Link 1 Link 2 Link 3

Ty baassee would add recycle +rep
And ty you all

The spell looks good, although it doesn't look like an earth made tremor, its more like a fire based spell. but still good, +rep dude!

Thank you,You also can expect, "To do" list, done, cause it's nearly done and Recycling system too
Edit : Recycling system done. Now spell is castable, and there will be no indexing problems. PS: Don't say me that it works bad when you cast it twice at same time, with an unit, cause those and this spells are done to be with Cooldown
Knockback would be added later...
Chunks dissapear over time : Done
New changeables!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Now you can change 3 effects, clap effect, dust effect, and effect when chuck dissapears.
Now you can turn on off, damage of chunk, when it is destroyed, and damage that it would do
Magtheridon96 like he said, i fixed points, on Cast trigger
Now just to edit main post

looks cool... ^_^

well, test it

Hjuj, ty, i'll fix em. And i forgot to destroy group +rep And about what Art duration, but there in no art duration??? where's that?

Wow! You actually listened to me
You leak nothing.
Your spell is MUI.
It has a lot of configurable options.
Damn, i wish i had put you a score of 4/5. This way i can show you my rating changed to 5/5.
You deserve rep for this spell

NEW UPDATE!!!! 1.02!
Now one more cool effect!
Now when you let string to empty string, it won't create any effect.
Fixed everything what maker said, expect destroying all destructibles and bridges and that caster gets gold, i mean seriusly that's not needed, dummy is yours, he can't get exp, so you get whole exp, and get whole gold ...
MORE CHANGEABLES
now you can turn on/off removing chunks
When Deformations are turned off, now every destroyed chunk, creates a little hole, it's temporary so you don't need to care about it :d
-----------------------------------------
Now when deformations are on, caster gets knockedback (a little, so he can't go down in rat hole ) <-- Removed Works bad :/
Now Deformations won't affect YOU!!!! Cause spell starts in front of you with little offset

its laggy, and creates fatal error. when spammed at the same location.

i guess you need to pick only living destructibles. +__+ (it only says pick every destructible of type rocks)

razor21, First that spell is not created to make fatal errors!!! And it's created to be used with Cooldown!!!!! Second about destructibles you're telling whole time, ofc that it destroys every destructibles in wave. Third, learn more about triggering and then talk about how and what should i edit. Seriusly!
Fourth - "(it only says pick every destructible of type rocks)" Learn about this, It says, Pick every destructible in point with X , Y. And then PICKED DESTRUCTIBLE NOT EQUAL TO CHUNK!!!!!!

razor21 said:

its laggy, and creates fatal error. when spammed at the same location.

i guess you need to pick only living destructibles. +__+ (it only says pick every destructible of type rocks)

Click to expand...

It's not weird when you think about it. It creates a terrain deform every 0.03 second + picks dead dests + loads of effects + creating lots of destructables "chunks".

Still a spell should work flawless with or without cooldown, seriously take the constructive criticism.

hmmm, i know what you want to say baassee, and what razor21 wanted to say, i taked all constructive criticism from all, but he said so many wrong things, and this spell can be changeable! read it, add or remove whatever you want, don't use all effects, if string is empty, no effect would be created (wont even create)... i'll see, what i can change, but about crashing, THAT'S TOTALY WRONG, i mean why do you cast spell at same location, and what's point of casting spell thousand times...
Baassee, i'll fix that what you said, cause you're friendly i guess XD no seriously i'll fix it (Idk but my spell doesn't laggs )

Yeah I know. Reading is a big issue in this world. Yet if it crashes there must be something wrong. Although it can be the amount of effects.
Doesn't lagg for me neither.

fine, what i meant is,

try casting the same spell at the same location 4x.

the first wave is okay, it works just fine,
but the second wave, it creates a damn lag, because they pick the same destructibles which is already dead, multiple times. within "100" of EQ_Loc[4].

picking at x,y? it just pick destructibles within 100 of a dummy killed with expiration timer.

wrong? is picking only living chunks wrong?

what happens when there is 4 rock chunks at the same location?
the first wave, the rock is killed, it works normally.
the second time, it picks the rock of the 2nd skill cast, and the "Dead" Rock from the first wave, causing the trigger to work "Twice".

and at the 4th time, the trigger run 4 times for all the "Dead" chunks. (Including the damage trigger when the rock is dead, it run 4x, coz it counts the dead chunks too.) get the logic?.

• Destructible - Pick every destructible within 100.00 of EQ_Loc[4] and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Destructible-type of (Picked destructible)) Equal to EQ_ChunkType
      • Then - Actions
        • Destructible - Kill (Picked destructible)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • EQ_CreateEffects Equal to True
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • EQ_EffectGroundChuckDestroyed Not equal to <Empty String>
              • Then - Actions
                • Special Effect - Create a special effect at EQ_Loc[4] using EQ_EffectGroundChuckDestroyed
                • Special Effect - Destroy (Last created special effect)
              • Else - Actions
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • EQ_MakeDeformations Equal to True
          • Then - Actions
            • Environment - Create a 3.00 second Temporary crater deformation at EQ_Loc[4] with radius 70.00 and depth 45.00
            • Environment - Stop (Last created terrain deformation) over 3.00 seconds
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • EQ_ChunksDoDamageAfterDeath Equal to True
          • Then - Actions
            • Set EQ_ChunkEnemyGroup = (Units within 100.00 of EQ_Loc[4] matching ((((Matching unit) belongs to an enemy of (Owner of (Dying unit))) Equal to True) and ((((Matching unit) is hidden) Equal to False) and (((Matching unit) is Magic Immune) Equal to False))))
            • Unit Group - Pick every unit in EQ_ChunkEnemyGroup and do (Actions)
              • Loop - Actions
                • Unit - Cause (Dying unit) to damage (Picked unit), dealing EQ_ChunksDamage damage of attack type Spells and damage type Normal
            • Custom script: call DestroyGroup(udg_EQ_ChunkEnemyGroup)
          • Else - Actions
      • Else - Actions

you should check if the destructible within 100 of EQ_Loc[4] is alive, what you did was just picking every Destructibles, of type rock chunks, within 100 range of the dying location of the dummy. don't tell me you don't know, that it picks "DEAD" Destructibles too, imagine the trigger running for the "DEAD" Destructibles, what would happen?. it would run the whole thing for the "DEAD" Variable existing in the same location too.

you can simply add another condition can't you? to fix this.
like this

• Destructible - Pick every destructible within 100.00 of EQ_Loc[4] and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Destructible-type of (Picked destructible)) Equal to EQ_ChunkType
        • ((Picked destructible) is alive) Equal to True
      • Then - Actions
        • Destructible - Kill (Picked destructible)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • EQ_CreateEffects Equal to True
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • EQ_EffectGroundChuckDestroyed Not equal to <Empty String>
              • Then - Actions
                • Special Effect - Create a special effect at EQ_Loc[4] using EQ_EffectGroundChuckDestroyed
                • Special Effect - Destroy (Last created special effect)
              • Else - Actions
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • EQ_MakeDeformations Equal to True
          • Then - Actions
            • Environment - Create a 3.00 second Temporary crater deformation at EQ_Loc[4] with radius 70.00 and depth 45.00
            • Environment - Stop (Last created terrain deformation) over 3.00 seconds
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • EQ_ChunksDoDamageAfterDeath Equal to True
          • Then - Actions
            • Set EQ_ChunkEnemyGroup = (Units within 100.00 of EQ_Loc[4] matching ((((Matching unit) belongs to an enemy of (Owner of (Dying unit))) Equal to True) and ((((Matching unit) is hidden) Equal to False) and (((Matching unit) is Magic Immune) Equal to False))))
            • Unit Group - Pick every unit in EQ_ChunkEnemyGroup and do (Actions)
              • Loop - Actions
                • Unit - Cause (Dying unit) to damage (Picked unit), dealing EQ_ChunksDamage damage of attack type Spells and damage type Normal
            • Custom script: call DestroyGroup(udg_EQ_ChunkEnemyGroup)
          • Else - Actions
      • Else - Actions

then run the trigger, it works a lot better, look how much lag does it reduce.
and how much correction does it made. the spell now will not damage the unit 4x of the original chunks dead damage, when there is multiple "DEAD" Chunks around.

what happen when you stack more "DEAD" Destructibles? it damages the same unit with the total "Chunks damage x Total number of dead destructibles within 100 range within dying dummy positioin". isn't that crazy? it multiplies my 2nd wave damage each time i cast the spell on the same location !, i can use this "Glitch" To own the whole game.

if you don't agree with this, picking only "Alive" Chunks,

you should ve assigned each dummy to each chunks.
so that it only kills "Specific" Chunks when the "Specific" Dummy died.

If you still don't know what i am talking about, re-read every sentence i wrote.

I understand it first time when baassee explained it, but about casting spell with same unit twice, it would bug it anyway, i know, that's why i said, CAUSE it ADDs unit to group. I'll fix it for tommorow.

I see spam of special effects :S and maybe add spell description

Huh I'm kind of back to modding again cause i couldn't let this spell not get approved because of 2-3 things not fixed. T H I S I S U P D A T E D ! ! ! ! ! ! ! !

some that i found:

and for best, i would suggest you to remove the option for Terrain Deformation, as it has been known to cause lag and possible desync in game.

and when you reason with this:

razor21, First that spell is not created to make fatal errors!!! And it's created to be used with Cooldown!!!!!

Click to expand...

if your ability/spell is limited by cooldown, it doesn't MUI after all.

What a ? about integer idk where it even is and it's not that big deal. about terrain deformations... srsly i added boolean Deformations On/Off...
And WT* Are talking about cooldown ? Please check spell and then give comment, or read what we were talking about. It's said that it gives critical error if you spam map... ofc it would do something bad if you cast 1 spell 1000 times on same place... and it is MUI so pls if you got something good to say, say it, if you wanna flame keep it up to you. And about telling what is mui and what it isn't, have you even check triggers ?
Edit : I'm sorry if it sounds agressive...

88WaRCraFT3 said:

about terrain deformations... srsly i added boolean Deformations On/Off...

Click to expand...

i said, i suggest you to remove the option for terrain deformation, not just able to turn it off. the reason is explained already.

88WaRCraFT3 said:

It's said that it gives critical error if you spam map... ofc it would do something bad if you cast 1 spell 1000 times on same place...

Click to expand...

the fact is, if you spam a spell, it will cause a massive lag and fps reduction at most, but then if your spell have nothing wrong, it would be normal again when all instances of the spell ends.
and now someone says that sometimes it gives critical error, its an indicator that something is wrong with your spell trigger. and its your job to find and fix it.

88WaRCraFT3 said:

and it is MUI so pls if you got something good to say, say it, if you wanna flame keep it up to you. And about telling what is mui and what it isn't, have you even check triggers ?

Click to expand...

yes i do have check the triggers, but the point that i want to bring is:
a MUI spells is capable of being spammed many times without large drawback.
yet you imply that:

razor21, First that spell is not created to make fatal errors!!! And it's created to be used with Cooldown!!!!!

Click to expand...

the fact that your spell instance is limited by cooldown. means it is not fully multiinstanceable.
or in simple words, even if you set the cooldown to 0, it should still work perfectly.

if necessary, i suggest you to try some approved spells in Spells section that has been deemed to be MUI. and try spam them ingame for references.

i already got MUI spell man. About Cooldown, i said that not because of criticals, i said that because of FPS losing. And IT DOESN'T GIVES A CRASH!!!!!!!!!!!!! maybe it gave crash because he/she razor done something wrong with him self or because of uughgh long spell casting but spell like spell would never give crash i tested it in MP... and yes it ofc gives FPS back to normal after casting, and even if you gave rapid rage at spell casting!!! and you really use that stupid for defence "razor21, First that spell is not created to make fatal errors!!! And it's created to be used with Cooldown!!!!!" :S i already answered for it

88WaRCraFT3 said:

About Cooldown, i said that not because of criticals, i said that because of FPS losing. And IT DOESN'T GIVES A CRASH!!!!!!!!!!!!! maybe it gave crash because he/she razor done something wrong with him self or because of uughgh long spell casting but spell like spell would never give crash i tested it in MP... and yes it ofc gives FPS back to normal after casting, and even if you gave rapid rage at spell casting!!! and you really use that stupid for defence "razor21, First that spell is not created to make fatal errors!!! And it's created to be used with Cooldown!!!!!" :S i already answered for it

Click to expand...

hmmm i see, then i'm sorry for those argument,

[offtopic]

[/offtopic]

:S kind of true... But i hate when someone says so many wrong words and doesn't even wants to get point of that what somebody is saying. And i was busy and mad :S now i'm fine and i am working on new spell Lightning Cage

• Set EQ_Integer1 = 0
• Set EQ_Integer1 = (EQ_Integer1 + 1)

This should be changed to:

• Set EQ_Integer1 = 1

And also, instead of Configuring everything at 0.03 seconds, you should do it at Map Initialization :3

Ty mustard ok but what configures are at 0.03 ? cause all of em i posted on difrent trigger..

ah, a Terrain Deformation spell That doesnt work for maps like mine, with a lot of doodads it will make major lag. But nice effects, triggering and documentation 4/5

lol
I meant you should change the trigger that runs at 0.03 game time to run at Map Initialization

aider, ty
Magtheridon96, i still don't understand :S pls post that trigger, and now i go to fix other things you said.
EDIT : Found it, You meant time elapsed ty a lot
Gonna upload fixed map.
UPLOADED I didn't post triggers but i writted what i changed.

@88Warcraft3: I believe that Magtheridon96 is talking about trigger 5 (or "EQ Changeables") he is refering to the fact that trigger is firing every 0.03 seconds when you only need to fire it on map initialization (because all your settings only need to get set once, because the values don't change) then after that you only need to READ the settings not WRITE them.

Good work BTW, 4/5 (I'm definately not a fan of GUI... and it'd run a hell of alot faster being JASS only... so I can't say 5/5, sorry ).

i Already fixed that with melee initialization, ok 4/5 good enough can't wait for moderation :S how much it takes for moderator to review spell ?

@88WaRCraFT3:
About a few more months
The mods have lives too you know =P (I don't have a life, so maybe I should be in charge of the spells section )

LOL, i know they do but i've send him PM, and he also was active when i've send him it and much more days after it