[GUI] Item Set System 1.4.1

Moderator · Jan 21, 2015

14:37, 17th Feb 2015
IcemanBo: Works as intended. http://www.hiveworkshop.com/forums/...stem-gui-1-3-a-261702/index2.html#post2654436

00:5, 03th Feb 2015
IcemanBo: http://www.hiveworkshop.com/forums/spells-569/item-set-system-1-2-a-261702/#post2648304

12:52, 25th Jan 2015
IcemanBo: Needs Fix upon request.

Wietlol · Jan 21, 2015

None

1.0 - zv27
1.2 - IcemanBo
1.3 - IcemanBo - Approved

Upcoming release:

No current ideas. Feel free to give suggestions.

Vinz · Jan 22, 2015

Nulling triggers in JASS: http://www.hiveworkshop.com/forums/...erting-gui-into-efficient-jass-233227/#Step 4

Then you can call the function directly instead of running the trigger since it's nulled.

Nice job though.

zv27 · Jan 22, 2015

Very good. 4/5

One small suggestion:

All this can be only one function

JASS:

function Trig_ISS_Set_Abilities_Actions takes nothing returns nothing
    //Requires:
    //    - ISS_Index
    //    - ISS_Ability[]
    //    - ISS_Ability_Number
    //    - ISS_Tooltip[]
    
    local integer i = 0
    call SaveInteger(udg_ISS_Hashtable, udg_ISS_Index, 0, udg_ISS_Tooltip)
    loop
        exitwhen i > udg_ISS_Ability_Number
        call SaveInteger(udg_ISS_Hashtable, udg_ISS_Index, i + 1, udg_ISS_Ability_Array[i])
        set i = i + 1
    endloop
endfunction

//===========================================================================
function InitTrig_ISS_Set_Abilities takes nothing returns nothing
    set gg_trg_ISS_Set_Abilities = CreateTrigger()
    call TriggerAddAction(gg_trg_ISS_Set_Abilities, function Trig_ISS_Set_Abilities_Actions)
endfunction

function Trig_ISS_Set_Items_Actions takes nothing returns nothing
    //Requires:
    //    - ISS_Index
    //    - ISS_Item_Type[]
    //    - ISS_Item_Type_Number
    
    local integer i = 0
    loop
        exitwhen i > udg_ISS_Item_Type_Number
        call SaveInteger(udg_ISS_Hashtable, udg_ISS_Item_Type_Array[i], 0, udg_ISS_Index)
        set i = i + 1
    endloop
endfunction

//===========================================================================
function InitTrig_ISS_Set_Items takes nothing returns nothing
    set gg_trg_ISS_Set_Items = CreateTrigger()
    call TriggerAddAction(gg_trg_ISS_Set_Items, function Trig_ISS_Set_Items_Actions)
endfunction

also this

JASS:

function Trig_ISS_Add_Stack_Actions takes nothing returns nothing
    //Requires:
    //    - ISS_Unit
    //    - ISS_Item_Type
    
    local integer unitid = GetHandleId(udg_ISS_Unit)
    local integer index = LoadInteger(udg_ISS_Hashtable, udg_ISS_Item_Type, 0)
    local integer level = LoadInteger(udg_ISS_Hashtable, unitid, index)
    local integer abilityid = LoadInteger(udg_ISS_Hashtable, index, level + 1)
    local integer tooltip = LoadInteger(udg_ISS_Hashtable, index, 0)
    
    if index == 0 then
        return
    endif
    
    call SaveInteger(udg_ISS_Hashtable, unitid, index, level + 1)
    
    if GetUnitAbilityLevel(udg_ISS_Unit, tooltip) > 0 then
        call SetUnitAbilityLevel(udg_ISS_Unit, tooltip, level + 1)
    else
        call UnitAddAbility(udg_ISS_Unit, tooltip)
    endif
    
    if abilityid != 0 then
        if GetUnitAbilityLevel(udg_ISS_Unit, abilityid) > 0 then
            call IncUnitAbilityLevel(udg_ISS_Unit, abilityid)
        else
            call UnitAddAbility(udg_ISS_Unit, abilityid)
        endif
    endif
endfunction

//===========================================================================
function InitTrig_ISS_Add_Stack takes nothing returns nothing
    set gg_trg_ISS_Add_Stack = CreateTrigger()
    call TriggerAddAction(gg_trg_ISS_Add_Stack, function Trig_ISS_Add_Stack_Actions)
endfunction

function Trig_ISS_Remove_Stack_Actions takes nothing returns nothing
    //Requires:
    //    - ISS_Unit
    //    - ISS_Item_Type
    
    local integer unitid = GetHandleId(udg_ISS_Unit)
    local integer index = LoadInteger(udg_ISS_Hashtable, udg_ISS_Item_Type, 0)
    local integer level = LoadInteger(udg_ISS_Hashtable, unitid, index)
    local integer abilityid = LoadInteger(udg_ISS_Hashtable, index, level)
    local integer tooltip = LoadInteger(udg_ISS_Hashtable, index, 0)
    
    if index == 0 then
        return
    endif
    
    call SaveInteger(udg_ISS_Hashtable, unitid, index, level - 1)
    
    if GetUnitAbilityLevel(udg_ISS_Unit, tooltip) > 1 then
        call SetUnitAbilityLevel(udg_ISS_Unit, tooltip, level - 1)
    else
        call UnitRemoveAbility(udg_ISS_Unit, tooltip)
    endif
    
    if abilityid != 0 then
        if GetUnitAbilityLevel(udg_ISS_Unit, abilityid) > 1 then
            call DecUnitAbilityLevel(udg_ISS_Unit, abilityid)
        else
            call UnitRemoveAbility(udg_ISS_Unit, abilityid)
        endif
    endif
endfunction

//===========================================================================
function InitTrig_ISS_Remove_Stack takes nothing returns nothing
    set gg_trg_ISS_Remove_Stack = CreateTrigger()
    call TriggerAddAction(gg_trg_ISS_Remove_Stack, function Trig_ISS_Remove_Stack_Actions)
endfunction

Not necessarily, but as for me it would be much more efficient
As I've already said it is only a suggestion

And just one more thing
Also could be avoided constantly calling the same function

Trigger - Run ISS Set Abilities <gen> (ignoring conditions)

Trigger - Run ISS Set Items <gen> (ignoring conditions)

I have a similar system that works exactly as I suggested.

Wietlol · Jan 22, 2015

@Mythic
"I actually have no idea what the hell you are talking about.
I also dont understand what nulling triggers has to do with the fact that I should know what events, conditions and actions are. Wrong link?"
Never mind that. I just read a little bit further and saw what you meant.
I will do that in the next update.
If I want to call those triggers, I cannot apply this am I right?

@zv27
- First one yes, I could have done that.
It was made like this because of the way how I started making this stuff.
- Second one... I don't understand what you meant.
Add or remove stacks are never done at the same time.
- Because I use arrays to set the data, I have to call that for every single item set. I could indeed as you said put the save items and save abilities in one trigger so every item set would only have one "Run (Trigger)" action instead of 2.
- BTW: Nice that you also have a system that works exacly as you suggested but then uploaded it in the spell section of the hive on your account... I cannot find it.

One last thing:
I just read some stuff about using conditions instead of actions in JASS and it sounds logic:
-----------------------------------
Event: Trigger is called.
If (All conditions are true) then
Run all actions.
-----------------------------------
Event: Trigger is called.
Run all conditions.
-----------------------------------
Logic enough for me.
But there is one thing that bothers me. One guy said that conditions handle wait timers different than actions.
Is that true and what difference is that then?

EDIT: Now I am confused:
If I use TriggerExecute() and "Run Ignoring conditions" (the same) is there any way actions can be slower than conditions when using TriggerEvaluate() and "Run Checking conditions"?
I know that regular events are still slower but how about that?

Also is it necessary to set hashtable values to null/0/false?

Almia · Jan 23, 2015

You can even combine all of those Jass scripts in a single trigger. Trigger execution is done not in a whole code but it is done with only the handle.

Also, It is much faster to evaluate than to execute, Triggers executed are first evaluated then...executed obviously.

And it is not actually necessary to set hashtable values to null

You should also turn this:

Hashtable - Create a hashtable
- Set ISS_Hashtable = (Last created hashtable)

to this:

Custom script : set udg_ISS_Hashtable = InitHashtable()

this way, it will be much faster.

You should also seperate the demo trigger from the initialization/configuration trigger.

Wietlol · Jan 23, 2015

Almia said:
Also, It is much faster to evaluate than to execute, Triggers executed are first evaluated then...executed obviously.

That is not true:

JASS:

function ConditionalTriggerExecute takes trigger trig returns nothing
    if TriggerEvaluate(trig) then
        call TriggerExecute(trig)
    endif
endfunction

TriggerExecute() is called without TriggerEvaluate().
ConditionalTriggerExecute is faster if you use conditions instead of actions and that action is called when an event fires.
So with events, it is faster. With custom call it is not or negligible.

In fact conditions might be slower because you have to filter them before it runs.

Almia · Jan 23, 2015

Wietlol said:
That is not true:

JASS:

function ConditionalTriggerExecute takes trigger trig returns nothing if TriggerEvaluate(trig) then call TriggerExecute(trig) endif endfunction

TriggerExecute() is called without TriggerEvaluate().
ConditionalTriggerExecute is faster if you use conditions instead of actions and that action is called when an event fires.
So with events, it is faster. With custom call it is not or negligible.

In fact conditions might be slower because you have to filter them before it runs.

TriggerEvaluate reads the condition afaik, so it is faster. So if you have a block of code in the condition function, it will be executed before it runs the Actions.

Wietlol · Jan 28, 2015

Update 1.2

I just released version 1.2

Here are the changes:

Now all code is inside one trigger. Functions can be called using global variables.

IcemanBo · Feb 2, 2015

Code seems to be okay all in all. Still:

Local agents need to be nulled. unit in your case. Fix it.
TriggerCondtion could be used over TriggerAction in your case.
In JASS you write your own functions. One positive point with it is,
you can change the name to your needs.
function Trig_ISS_System_Add_Stack_Actions
... it works just fine, but such names are unnecessarily long. ->
function AddStack ... would do just fine. I would change it.
You do not have to null triggers, that are never destroyed.
Though it is not a bad habit to do so, but it's useless.
Currently you split item and ability registration and have to run two triggers.
It would also make sense for me just to make all settings (abilities + items),
and then call like a "RegisterItemSet" trigger that will handle both: ability + item registration.
Though it would cut one not needed trigger. Think about it.
The ISS Init trigger should be moved in the system folder, as it obvisouly belongs to the system.

Usage of the system seems fair and useful. It is nice that you care much of documentation of your code.

Wietlol · Feb 3, 2015

IcemanBo said:
TriggerCondtion could be used over TriggerAction in your case.

You should explain that to me.
I understand that

JASS:

function ConditionalTriggerExecute takes trigger trig returns nothing
    if TriggerEvaluate(trig) then
        call TriggerExecute(trig)
    endif
endfunction

Is slower than
native TriggerEvaluate takes trigger whichTrigger returns boolean

but how can you ever know that
native TriggerEvaluate takes trigger whichTrigger returns boolean
is faster than

native TriggerExecute takes trigger whichTrigger returns nothing

???

When you create a trigger with an event, you should use conditions, ok.
When you create a trigger without an event and is only called via triggers, I actually believe that actions could be faster. At least you got the possibility to add another action to it.

Take a look at this:

This is how I would make the triggerEvaluate and triggerExecute. (I would make new threads ofcourse for catching exceptions but that would not make a difference between the two functions.
If Blizzard wrote those natives properly, the TriggerExecute will always be faster than TriggerEvaluate (and safer)

So either I am wrong (and Blizzard can go back to school) or TriggerExecute is faster than TriggerEvaluate.
Which one is true?

(If they are equal as fast than TriggerExecute has one less character and thus saves one character in code length... Now I am being too precise

)

IcemanBo said:
You do not have to null triggers, that are never destroyed.
Though it is not a bad habit to do so, but it's useless.

I only null a local variable... which must be nulled right?

IcemanBo said:
In JASS you write your own functions. One positive point with it is,
you can change the name to your needs.
function Trig_ISS_System_Add_Stack_Actions
... it works just fine, but such names are unnecessarily long. ->
function AddStack ... would do just fine. I would change it.

So... Here is the deal:
Someone wants to have item sets in his game and uses my system... ok.
Then he also wants to have a system where units have stackable abilities (or whatever).
The system he uses for the stacking abilities also has a function called AddStack()... Now you got 2 AddStack() functions... which JASS cannot handle.
I have been tought to make unique names for my functions so I use the regular Blizzard idea of placing "Trig_Trigger_Name_" before the function name...
I could remove the "_Actions" part but wont remove more than that... sorry.

IcemanBo said:
Local agents need to be nulled. unit in your case. Fix it.

Currently you split item and ability registration and have to run two triggers.
It would also make sense for me just to make all settings (abilities + items),
and then call like a "RegisterItemSet" trigger that will handle both: ability + item registration.
Though it would cut one not needed trigger. Think about it.

The ISS Init trigger should be moved in the system folder, as it obvisouly belongs to the system.

Will do.

IcemanBo · Feb 3, 2015

I did not mention it was a trigger execute call. You can just stay to it, it's fine.

"ISS_AddStack" would still improve it. You do not really need the "trig" + " actions" in the name.
Though you can stay to it if you want, it is just a suggestion.

Nulling triggers is a exception. Well, at least statics.
You will never destroy them, and things that are never removed/destroyed don't need to be nulled.
That is also the reason why players don't need to be nulled.

edo494 · Feb 3, 2015

they work a lot differently than you think.

The Virtual machine that runs Jass is not just as easy as that, triggeractions need to support wait, while triggerconditions doesnt, so that means there is some subtle difference between these.

Also, your code for conditions is wrong, since even if my condition returns false, it will evaluate all of them before deciding if it should run actions.

Disambiguate your function names, since Jass only has one scope, you can not declare things as private to certain scope, therefore you must make unique names for functions, and global variables for your system. Thats why everyone preplaces their system's things with shortcut of the system, e.g. DDS_stuff, CSS_stuff etc.

And no it may not be from system, but AddStack is very general, and the one that wants to use your system may already have function like this in his own code, and what is he going to do if he sees this? He will either change your function's name, which you should've done, or he will throw the system away.

Vinz · Feb 3, 2015

If I want to call those triggers, I cannot apply this am I right?

You can call the function. Except if it's a loop trigger that needs to be turned on/off, don't null the trigger.

Good job with the update.

Wietlol · Feb 3, 2015

Update 1.3

I just released version 1.3

Here are the changes:

Merged the Save_Set and Save_Ability triggers to one Create_Set trigger.
Function names are smaller.
Local variable leaks removed.

IcemanBo · Feb 17, 2015

All in all your code gets more readable and cleaner as I could see. Good job.

You could note your two examples as only "examples" in init trigger.

Usage is simple. System could be useful for RPG-like maps for example. Approved.

sniper_zero · Feb 17, 2015

Yay for approval!

Wietlol · Apr 1, 2015

Update 1.4

I just released version 1.4

Here are the changes:

Fixed double-buff-bug by adding buff removal and buff configuration.
Now automatically creates index numbers.
Fixed a few leaks and optimized code a bit.
Added condition to triggers for people who want to use TriggerEvaluate() instead of TriggerExecute().

jonbon29 · Apr 4, 2015

Nice item set system, really useful. Maybe I could use this system to my project.

Shaeam · Jul 9, 2016

Hey, I love your systems however I'm having trouble with this. I tried out the demo map and the elite set consistently bugs if you pick up all the pieces and then drop them to pick them up again.

Not sure why it does this but... It's unfortunate.

Wietlol · Jul 11, 2016

Nolyp said:
Hey, I love your systems however I'm having trouble with this. I tried out the demo map and the elite set consistently bugs if you pick up all the pieces and then drop them to pick them up again.

Not sure why it does this but... It's unfortunate.

Fixed it.

Shaeam · Jul 11, 2016

Wietlol said:
Fixed it.

Yet again; OP delivered.

Muchas gracias!

KILLCIDE · Nov 15, 2016

Sorry for the update. Just updating the tags.

filthy liar

3xKataratos · Mar 10, 2019

Wietlol thnx for the system is gr8 !!
The only problem i have is that you still getting set buff even if u pick the same item 3 times is there any way to fix that in a way that u have to pick different items in order to get set buffs.

Plz Help

[GUI] Item Set System 1.4.1

Just another Warcraft III map (Map)

Moderator

Moderator

Similar threads