Commander System v1.00

Moderator · Jun 19, 2013

13:25, 19th Jul 2013
PurgeandFire: Changes made! Approved. Cool system!

Xonok · Jun 19, 2013

Reserved.

Doomlord · Jun 19, 2013

http://www.hiveworkshop.com/forums/submissions-414/spell-submission-rules-230362/

Since you don't explicitly mention using Bribe's indexer, I presume that you use custom value and violate one of the rules.

Chaosy · Jun 19, 2013

1. leak in the init trigger
2. combine the two init triggers

else I cant find any flaws.

however, aint this system very limited, you know it's only useful in a low ammout of maps. but gj anyways 4/5

deathismyfriend · Jun 20, 2013

for efficiency and speed anything u use twice or more should be stored into a variable and u should use the variable. example u use picked unit a lot.

mckill2009 · Jun 20, 2013

- Compress your TroopInt and TroopConfig
- Pick units in palyable map area and make level equal to zero
- In TroopEnter and leave, put the other condition in the else part
- Counting units in a group is very slow, use integers instead, every unit that is added to a group, add it, then subtract if removed
- You dont need to null globals

Almia · Jun 20, 2013

@Doomlord
Actually, I think he is using a Unit Indexing system,because I can't see any Set Custom Value funcs.

Doomlord · Jun 20, 2013

Almia said:
@Doomlord
Actually, I think he is using a Unit Indexing system,because I can't see any Set Custom Value funcs.

I doubt so too. As I said he didn't mention the system anywhere so it is natural to suspect like that.

gorillabull · Jun 20, 2013

version 0?

Magtheridon96 · Jun 20, 2013

What Unit Indexer is this?

For GUI Resources, you should be using Bribes Indexer or any other approved Indexer on this site.

If you made your own, consider using Bribes. It's better for a resource to rely on external libraries. The reasons are countless and I have already explained this a million fucking times.

http://www.hiveworkshop.com/forums/2346203-post73.html
^Check the part in which I explain how making a system extend off another one is good.

Xonok · Jun 20, 2013

Doomlord said:
http://www.hiveworkshop.com/forums/submissions-414/spell-submission-rules-230362/

Since you don't explicitly mention using Bribe's indexer, I presume that you use custom value and violate one of the rules.

I forgot to mention the requirements.

Chaosy said:
1. leak in the init trigger
2. combine the two init triggers

else I cant find any flaws.

however, aint this system very limited, you know it's only useful in a low ammout of maps. but gj anyways 4/5

Which leak do you mean? I did fix one, but I'm almost sure you mean something else.
Combined.

Recently I thought of 2 map ideas that would require a system like this. It could be used for pets. Or it could be used for a wargame where assasinating a high-ranking officer causes chaos.
Later I'll add support for converting entire groups through commanders(take over commander and you take over everything he controlled)

deathismyfriend said:
for efficiency and speed anything u use twice or more should be stored into a variable and u should use the variable. example u use picked unit a lot.

Done.

mckill2009 said:
- Compress your TroopInt and TroopConfig
- Pick units in palyable map area and make level equal to zero
- In TroopEnter and leave, put the other condition in the else part
- Counting units in a group is very slow, use integers instead, every unit that is added to a group, add it, then subtract if removed
- You dont need to null globals

-Compressed.
-No. The conditions must stay separate, because a commander can also be a troop(chain of command).
-Made it keep track of how many units a group has, to avoid counting.
-Where?

Almia said:
@Doomlord
Actually, I think he is using a Unit Indexing system,because I can't see any Set Custom Value funcs.

Yep, Bribe's, but this works with pretty much any indexer.

gorillabull said:
version 0?

I will change version number to 1 when and if it gets approved.

Magtheridon96 said:
What Unit Indexer is this?

For GUI Resources, you should be using Bribes Indexer or any other approved Indexer on this site.

If you made your own, consider using Bribes. It's better for a resource to rely on external libraries. The reasons are countless and I have already explained this a million fucking times.

http://www.hiveworkshop.com/forums/2346203-post73.html
^Check the part in which I explain how making a system extend off another one is good.

Bribe's atm, but it's not necessary to use this one. Anything works really.

EDIT: Uploaded new version.

mckill2009 · Jun 21, 2013

-No. The conditions must stay separate, because a commander can also be a troop(chain of command).
-Made it keep track of how many units a group has, to avoid counting.
-Where?

- your method checks 2 every time, while mine checks only 1 time, if it returns false, it will go to the else part...
- the CountUnitsInGroup has a counter inside but it's too slow, best to have a counter directly, for efficiency's sake...
- Set UnitCommander[(Custom value of TempUnitB)] = No unit

Xonok · Jun 21, 2013

mckill2009 said:
- your method checks 2 every time, while mine checks only 1 time, if it returns false, it will go to the else part...
- the CountUnitsInGroup has a counter inside but it's too slow, best to have a counter directly, for efficiency's sake...
- Set UnitCommander[(Custom value of TempUnitB)] = No unit

- If I made it like this, then it would turn impossible to have a chain of command.
- Alright, this has been fixed.
- This is somewhat about clearing variables, but it also makes sure that the unit truly doesn't have a commander anymore, because elseway it could create problems(same unit owned by multiple commanders).

PurgeandFire · Jul 19, 2013

Sorry for the late review. This looks pretty good overall.

- You initialize CommanderTroopCount[] to 0 on initialization. Global integer arrays are already initialized as 0 when you first reference them.
- In "TroopLeave", you use "A unit leaves playable map area". That doesn't fire unless someone is moved into the black area on the edges of the map. You may have to use a deindex event or the event "a unit dies", or something similar (or perform checks if a unit exists in your group iterations or w/e)

Aside from that, everything has been pretty much said. It looks good.

Xonok · Jul 19, 2013

PurgeandFire said:
Sorry for the late review. This looks pretty good overall.

- You initialize CommanderTroopCount[] to 0 on initialization. Global integer arrays are already initialized as 0 when you first reference them.
- In "TroopLeave", you use "A unit leaves playable map area". That doesn't fire unless someone is moved into the black area on the edges of the map. You may have to use a deindex event or the event "a unit dies", or something similar (or perform checks if a unit exists in your group iterations or w/e)

Aside from that, everything has been pretty much said. It looks good.

-I'm not entirely sure if it's also like this in GUI; but in JASS it is not possible to increment an integer before setting it to a value, so I worked off of that assumption. (trying to read an unitialized integer gives 0, but the actual value would be null, so thread breaks)
-Leaves playable area is supposed to detect when a unit is removed from the game. If I make it use a deindex event, then I'll have to increase requirements a bit, but I guess it can be deemed worth it

deathismyfriend · Jul 20, 2013

in GUI. they are preset to 0 i guess would be the best to say. try it.

PurgeandFire · Jul 20, 2013

Xonok said:
-I'm not entirely sure if it's also like this in GUI; but in JASS it is not possible to increment an integer before setting it to a value, so I worked off of that assumption. (trying to read an unitialized integer gives 0, but the actual value would be null, so thread breaks)

You can, whether it is GUI or JASS. Non-array integers do not have a default value of 0 (which is why they crash), but array integers do. Just try it out, and it will work.

This is pretty handy to know for coding. Boolean arrays default false as well (just a random, handy tip).

Xonok said:
-Leaves playable area is supposed to detect when a unit is removed from the game. If I make it use a deindex event, then I'll have to increase requirements a bit, but I guess it can be deemed worth it

I wish it did. :\ Anyway, at the moment it is up to you whether you want to supplement that part. I was just telling you that it does nothing at the moment (unless a unit is moved outside the playable map area). If you don't want to have a deindex event, then you can probably find some makeshift way to detect if a unit has been removed. For example, when you are doing the "Pick every..." actions, you can just check if the unit's ID is equal to 0. If so, then it was removed/dead/ or w/e and needs to be removed from the group. (There are other methods as well.. its handle ID will be 0, its race's handle ID will be 0, etc.)

Xonok · Jul 20, 2013

PurgeandFire said:
You can, whether it is GUI or JASS. Non-array integers do not have a default value of 0 (which is why they crash), but array integers do. Just try it out, and it will work.

This is pretty handy to know for coding. Boolean arrays default false as well (just a random, handy tip).

I wish it did. :\ Anyway, at the moment it is up to you whether you want to supplement that part. I was just telling you that it does nothing at the moment (unless a unit is moved outside the playable map area). If you don't want to have a deindex event, then you can probably find some makeshift way to detect if a unit has been removed. For example, when you are doing the "Pick every..." actions, you can just check if the unit's ID is equal to 0. If so, then it was removed/dead/ or w/e and needs to be removed from the group. (There are other methods as well.. its handle ID will be 0, its race's handle ID will be 0, etc.)

Alright. Changes made now. There's still some borderline cases like resurrection/animate dead, but I am not yet sure how to fix them.

nambo · Nov 10, 2013

This system very good for my map.

I guess my map is one of the rare maps using this system.
Thanks, Xonok! ^^

Xonok · Nov 10, 2013

nambo said:
This system very good for my map.
I guess my map is one of the rare maps using this system.
Thanks, Xonok! ^^

It's a bit outdated though. GroupControl will have most of the functionality this has.

Commander System v1.00

Commander System v1.0 (Map)

Moderator

Moderator

Similar threads