Bradwarden spell pack v1.00

Moderator · Aug 30, 2013

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Bradwarden spell pack v1.00 | Reviewed by Maker | 29th Sep 2013

NEEDS FIX

	Fix the leaks You should use Starts the effect of an ability event
	Things that leak Spell Submission Rules

[tr]

Rheiko · Aug 30, 2013

post the triggers here, please

Andser · Aug 30, 2013

How can i post triggers???

Rheiko · Aug 30, 2013

go to your world editor => trigger editor => your trigger =>left click on the mouse at your trigger's name => right click on the mouse => copy => go to this thread => click the update button => go to your description => then [trigger]Paste your trigger here[/trigger]

Andser · Aug 30, 2013

I don't know why but it doesn't work, i have tried it before you said it but it doesn't work.
Is it because i use opera?

Rheiko · Aug 30, 2013

i use opera but it does work :slp:

Andser · Aug 30, 2013

I dont know why i cannot post triggers

Rheiko · Aug 30, 2013

i will check this tommorrow.. i cannot stand for this

Andser · Aug 30, 2013

I have it,

wrote manually now for the Double Edge xD.

Rheiko · Aug 30, 2013

lol, Review will catch up later...
:slp:

Manasurge · Aug 30, 2013

Just saying, your Return won't work right. Damage detection system would be required.

You should also use variables in the spells instead of bjs(casting unit etc.).

It leaks locations.

You also don't filter units hit by the spell. If I had a spell immune unit it'd still take damage from your Double Edge spell. Aswell as flying units.

You should put all values like damage and radius into variables in another trigger.
Example:

Double Edge Setup
Events
Map initialization
Conditions
Actions
Set DE_Life = 100
Set DE_Damage_Scaling = 75

Double Edge
Events
Unit - A unit Begins casting an ability
Conditions
(Ability being cast) Equal to Double Edge
Actions
Set DE_Casting_Unit = (triggering unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Life of DE_Casting_Unit) Less than (DE_Life + (DE_Damage_Scaling x (Real((Level of Double Edge for DE_Casting_Unit)))))

There's more but I've got to go make salad lol

Andser · Aug 30, 2013

Manasurge said:
Just saying, your Return won't work right. Damage detection system would be required.

The Return works right, it is like in dota, if i want i can make a DDS but the idea of the pack was "copy" them exactly as they are in DotA, in dota it damages when the attack starts not when the unit takes damage. Btw i am working on an absorb system with something like this return but i dont know how to make it MUI :ogre_frown:

Manasurge · Aug 30, 2013

Andser said:
The Return works right, it is like in dota, if i want i can make a DDS but the idea of the pack was "copy" them exactly as they are in DotA, in dota it damages when the attack starts not when the unit takes damage. Btw i am working on an absorb system with something like this return but i dont know how to make it MUI

I can't comment on the spell in DOTA but I'm positive you've not done it correctly. Afaik the event

Unit - A unit Is attacked

can be abused. I don't remember all the details but that's what I've been told.

deathismyfriend · Aug 30, 2013

please post all triggers in the description. Also use hidden tags.
http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

Andser · Aug 30, 2013

How abused?? do you mean that i should add the event through another trigger so it will not be triggered every time the unit is attacked?

Andser · Aug 30, 2013

deathismyfriend said:
please post all triggers in the description. Also use hidden tags.
http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

Ehm... thats all and thanks for the hidden tags.

deathismyfriend · Aug 30, 2013

How is this a spellpack with only one trigger ?

Also please don't double post instead hit the edit button on your last post.

As others have said change casting unit to triggering unit.
You leak locations and unit groups. Read the things that leak tutorial.
Anything used twice or more should be stored in a variable and the variable should be used.

Manasurge · Aug 30, 2013

Andser said:
How abused?? do you mean that i should add the event through another trigger so it will not be triggered every time the unit is attacked?

You can order the unit to attack, trigger detects this and fires, but then you order your unit to stop. Actual attack didn't take place, but the trigger will still run. It also doesn't check if unit attacking is spell immune etc.

Manoo · Aug 30, 2013

I think u should stop uloading these dota spells. Its absurd... I'm sure nobody gona use it, it's not creative and copying icefrog ideas.

deathismyfriend · Aug 30, 2013

Manoo said:
I think u should stop uloading these dota spells. Its absurd... I'm sure nobody gona use it, it's not creative and copying icefrog ideas.

This does not matter at all and is a pointless post.
If you aren't going to help or give a review then there is no point in posting.

Daffa · Aug 31, 2013

Necessary Fix
Make a setup
Remove Leaks

FUJI · Aug 31, 2013

Remove some leaky stuffs or read some tutorial submission here, Btw your spellpack it is so simple because the two spells are made in OE. I thought it was in 6.78c DotA that it's ultimate skill increase the heroes movement speed to max and enabling to walk on cliffs, destructibles and in units like turning off the collision.

Rheiko · Aug 31, 2013

he make the older version

FUJI · Aug 31, 2013

Rheiko said:
he make the older version

Yes

(.

Andser · Aug 31, 2013

I made the older version because DotA 6.78 wasn't released when i did it

, and i dont know how the hell use Hash so i can make it only for 1 unit not for every allies. (Stampede)

Manoo said:
I think u should stop uloading these dota spells. Its absurd... I'm sure nobody gona use it, it's not creative and copying icefrog ideas.

??? Nobody gonna use it? i think some people will use it, because they are lazy

and the "I think u should stop sploading these dota spells." sounds like i have already uploaded tons of them, btw this is my first dota spell on hive!

Daffa the Mage said:
Necessary Fix
Make a setup
Remove Leaks

As Deathismyfriends said, i will make it leakless and add a config (the config isn't here because it is from DotA and not my custom spell)
I would like to know if this is better and leakless, i used the spell 8192 times and the game didn't crashed.

Events
- Unit - A unit Begins casting an ability
Conditions
- (Ability being cast) Equal to Double Edge
Actions
- Set TempLoc = (Position of (Target unit of ability being cast))
- Unit - Cause (Triggering unit) to damage (Triggering unit), dealing (Edge_Base_dmg + (Edge_Scaling x (Real((Level of Double Edge for (Triggering unit)))))) damage of attack type Spells and damage type Normal
- Unit Group - Pick every unit in (Units within 190.00 of TempLoc) and do (Actions)
  - Loop - Actions
    - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        ((Picked unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True
      - Then - Actions
        
        Unit - Cause (Triggering unit) to damage (Picked unit), dealing (Edge_Base_dmg + (Edge_Scaling x (Real((Level of Double Edge for (Triggering unit)))))) damage of attack type Spells and damage type Normal
      - Else - Actions
- Unit - Create 1 Caster Dummy for (Owner of (Triggering unit)) at TempLoc facing Default building facing degrees
- Special Effect - Create a special effect at TempLoc using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
- Unit - Add ministun to (Last created unit)
- Unit - Add a 0.10 second Generic expiration timer to (Last created unit)
- Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp
- Custom script: call RemoveLocation(udg_TempLoc)

Now Return:
I spend 3 hours on it and i really don't know how to make it only from damage from attacks and not spells (because if a DoT ticks 10 times a second the caster receives high amount of damage, i've tried it with phoenix's fire ability, he got instantly killed)

Manasurge · Aug 31, 2013

Andser said:
I made the older version because DotA 6.78 wasn't released when i did it , and i dont know how the hell use Hash so i can make it only for 1 unit not for every allies. (Stampede)

??? Nobody gonna use it? i think some people will use it, because they are lazy
and the "I think u should stop sploading these dota spells." sounds like i have already uploaded tons of them, btw this is my first dota spell on hive!

As Deathismyfriends said, i will make it leakless and add a config (the config isn't here because it is from DotA and not my custom spell)
I would like to know if this is better and leakless, i used the spell 8192 times and the game didn't crashed.

Events

Unit - A unit Begins casting an ability

Conditions

(Ability being cast) Equal to Double Edge

Actions

Set TempLoc = (Position of (Target unit of ability being cast))

Unit - Cause (Triggering unit) to damage (Triggering unit), dealing (Edge_Base_dmg + (Edge_Scaling x (Real((Level of Double Edge for (Triggering unit)))))) damage of attack type Spells and damage type Normal

Unit Group - Pick every unit in (Units within 190.00 of TempLoc) and do (Actions)

Loop - Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

((Picked unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True

Then - Actions

Unit - Cause (Triggering unit) to damage (Picked unit), dealing (Edge_Base_dmg + (Edge_Scaling x (Real((Level of Double Edge for (Triggering unit)))))) damage of attack type Spells and damage type Normal

Else - Actions

Unit - Create 1 Caster Dummy for (Owner of (Triggering unit)) at TempLoc facing Default building facing degrees

Special Effect - Create a special effect at TempLoc using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl

Unit - Add ministun to (Last created unit)

Unit - Add a 0.10 second Generic expiration timer to (Last created unit)

Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp

Custom script: call RemoveLocation(udg_TempLoc)

Now Return:
I spend 3 hours on it and i really don't know how to make it only from damage from attacks and not spells (because if a DoT ticks 10 times a second the caster receives high amount of damage, i've tried it with phoenix's fire ability, he got instantly killed)

The unit group leaks. use this custom script before the "pick every unit" line to help that:

Custom script: set bj_wantDestroyGroup = true

Store Picked unit, triggering unit, owner of unit, last created unit, level of the ability and the radius of which you pick units in variables.

When you set owner of unit you can use triggering player if the triggering unit is owned by the player you want to set.

Your trigger improved:

Events
- Unit - A unit Starts the effect an ability
Conditions
- (Ability being cast) Equal to Double Edge
Actions
- Set TempLoc = (Position of (Target unit of ability being cast))
- Set TempUnit = (Triggering unit)
- Set TempPlayer = (Triggering player)
- Set TempLevel = (Level of Double Edge for TempUnit)
- Set TempRadius = 190.0
- Set TempSpellID = ministun
- Set TempDummyType = Caster Dummy
- -------- you should set this real in the same trigger you used to set Edge_Base_dmg and Edge_Scaling aswell as the dummy type and spell id --------
- Unit - Cause TempUnit to damage TempUnit, dealing (Edge_Base_dmg + (Edge_Scaling x (Real(TempLevel)))) damage of attack type Spells and damage type Normal
- Custom script: set bj_wantDestroyGroup = true
- Unit Group - Pick every unit in (Units within TempRadius of TempLoc) and do (Actions)
  - Loop - Actions
    - Set TempPickedUnit = (Picked unit)
    - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      - If - Conditions
        
        (TempPickedUnit is A structure) Equal to False
        
        (TempPickedUnit is A flying unit) Equal to False
        
        (TempPickedUnit is Magic Immune) Equal to False
        
        (TempPickedUnit is paused) Equal to False
        
        (TempPickedUnit is an illusion) Equal to False
        
        (TempPickedUnit is hidden) Equal to False
        
        (TempPickedUnit belongs to an enemy of TempPlayer) Equal to True
      - Then - Actions
        
        Unit - Cause TempUnit to damage TempPickedUnit, dealing (Edge_Base_dmg + (Edge_Scaling x (Real(TempLevel)))) damage of attack type Spells and damage type Normal
      - Else - Actions
- Unit - Create 1 TempDummyType for TempPlayer at TempLoc facing Default building facing degrees
- Special Effect - Create a special effect at TempLoc using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
- Set TempCreatedUnit = (Last created unit)
- Unit - Add TempSpellID to TempCreatedUnit
- Unit - Add a 0.10 second Generic expiration timer to TempCreatedUnit
- Unit - Order TempCreatedUnit to Orc Tauren Chieftain - War Stomp
- Custom script: call RemoveLocation(udg_TempLoc)

This isn't the optimal way of doing it but I tried to improve your coding to help you grasp the concept.

Rheiko · Aug 31, 2013

now i can see more clearly :ogre_haosis:

store owner of triggering unit into a variable
use this before pick every unit within...

Custom script: set bj_wantDestroyGroup = true

or

Set Group = (Units within 190.00 of TempLoc)
Unit Group - Pick every unit in (Units within 190.00 of TempLoc) and do (Actions)
Custom script: call DestroyGroup(udg_Group)

and why you damage your triggering unit :vw_wtf:

Andser · Aug 31, 2013

Rheiko said:
now i can see more clearly
store owner of triggering unit into a variable
use this before pick every unit within...

Custom script: set bj_wantDestroyGroup = true

or

Set Group = (Units within 190.00 of TempLoc)

Unit Group - Pick every unit in (Units within 190.00 of TempLoc) and do (Actions)

Custom script: call DestroyGroup(udg_Group)

and why you damage your triggering unit

thx for the help, i will update it tomorow and it damages because this:
The Centaur summons a tremendous amount of inner strength and releases a very powerful attack. It can only be done at melee range, and it damages both the Warchief and the enemy units around the target.
tooltip from dota.

Rheiko · Aug 31, 2013

oh yeah, i forgot.. it's been a long time since i playing DotA..

Andser · Aug 31, 2013

want to play with me ?

Daffa · Sep 1, 2013

Set the Configurable ones (in this case, the radius) at another trigger that run upon Map Init.
also, use a variable for the spells :

Set Double_Edge = Double Edge

then replace this :

(Ability being cast) Equal to Double Edge

with :

(Ability being cast) Equal to Double_Edge

as this will make configurating much easier.

as for Return, using a DDS can help detecting the physical damage [preferred LFH's]

Wrda · Sep 4, 2013

You don't need a stupid "return damage" ability triggered, use Thorns Aura. Spells made on OE won't be approved unless they are made with perfection.

Andser · Sep 5, 2013

I made it in Trigger editor because it increases by strength and the thorns aura is % return.

T. D. W. · Sep 16, 2013

Review

Suggestions

Rating

Judgement

My Words

Double Edge does not trigger cooldown if target died because of the spell
Hoof Stomp is basic
Return is easy spell, no wow in here
Ulti is blizzard made, so nothing much here too

Unit Group - Pick every unit in (Units within 190.00 of (Position of (Target unit of ability being cast))) and do (Actions)

You leak a group here ^

Work harder and more

If You want me to review an Update of This Spell, Please Notifiy me this by VM or PM