Arcania Zero v0.03

Moderator · Sep 13, 2009

19:14, 4th Oct 2009
TriggerHappy187:

Review.

The spell is good enough without those improvements, but they are improvements nonetheless, so please consider using them.

YourNameHere · Sep 13, 2009

Aready seen it, and the scripting is pretty nice. The idea is good and the visuals are ok, too. All in one a pretty neat spell.

Kricz · Sep 13, 2009

Stupid, that you've not enogh time for the second spell^^

But i like this spell

Deuterium · Sep 13, 2009

Ok I always like that your spells have an extra something

Anyways:

JASS:

//Duration of the ability, should be the same for the spell
private function SET_DURATION takes nothing returns nothing
    set DURATION[1] = 5.00
    set DURATION[2] = 6.00
    set DURATION[3] = 7.00
    set DURATION[4] = 8.00
    set DURATION[5] = 9.00
endfunction

//Suck AoE
private function SET_AOE takes nothing returns nothing
    set AOE[1] = 500.00
    set AOE[2] = 600.00
    set AOE[3] = 700.00
    set AOE[4] = 800.00
    set AOE[5] = 900.00
endfunction

//Damage on collision
private function SET_DAMAGE_COLLISION takes nothing returns nothing
    set DAMAGE_COLLISION[1] = 50.00
    set DAMAGE_COLLISION[2] = 60.00
    set DAMAGE_COLLISION[3] = 70.00
    set DAMAGE_COLLISION[4] = 80.00
    set DAMAGE_COLLISION[5] = 90.00
endfunction

//Damage per second ( when the unit is sucked )
private function SET_DAMAGE takes nothing returns nothing
    set DAMAGE[1] = 50.00 * TIMER_INTERVAL
    set DAMAGE[2] = 60.00 * TIMER_INTERVAL
    set DAMAGE[3] = 70.00 * TIMER_INTERVAL
    set DAMAGE[4] = 80.00 * TIMER_INTERVAL
    set DAMAGE[5] = 90.00 * TIMER_INTERVAL
endfunction

//Mana lose on collision
private function SET_MANALOSE_COLLISION takes nothing returns nothing
    set MANALOSE_COLLISION[1] = 50.00
    set MANALOSE_COLLISION[2] = 60.00
    set MANALOSE_COLLISION[3] = 70.00
    set MANALOSE_COLLISION[4] = 80.00
    set MANALOSE_COLLISION[5] = 90.00
endfunction

//Mana lose on suck, per second
private function SET_MANA takes nothing returns nothing
    set MANALOSE[1] = 50.00 * TIMER_INTERVAL
    set MANALOSE[2] = 60.00 * TIMER_INTERVAL
    set MANALOSE[3] = 70.00 * TIMER_INTERVAL
    set MANALOSE[4] = 80.00 * TIMER_INTERVAL
    set MANALOSE[5] = 90.00 * TIMER_INTERVAL
endfunction

Make it a one SETUP function, rather than all these...

Also, the coding is decent as always

and debugged too

One more thing, well maybe you'd like to make an option to set how many units could be picked in total when there are already other picked. Get what I mean? =)

Nice one!

cedi · Sep 13, 2009

Ahh key, I thought it's simpler to change values if they're divided to some functions.
There is one value, but it is constant... Do you need one for each level?

cedi

Deuterium · Sep 13, 2009

Oh yes I just noticed the value is there... damn man you're a super-coder

I'd never put that much time on a code

But yes, make one for each level

Vercas · Sep 14, 2009

You should get rid of the BJ's.
A neat, non-BJ loop will be faster.

Deuterium · Sep 14, 2009

Well vercas the only BJ's he uses are the DebugMsg and TriggerRegister... the first is deleted by jasshelper in non-debug mode, and the second leaks only 16 times throughout the whole game, so it's not big deal.

Vercas · Sep 14, 2009

I have nothing else to say then. Good job.

D4RK_G4ND4LF · Sep 14, 2009

I was SO F***ING impressed by your spell that I wasted my afternoon and made a GUI version for my map out of it

however I did not ask you for permission and would like to do it now :grin:

there are still some things which are not perfect like the lightning height and the special effect on units but I think I can handle it

but there is ONE thing I don't know how to fix
your movement is so smooth and mine is crappy
how did you do it?
(I could try to understand the JASS code but my JASS knowledge is limited to making functions)

5/5 + rep of course

edit:
thanks cedi

edit2:
just tested your spell again and noticed some things
-I created the lightning at both the knockback and the repulsion and not the knockback only (which is much better)
-the repulsion sfx is much easier to create then I thought xD
-and I forgot the dmg oO
edit3:
changed some things and it seems like everything is kinda bugged
will take some time to fix

edit4:
Update0.2:
-fixed angle bug
-removed lightning for knockback
-found new bug: the pullback does not vanish until the spell is over

Update0.3:
-fixed typo and added better effects

Update0.4:
-stupid debugg groups don't work :cry:

however it works fine this way too

Update0.5:
-0.4 got lost oO
-however now it should work fine (the units don't get knocked back everytime but mostly

)
-there is no cliff/building detection and it'll take me some time to invent some good method (items are buggy and units are more buggy but have more options..need to slep/do homework/read some books...will make the rest tomorrow or later if it takes more time)

cedi · Sep 14, 2009

Thanks, and it's allowed to recode it so no problem. I will look over your code in serval time an hour or so.

Huhu, was the Typo Cesi? Hmm I think, you suck some units more then one time?

cedi

MapperMalte · Sep 14, 2009

Wow, your english is hard to understand.
But the spell is very nice! +rep
And the coding is nice, too.

cedi · Sep 14, 2009

Yay yay, I know ...

cedi

YourNameHere · Sep 15, 2009

MapperMalte said:
Wow, your english is hard to understand.

You should really mind your own business first.

D4RK_G4ND4LF · Sep 15, 2009

I think the spell is finished now
may I upload it? :grin:

cedi · Sep 15, 2009

You can

.

cedi

Reaper2008 · Sep 16, 2009

Nice spell, but you still use many setup triggers. Merge them to:

JASS:

private function SETUP takes nothing returns nothing
//Duration of the ability, should be the same for the spell
    set DURATION[1] = 5.00
    set DURATION[2] = 6.00
    set DURATION[3] = 7.00
    set DURATION[4] = 8.00
    set DURATION[5] = 9.00

//Suck AoE
    set AOE[1] = 500.00
    set AOE[2] = 600.00
    set AOE[3] = 700.00
    set AOE[4] = 800.00
    set AOE[5] = 900.00

//Damage on collision
    set DAMAGE_COLLISION[1] = 50.00
    set DAMAGE_COLLISION[2] = 60.00
    set DAMAGE_COLLISION[3] = 70.00
    set DAMAGE_COLLISION[4] = 80.00
    set DAMAGE_COLLISION[5] = 90.00

//Damage per second ( when the unit is sucked )
    set DAMAGE[1] = 50.00 * TIMER_INTERVAL
    set DAMAGE[2] = 60.00 * TIMER_INTERVAL
    set DAMAGE[3] = 70.00 * TIMER_INTERVAL
    set DAMAGE[4] = 80.00 * TIMER_INTERVAL
    set DAMAGE[5] = 90.00 * TIMER_INTERVAL

//Mana lose on collision
    set MANALOSE_COLLISION[1] = 50.00
    set MANALOSE_COLLISION[2] = 60.00
    set MANALOSE_COLLISION[3] = 70.00
    set MANALOSE_COLLISION[4] = 80.00
    set MANALOSE_COLLISION[5] = 90.00

//Mana lose on suck, per second
    set MANALOSE[1] = 50.00 * TIMER_INTERVAL
    set MANALOSE[2] = 60.00 * TIMER_INTERVAL
    set MANALOSE[3] = 70.00 * TIMER_INTERVAL
    set MANALOSE[4] = 80.00 * TIMER_INTERVAL
    set MANALOSE[5] = 90.00 * TIMER_INTERVAL
endfunction

It is better and as easy to modify (Plus, a few lines shorter).

cedi · Sep 16, 2009

Key, when it is so important for you ...

cedi

DarkFabske · Sep 17, 2009

Nice and good made spell think it is very useful.
i just thought a bit more effects will come good xD.
BANG BANG

Piranha89 · Sep 27, 2009

That spell has some real fun potential and looks very well. Definately one of your best spells yet. :wink:

TriggerHappy · Sep 28, 2009

Long code -_-

You don't need to null your triggers.
You seem to be nulling all of the arguments passed through functions when it's not needed. You only need to null local variables, not arguments
Wouldn't it be wise to store the buff's level inside the struct, you seem to be calling the GetUnitAbilityLevel function alot.
call GroupClear( TEMPGROUP ) is not needed, groups are cleared once they are re-enumerated.
ATTACK_TYPE_MAGIC, DAMAGE_TYPE_NORMAL, null should all be configurable.
Calling GetUnitState when referencing a units life should be replaced with GetWidgetLife, it's faster.
Same goes for SetUnitState (SetWidgetLife).
Your constant functions are a little wierd, setting the data inside arrays. You should be using an algorithm that would work for all levels and return the value. Something like this, though not exactly this;
JASS:
```
private constant function Damage takes integer level returns real
    return 100*level
endfunction
```

Deuterium · Sep 28, 2009

You sure about the state vs. widgetlife thing?

Also, the usage of arrayed globals as adjustable values is more user friendly as you just set the value you want (ie you don't have to think of an equation)... what's more, not everything can be an equation, and so your method won't work for all values

TriggerHappy · Sep 28, 2009

Deuterium said:
You sure about the state vs. widgetlife thing?

Also, the usage of arrayed globals as adjustable values is more user friendly as you just set the value you want (ie you don't have to think of an equation)... what's more, not everything can be an equation, and so your method won't work for all values

Apparently these benchmarks confirm it.

cedi · Oct 8, 2009

Don't use an algorithme and I don't save the buff level, but everything else is done. And I made the structs private.

cedi

Lordarking00 · Oct 9, 2009

Your spell is very nice :grin:

But:
-When i copy the scripts and copy to my Map it doesnt works the script says:
The ...Installer script with the name... doesnt exist and than the trigger
turns off pls need help.

DeathNinja419 · Feb 19, 2012

The spell doesnt work!!!

DeathNinja419 · Feb 19, 2012

when i copyed the triggers to my map it says errors for all of the 5 triggers pls fix that

Yp_man · Jun 8, 2014

Guys, help me please, WE giving error to these triggers when i try to save the map, i don't know what to do

IcemanBo · Jun 8, 2014

Do you use JNGP? This is written in vJass, and normal world editor doesn't support it.

Yp_man · Jun 9, 2014

IcemanBo said:
Do you use JNGP? This is written in vJass, and normal world editor doesn't support it.

Thank you , I will try it and report soon)

Yp_man · Jun 9, 2014

Look, I wanted to import some spells wich use triggers, but usual WE don't accept these , so i downloaded JNGP latest version . Here I imported the spell , copied the triggers and when i try to save the map a syntax error appears . I am a newbie so I don't understand what and how to make it work ((

KILLCIDE · Jan 11, 2017

Spell currently has syntax errors, and the author has not been on since Sept. 2014.

Resource is moved to Substandard.

Arcania Zero v0.03

Arcania Zero v0.03 (Map)

Moderator

Moderator

Attachments

Attachments

Similar threads