[tr]

I can't look at the triggers since they aren't posted but in the picture you have some things wrong. Never use the and condition block unless it is used inside an of condition block. Anything used twice or more should be stored into a variable. Example: picked unit.

u mean in the comment section? with the

• how does this work

?

If you are talking about how to post triggers right click the name of the trigger in the trigger editing area (where you add the action and other stuff) click copy as text. Then paste it between trigger tags. Triggers should be in the description.

ok cool thx.

deathismyfriend yeah but it seems to be working.. so is there a problem with "and all conditions are ture" or is it just ugly "coding"

Rheiko said:

store everything that will used twice to a variable and remove it via custom script

Click to expand...

okay - but i might just get rid of "is controlled by a player" i think a bot wouldn't bother to mush.

If variables are needed i will work on it later.

AFK Protection 1.0, Auto Start 1.0, Ease In 1.0 Review by bowser499

This is my first review on a system, this one appeared when I wanted to write a review.

Originality: 3.5/5. It's not quite original but is still useful. I've seen this anti-afk system: http://www.hiveworkshop.com/forums/spells-569/anti-afk-system-v1-8-new-build-196389/. I can say, it's a lot better because it allows more than this one. I've seen some maphack protection systems aswell. So, that's why it lacks originality. It's difficult to create a really creative system.

Execution: 3/5. The whole trigger system can be seriously optimized by using loops in the code. For example, you can do a loop for shared vision and full shared unit control setting for every player. Use For each (Integer A) from 1 to 12, do (Actions). And also check if this player is controlled by player and is in game, it is possible using GUI. Imagine if you will get a share of all the computer units. AI won't unshare it. And AI never stays AFK. Destroying trigger is very nice though!
Ease In trigger can also be optimized by playing with same actions and IF blocks.

Usability: 5/5. Probably this is the only high rating. This system can simplify many lives.

Overall: (3.5+3+5)/3 = 3.8 = 4/5. Nice and simple system.

4/5: Recommended

Thx Dude!

Did the Loop thing for sharing units and you got me thinking: maybe someone doesn't want to be able to have someones unit control.. so therefore he can disable it now

I don't mind having partial control over bots, it works well, you just give them an order and when they executed your order, the bot takes over again - i think thats pretty sweet..

Anti-AFK System v1.8 (New Build) is cool but something different imo
My system is primarily against stupid first minute game afk guys
and furthermore real team players always play with "share unit control"
The Anti-AFK system is nice. It tells you: who went afk, but you can only hit the pause button and wait.. after some time when it was noticed that he went afk. True its good to have that too, but i would like it even more if someone is afk a bot takes control, just in case the enemy team doesn't agree with taking a break.

Can't see how you want to optimize Ease In.. how do you want to jam a loop in there?

The triggers are inefficient. Anything you use twice or more should be stored into a temp variable and the variable should be used.
You shouldn't use waits they are inaccurate.

You should look at my tutorial things a GUIer should know.

Don't see how this is that mush more efficient.. Since it was run once anyway i guess it didn't have such a big impact.. but yeah
Fixed that to my knowledge.. Anything else that needs improvement?
- on that note is jass more efficient? isn't it saved as the same anyway?

Jass is a ton more efficient than GUI. GUI is translated into jass when the map is saved but none of the actions/functions are inlined. That's why you always see things about BJs. These BJs are blizzard functions. They are inefficient and that is what GUI uses for almost everything.

You also never did what i suggested above.

What? you mean picked unit/picked player should be stored in a variable too?

Anything used twice or more.

It is very useful in altered melee maps or melee maps ^^!

Updated my rating since changes have been made and it is a decent system.