Custom Projectiles System

[Moderator]

07:43, 26th Jul 2012
Magtheridon96: This is excellent.
Rated 5/5 for being more than a half-decent projectile system for GUIers.

 

[Magtheridon96]

It would be nice if you were to post the triggers for those who aren't on their computers to be able to give you feedback as well.

Also, this may surprise you, but some people here don't have Warcraft III installed.

edit
For some odd reason, this has Custom scripts that say "Unknown" and there's a global setting in the InitGlobals function that's setting a trigger variable to "TriggerNull" rather than "null".
It's probably your version of the World Editor writing the file differently or something.

The custom script "Unknown" crashes my World editor when I attempt to edit it.
I'll fix this for you and give you a version of your map that can be opened with any editor, one moment.

edit
Okay, this is going to be harder than I thought >.>
Could you post the triggers so I can decipher what the rest of the "Unknowns" are?

 

[leonguyen112]

^ My bad. I was too hurry to post the code, and sorry for that. I also updated the requirement.

 

[Magtheridon96]

Tip:

It's usually more readable to avoid those one-liner if blocks and enumeration blocks =o (Pick every unit in ...)

edit
Also, you don't need that location array.
Using 3 location variables is totally fine.

I would also recommend making a couple of variables that store the target unit, the source unit,
and some other data so that when you run the trigger for the user, he would be able to access that data.
(Sort of like how DamageEngine by Bribe has DamageEventSource, DamageEventTarget and DamageEventAmount.

 

[leonguyen112]

Don't create a dummy and order him to harvest, create a dummy on Map Initialization and use him, because that would be far more efficient
Create the dummy, give him Locust, make him invulnerable, then hide him.

I have a question, do you mean only use 1 dummy for whole map? It may take 1 more trigger and variable to do this so I think it's unnecessary.

Updated and removed leak!

 

[maddeem]

This appears to be incredibly configurable, nice

 

[Magtheridon96]

Yes, one dummy.

It's necessary because what you can do on map initialization should not be left for game-time
(There's this rule in programming: What can be done at compile time shouldn't be left for run-time)

Creating units is a slow operation, so creating one dummy per destructable may slow things down quite a lot =o

 

[leonguyen112]

^ What you said is quite difficult to... understand :| or my English isn't good enough to understand it totally.
- You said it's unnecessary to create dummy per destructible, so I will not create it. My solution is using CSP_Missile. I'll add Harvest to it then order it to harvest, anyway it will be removed after dealing damage. So, if I do this, can the problem be solved?
__________________________

I have another problem:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • CPS_Destroy[CPS_Loop] Equal to True
  • Then - Actions
    • Destructible - Pick every destructible within CPS_AoE[CPS_Loop] of CPS_Point[12] and do (Actions)
      • Loop - Actions
        • Unit - Order CPS_Missile[CPS_Loop] to Harvest (Picked destructible)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (String((Current order of CPS_Missile[CPS_Loop]))) Equal to harvest
          • Then - Actions
            • Destructible - Kill (Picked destructible)
          • Else - Actions
  • Else - Actions

It does not destroy brigde, but destroy ramp and other destructibles

 

[Magtheridon96]

Hmm...

Well, an easier-to-understand way is to use a global dummy peasant, but this idea isn't so bad either.

I'd be cool with it.

Are you sure it destroys ramps?

 

[leonguyen112]

Well, maybe I had mistake. After several testing times, I now understand that the dummy must be at destructible location. So this is my last result:

• Destructible - Pick every destructible within CPS_AoE[CPS_Loop] of CPS_Point[12] and do (Actions)
  • Loop - Actions
    • Set CPS_Point[8] = (Position of (Picked destructible))
    • Unit - Move CPS_Missile[CPS_Loop] instantly to CPS_Point[8]
    • Unit - Add Harvest (Gold and Lumber) to CPS_Missile[CPS_Loop]
    • Unit - Order CPS_Missile[CPS_Loop] to Harvest (Picked destructible)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (String((Current order of CPS_Missile[CPS_Loop]))) Equal to harvest
      • Then - Actions
        • Destructible - Kill (Picked destructible)
      • Else - Actions
    • Custom script: call RemoveLocation(udg_CPS_Point[8])

 

[Magtheridon96]

You know, at this point, it would be far better to just have one global dummy unit so you don't have to keep adding the harvest ability :L

Create a Locust unit and give it the harvest ability and use it.
That's about it.

 

[btdonald]

GJ LeoNguyen

 

[Daredeamon]

You know, at this point, it would be far better to just have one global dummy unit so you don't have to keep adding the harvest ability :L

Create a Locust unit and give it the harvest ability and use it.
That's about it.

bump
This seems to have been updated since the above post by Magtheridon96... But it's still 'pending update'? :O

 

[Adiktuz]

hmmm... if it was updated and was not yet checked by Maggy, it should say pending on the picture in the spells list, but this one says Needs fix... so it's either maggy checked it and set it to needs fix or maggy was actually the one that updated it...

 

[Almia]

The arcing animation of the missile is ugly,you can use some other methods like GetZAngle or check other missiles systems for formulas.

In this part of code:

Unit - Create 1 CPS_DummyType for (Owner of Projectile_Source) at CPS_SourcePoint[CPS_MUI] facing CPS_Angle degrees Unit - Add Crow Form to (Last created unit) Unit - Remove Crow Form from (Last created unit) Unit - Move (Last created unit) instantly to CPS_SourcePoint[CPS_MUI] Animation - Change (Last created unit) flying height to Projectile_Height at 0.00 Animation - Change (Last created unit)'s size to (Projectile_Size%, 0.00%, 0.00%) of its original size Special Effect - Create a special effect attached to the origin of (Last created unit) using Projectile_Model Set CPS_Missile[CPS_MUI] = (Last created unit)

Move the CPS_Missile var after the dummy is created,then use it in the parameters instead of last create unit. This is a missile system,we need speed bro.

Same goes to the Picked Destructable and Picked Unit. You should cache these kind of parameters inside variables to increase speed.

I suggest to get rid of damage,destroy trees, special effect on drop, etc.,you should use a much friendlier, much easier to use method,its what we call Custom Event. You should use a real variable,then change its value depending on what event you want. You can check Unit Indexer and Unit Event for an example.

Unit - Add Crow Form to (Last created unit) Unit - Remove Crow Form from (Last created unit)

AFAIK, this is not a safe method. This is a safe method:

Custom script : if UnitAddAbility(bj_lastCreatedUnit, 'Amrf') and UnitRemoveAbility(bj_lastCreatedUnit, 'Amrf') then Custom script : endif

50 fps is bad,make it 33 fps or 32 fps or 25 fps(in other words,the loop must be 0.03 or 0.03125 or 0.04)

Set TempPoint = (Center of (Playable map area)) Unit - Create 1 CPS_DummyType for Neutral Passive at TempPoint facing Default building facing degrees Unit - Add Harvest (Neutral) to (Last created unit) Set CPS_Dummy = (Last created unit) Custom script: call RemoveLocation(udg_TempPoint)

Move the CPS_Dummy above then use it as the parameter for Last Created unit in Add Harvest. Don't use your own dummy,use Peasant,hide it then add Locust(via trigger),but this is optional.

You don't need to move the dummy when destroying trees.

This is my review for now.Mainly,the other reviews I didn't put is for the Dummy Object Datas.

 

[Daffa]

It got HR but NF status? :dead:

 

[Adiktuz]

because the HR was made on 2012, then it was changed to NF recently I guess... and he didn't remove the last review...

 

[Elprede]

Two days ago, I did not see a rating for this resource.

 

[leonguyen112]

This system is still developed, and I'm gonna update it at this weekend to fix some problems. I can't update it right now because my computer is in trouble.

Thanks Almia for showing me my mistake in coding.

 

[Elprede]

Hey leonguyen112, I fix those errors that Magtheridon96 mentioned in his review. Please see attachment below.

 

[leonguyen112]

Thanks GhostHunter123, but I can't take a look at it, yet. I have to leave it until weekend.

 

[Maker]

I think you could use SetUnitX and the y equivalent instead of moving unit instantly with GUI. You could then ignore pathing checks and the system would be faster. Move unit instantly is a performance expensive action.

 

[Bloody Wolf]

One word: S I C K

 

[SinnerPo]

That's a really good system, but..

I think you could use SetUnitX and the y equivalent instead of moving unit instantly with GUI. You could then ignore pathing checks and the system would be faster. Move unit instantly is a performance expensive action.

I think it would really make the system better, but i'm not sure if I can handle this myself. Author is afk for now, anyone could "upgrade" his system? And so I will be really grateful.

 

[Elprede]

In the meantime, try GUI Missile System

 

[Second]

I have a question...

For the rain of arrows kind of spell. When I put in another Sylvannas in the map, and make both heroes fire the spell (as close to each instance as possible) at the same time, then the first caster only shoots 2-3 waves, while the second caster shoots the default 5. Is this supposed to be happening?

 

[troylowyee]

Can this create a shockwave type of spell?

 

[Pyrogasm]

Can this create a shockwave type of spell?

So you didn't read the very first box of text in the resource description...?

This system allows you to create spell in a simpler way with these feathers:
o Simply create a straight projectile
...
o Can activate following trigger when hit (allow you to create attaching effect
(like stun, knock back,...).

 

[troylowyee]

So you didn't read the very first box of text in the resource description...?

oh so sorry didnt read the wall of text before trying it out T.T

 

[Pyrogasm]

If you're not going to read literally anything about a resource, then don't comment on it asking how it works or if it does something. Get your head out of your ass and use your eyes. The idiocy you just displayed is unbelievable.

The text is not a "wall" it's a description you are supposed to read to see if the resource is useful for your purposes.

 

[troylowyee]

If you're not going to read literally anything about a resource, then don't comment on it asking how it works or if it does something. Get your head out of your ass and use your eyes. The idiocy you just displayed is unbelievable.

The text is not a "wall" it's a description you are supposed to read to see if the resource is useful for your purposes.

Yeah sorry about that, i'll read it before commenting in the future.

 

[Veronnis]

Didn't see scrolling through the details, but does anyone have an approximation on how many instances of this system can be sustained at once before lag becomes noticeable? I'm running a really powerful comp so I can't compare myself to the average player very well.

 

[Rasamayu]

Nice i like it