Stupid Penguin - The Hive Workshop

Flame_Phoenix · 08-11-2008, 09:18 PM

OK guys, here is my new spell. It has been approved in the best wc3 website with high quality resources, so I hope you all like this new spell of mine, from my map =)

**Dr Super Good** · 08-12-2008, 01:05 AM

The floating text created is poor. It is
visable by all players through the fog of war and thus will give away a player's location to everyone very easilly. The lack of floating text fade also subtracts from the spell quality.

The overall layout is good for customizability but sadly is lacking for actual efficency. Constant functions are as slow as normal functions and your filter system could be faster using macros to insert the filter where you want it instead of relying on another function call.

Also I do not think the bracketing is needed with the if statements.

**Hanky** · 08-12-2008, 03:34 AM

The spell is good but not really my taste. Yes and Dr. Super Good is right the flying text don't looking so nice. But well the spell doing his job so 4.5/5 And btw didn't TriggerRegisterAnyUnitEventBJ leak boolexpr? Because in the TriggerRegisterAnyUnitEventBJ function is a loop with call TriggerRegisterPlayerUnitEvent(trig, Player(index), whichEvent, null) as we all know if you enter null for a filter it will leak. You should make a extra function something like:
"function AntiFilterLeak takes nothing returns boolean
return true
endfunction"
And then make you own loop with the function TriggerRegisterPlayerUnitEvent just that you enter in the filter parameter the function "AntiFilterLeak".

Flame_Phoenix · 08-12-2008, 10:04 AM

Quote:

The floating text created is poor. It is
visible by all players through the fog of war and thus will give away a player's location to everyone very easily. The lack of floating text fade also subtracts from the spell quality.

The overall layout is good for customizability but sadly is lacking for actual efficiency. Constant functions are as slow as normal functions and your filter system could be faster using macros to insert the filter where you want it instead of relying on another function call.

Also I do not think the bracketing is needed with the if statements.

Where shall I start... Well, If you think the floating text is poor, you can just not use, the SETUP allows you to choose what you want to do with the text pretty easily. Also, allowing the player to be discovered is good, in my opinion, that way the spell is balanced ... I don't want my spell to look like Dota, when you cast a spell and no one knows you did it. Floating Text fade is in fact something i didn't remember of using, mainly because I never do (lol).
ABout customization and efficiency, I prefer spells easy to understand and use over spells with high efficiency but hard to change. This spell was created with the average vJASS user in mind. Besides, this won't make the spell that slow in game, no one will notest.ABout macros I don't use them yet, and about Filters if you are talking about the explosion() function i decided to make that way to look more "object oriented" and therefore easier to change.
About your last sentence, I don't get what it means xD

Quote:

The spell is good but not really my taste. Yes and Dr. Super Good is right the flying text don't looking so nice. But well the spell doing his job so 4.5/5 And btw didn't TriggerRegisterAnyUnitEventBJ leak boolexpr? Because in the TriggerRegisterAnyUnitEventBJ function is a loop with call TriggerRegisterPlayerUnitEvent(trig, Player(index), whichEvent, null) as we all know if you enter null for a filter it will leak. You should make a extra function something like:
"function AntiFilterLeak takes nothing returns boolean
return true
endfunction"
And then make you own loop with the function TriggerRegisterPlayerUnitEvent just that you enter in the filter parameter the function "AntiFilterLeak".

Well, not every one can have the same taste can we ?
And no it doesn't leak any boolexpr - first because none is destroyed and second, if it did leak all GUI people would be dammed and the guys from wc3campaigns would have warned. Boolexpr only leak if you try to kill them. You can't just kill "null".

Quote:

Dr Super Good:
Nice spell. Easy to use and import and works well. One or two minor flaws thou as I posted but overal does what it is meant to well. The full MUI support also helps and it is highly unlikly to cause lag.

Honestly I can see people using this spell in their maps with some more polish.

Well, that is the main idea, I make my spells JESP so every one can use them and change them they way they want ! They can do anything they want, and that is the magic of JESP standard spells =)

Thx for your comments guys and thx for approving. Hope you all like my new spell =)

Flash.Kisame · 08-12-2008, 12:40 PM

a penguin which grows and grows and then explodes... sounds simple but i like it very funny spell :D
In my opinion those floating text looks great...

XzobieX · 08-12-2008, 03:05 PM

Very Good 4/5.

Thank You.

**Dr Super Good** · 08-12-2008, 03:07 PM

By strange bracking I mean the.

if (true) then
endif

Could much rather be strraight away.

if true then
endif

And as it skips a bracket it should be slightly faster.

What I mean by the floating text is that if it is not visable to the player (the map area or unit) then it should not be shown like with blizzard's critical strike. This will stop it from giving away the location of people's bases and simlar things by casting it as currently you even see the text if the area is unexplored which is definatly exploitable (should atleast need to be explored).

And by polishing the text, I mean getting the timings, size and speed very close to blizzard's so it blends in with the game more (less noticably triggered).

Flame_Phoenix · 08-12-2008, 04:01 PM

Quote:

a penguin which grows and grows and then explodes... sounds simple but i like it very funny spell :D
In my opinion those floating text looks great...

Thx =) Good feedback is always appreciated =) Remember, it doesn't need to be a penguin, it can be anything you want !

Quote:

Very Good 4/5.

Thank You.

Damn you for only giving me 4/5 (lol). Still thx for the feedback =)

Quote:

if (true) then
endif

Could much rather be strraight away.

if true then
endif

And as it skips a bracket it should be slightly faster.

Comon !!! No one will ever notice that for God sake !! It is just a coding style I use for me to understand things better. You can change it if you want, but that won't make the game run faster in ways people will actually notice it...

Quote:

What I mean by the floating text is that if it is not visable to the player (the map area or unit) then it should not be shown like with blizzard's critical strike. This will stop it from giving away the location of people's bases and simlar things by casting it as currently you even see the text if the area is unexplored which is definatly exploitable (should atleast need to be explored).

And by polishing the text, I mean getting the timings, size and speed very close to blizzard's so it blends in with the game more (less noticably triggered).

Mmmm In my opinion that is a good thing, that way we know where the caster is. Blizzard does the same, when a ranged unit attacks you from an area that is not explored, the unit becomes visible as well as the portion of area where it is. I don't think this is a problem, as I said, if people don't like it they can remove it, also I don't think there is actually a way of knowing if the caster is in a area which is not visible to the player who is taking damage.
About polishing the text, people can do that themselves, remember this spell is JESP, so they can make whatever they want with the text. I just though it was good like this.

lazer_X · 08-13-2008, 01:30 AM

i love penguins this is awesome :)

numerion · 08-13-2008, 08:38 PM

if is it as you are saying i will use it

Flame_Phoenix · 08-13-2008, 08:54 PM

Quote:

if is it as you are saying i will use it

yes it is all truth. This spell is JESP standard meaning you will have no problems in changing it. If you have, just make a post and I'll help =)

Btw, please remember to credit me, it's creator =)

Also, for fun, how are you planning to use the spell ?

Jack_Sparrow93 · 08-14-2008, 05:07 PM

Nice spell!

vercas · 08-18-2008, 10:44 PM

I got a friend wich made a model like himself, i think he will like to use it as the penguin :))))))))

Flame_Phoenix · 08-19-2008, 10:40 AM

Quote:

I got a friend wich made a model like himself, i think he will like to use it as the penguin :))))))))

Looool, Blow himself sure must be fun xD