Submitter's Description: Another spell I made to show a friend how I would go about doing it
*GUI
*MUI
*Cleared all the leaks (if found any let me know)
+Can be edited easily, with a few spell based variables
+Doesn't lag your computer when 5-6 of them are firing at the same time (oddly enough)
-Requires a dummy unit
-For special effects, requires a 2nd dummy unit
-For special effects, requires 2 custom abilities, if you'd like more effects + such, you would probably need more spells, although for the frost, only 2 is necessary
- I used a base spell that has a vertex change effect, you will need to use a different base effect
~~~~~~~~~~~~~~~~~~~~~~~~~
Update
Fixed the leak for multiple instances
Rating: 4.44 (1)
Uploaded: Dec 14, 2007
Updated: Mar 28, 2008
Spell Type: Target Object
Comment on Frost Nova, My Own
Comments on Frost Nova, My Own
Resource Moderator
Approved Dr Super Good: [Approved]
Decent spell. Lacks polish thou but in use apprears bugless especially for GUI. Even if leaks do occur they are within axceptable limates to be harmless to a map. It is also realitivly easy to use which is another plus factor. Definatly a good spell if you are a person needing a spell in your map fast.
I got bored so I dled this and changed it into a lightning nova. I changed the projectile dummy to far seer projectile, and made the damage lightning. When it hits a ground unit it makes a bolt of lightning come down from the sky and hit an enemy and if it hits an air it does chain lightning death. It looks really cool!
The first, the height function bugs the whole system if it needs to set the height at a rate lower than 2 secs, so I'm gonna keep the height change that I have
(It probably does exactly the same thing if you went past all the JASS straight to whatever the game itself was written in)
I'm gonna update this comment when I find other things (when I tried to use some of the things you suggested the system bugge d like crazy, even lagging a bit 'o' !!!)
1. Yeah try to make only one ability for caster and one for dummy that makes spell very simple.
2. I agree whit you, like chain lightning spell it ends if you cant see enemy target that is the spell and dummy should be only used as effect right?
This is simple you can just add in your check for new target Is unit visible boolean condition.
3. I know you check it up but that is 2x checking, is it not better to check all in one?? you should code it in one but if you don't like it you may leave it like this ...
4. Of course don't use BJ-s never use them.
GetLastCreatedUnit() is BJ function look:
GetLastCreatedUnit() = bj_lastCreatedUnit
where GetLastCreatedUnit() is a BJ function and bj_lastCreatedUnit is a global variable
5. Yes boolexpr is faster than If for sure, GUI if than else is very bad cause it creates function and if uses it.
It does not leak in this map, but when used in on battle.net whit many players -.-
Still if you like that way leave it but my suggestion to you is not to do it like this way
6. You did not understand how to deal whit function SetUnitFlyHeight. You set in that function rate last argument is 0 that means it does not change height. And once used this function it changes that height of unit to specific height whit rate it means time it needs to set max height, you don't need to use it more than once - let me explain better:
01 - You need to use this function only once.
02 - When used set first argument to your missile, second argument to height of your target, last argument to rate that means how fast it changes height. You must put it to distance between current target and new target / missile speed.
Example:
#1 - Yeah, I wanted the vertex effect from the nova dummy spell, I'm gonna try to get that vertex effect without using a secondary dummy spell
#2 - I'm not 100% sure what your talking about, but I think you mean if the missile or the missiles target dissapears from sight, the spell ends
#3 - The trigger itself doesn't check it, but if you look at the coding, when the system picks a new target, it excludes immune, buildings, dead, and a few other things (I might need to add invulnerable)
#4 - Yeah, I just didn't want to use that extra BJ function, but I think I'm gonna just leave it at regular GUI when I'm doing GUI spells (except for leaks)
#5 - I'm a little confused by what you mean, but I realized that same thing when I first started doing movement triggers, for some reason, it doesn't lag like I thought it would
I think it has something to do with boolexprs, it checks it much faster than an If/Then/Else type of thing
But, you can have a sh*tload of these triggers as long as they have that condition
#6 - Yeah I was really bothered, I couldn't get the height to work properly, so I just set it to 200 for now, I'll see if I can change it to make it work properly
#7 - Yeah, as I said before, those were mostly for display, I'll update it so you don't need the extra custom abiles for the extra effects
First sorry about delay i had to study a bit so i did not check hive a 1-2 days.
I first made chain frost - pro version which contained only GUI, now contains GUI and jass
because you can make it much more clear and faster in jass but GUI is ok for me. I checked your spell and I must say that it is seen you did hard work and i see that you are still learning many things so let me help you a bit.
1. The people who wants to set damage to different number they can easy do it in object editor if you make only one frost nova ability and set levels of it to 4 or how much you want. Simply do it in trigger that you set level of that ability to ability level of caster.
2. Dummy missile should never have a visibility i mean caster should not see missile as unit. The spell should end if you don't see target.
3. Your variable group NewFrostTargets never checks if new unit is building or mechanical or invulnerable or is visible and maybe i forget about something but i think it is all.
4. You always use functions like GetEnumUnit() or GetLastCreatedUnit() and so on. You should only set one variable of that function like:
set myVar = GetEnumUnit()
and now you called this function only once + never use GetLastCreatdUnit() when you do custom script. Because look:
function GetLastCreatedUnit takes nothing returns unit
return bj_lastCreatedUnit
endfunction
so use directly bj_lastCreatedUnit
About GetSpellAbilityUnit() always use GetTriggerUnit() because it is faster.
5. Your trigger move missile is constantly run ( every 0.01 seconds ) which is bad it checks every time the condition if unit group is empty but its better to only have function or trigger which has such fast timer only during spell.
6. Your timer constantly runs SetUnitFlyHeight which does nothing. First this function should be used only once when missile is created and your rate is 0??? i did not understand that line of code because you call function which does nothing.
function SetUnitFlyHeight takes unit whichUnit, real height, real rate returns nothing
where whichUnit is your missile, height is the height of your target and rate is distance / speed.
7. Your cast buffs stay on target + as i sad before there is no need to have to much abilities. Use only hero casting one and other dummy damage, that is the best way.
Try to fix some code and this stuff and i will check it again.
What i want to say is great job on doing this you really did as much as you can and i can see that in code. For now 5/10.
Whoops forgot to tell ya what it does, it is a frost nova chain spell, the way I would do it in GUI (Dark_Dragon already made one in JASS, I wanted to show him how I would do it in GUI)
