[JASS] Simple Spell erro

[Zigg]

Code not working, but i can't find the error

function ArcCod takes nothing returns boolean
    return GetSpellAbilityId()=='ZZZZ'
endfunction

function ArcDam takes nothing returns nothing
local unit Target = GetSpellTargetUnit()
local unit Caster = GetTriggerUnit()
local real d1 = I2R(GetHeroInt(Caster,true)) * 2.5
    call UnitDamageTarget(Caster, Target, d1, false, true, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_MAGIC, WEAPON_TYPE_WHOKNOWS)
endfunction

// ------------------------- Init Trigger----------------------------
function InitTrig_Arcane_Blast takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_CAST )
    call TriggerAddCondition(t, Condition( function ArcCod ) )
    call TriggerAddAction(t, function ArcDam )
endfunction

anyone can help me?
+ rep

 

[PurgeandFire]

Try changing the line UnitDamageTarget to this:

call UnitDamageTarget(Caster, Target, d1, true, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_MAGIC, WEAPON_TYPE_WHOKNOWS)

Or "true" "true". But anyway, I remember some people having problems if they did not set the attack boolean to true.

If it still doesn't work, then add a BJDebugMsg("text") to the actions and see if it even runs. If it doesn't, then the condition was most likely not met. (either wrong id input or wrong spell cast, w/e)

 

[Zigg]

Spell still does not work but when I put ID into another spell worked

i think this part have some error

 function InitTrig_Arcane_Blast takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_CAST )
    call TriggerAddCondition(t, Condition( function ArcCod ) )
    call TriggerAddAction(t, function ArcDam )
endfunction

 

[Lender]

try with EVENT_PLAYER_UNIT_SPELL_EFFECT

 

[Starquizer]

Use something like that

call UnitDamageTarget(Caster,Target,d1,false,false,ATKTYPE,DMGTYPE,null)

make both false to take less memory and set the last argument to null.

 

[Zigg]

I found the error, Arcane Blast isn't name of my trigger them the trigger InitTrig_Arcane_Blast doesn't run

Thx everybody try help me

 

[Mr_Bean]

Also be sure to set Caster and Target to null when you are done with them.

You can also merge ArcCod and ArcDam into one function, which is faster.