[Solved] Part of trigger not executing

[envenger]

Hi...
A part of this trigger is not working... i must have done some noob mistake but... i guess it must be due to some noob mistake by me... any way i am new to jass so...

function Trig_Untitled_Trigger_001_Actions takes nothing returns nothing
local real x1
local real y1
local real x2
local real y2
set udg_angle = GetUnitFacing(udg_pusher)
set x1 = GetUnitX(udg_unit)
set y2 = GetUnitY(udg_unit)
set udg_x = Cos(udg_angle * bj_DEGTORAD)
set udg_y = Sin(udg_angle * bj_DEGTORAD)
set x2 = (Cos(udg_angle * bj_DEGTORAD)*500)
set y2= (Sin(udg_angle * bj_DEGTORAD)*500)
call DisplayTextToForce( GetPlayersAll(), "1" )
set udg_xd = x1 + x2
set udg_yd = y1 + y2
call DisplayTextToForce( GetPlayersAll(), "2" )
set udg_pb = 1
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_001 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_001 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Untitled_Trigger_001, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddAction( gg_trg_Untitled_Trigger_001, function Trig_Untitled_Trigger_001_Actions )
endfunction

1 prints but not 2

The map is also attached

 

[WaterKnight]

When the code gets halted, it's most likely due to an uninitialized variable you try to read from.

In this case, y1 has no value.

set x1 = GetUnitX(udg_unit)
set y2 = GetUnitY(udg_unit)

You meant y1 instead of y2 here probably.

 

[envenger]

When the code gets halted, it's most likely due to an uninitialized variable you try to read from.

In this case, y1 has no value.

set x1 = GetUnitX(udg_unit)
set y2 = GetUnitY(udg_unit)

You meant y1 instead of y2 here probably.

Oh... Thanks...

 

[SanKakU]

with practice in jass code and saving your map and evaluating the last bits of code you edited...you should be able to spot these kinds of errors yourself. i make mistakes like this all the time, even now, so no, that wasn't really a newbie mistake.

did your problem get fixed or is there something else the matter?