does this leak?

[edo494]

I ever did it this way but calling set u = null for every unit in group can slow things down and even Nestharus didnt do that in his vJass tut. video so my question is:

    local group g = CreateGroup()
    local unit u
    call GroupEnumUnitsInRange(g, blabla whatever) // this is not important
    loop
        set u = FirstOfGroup()
        exitwhen u == null
        call GroupRemoveUnit()
        //some actions
    endloop
    set u = null

There is no set u = null in the loop so I wonder if this leak because it was said that everytime you give some handle pointer a value(set u = FirstOfGroup() for instance) it must be nulled to make the pointer free(number of sets and number of nulls must be equal)

 

[HappyTauren]

Well, you do not have to set u = null all the time, only on the end of the function. Local variables must be nulled if they are handles, because if they do not get recycled (nulled) they still point to something, which means that handle id can't get recycled. This means that the handle stack goes up, and there is a set number of handles a map can have.

Basically, that doesn't leak because you only have to null locals on the end of the function (which is what you are currently doing).

 

[edo494]

oh thx for the reply, I ever add one more set u = null at the end of loop
edit: I would give you rep but

You must spread some Reputation around before giving it to HappyTauren again.

 

[HappyTauren]

Well, you can set u = null if you're going to use variable further and want to avoid any conflicts possible, that is fine. I don't mind

 

[edo494]

well, i mean

local group g = CreateGroup()
local unit u
call GroupEnumUnitsInRange(g, blabla whatever) // this is not important
loop
    set u = FirstOfGroup()
    exitwhen u == null
    call GroupRemoveUnit()
    //some actions
    set u = null
endloop

thats how i used to do it (and I still do for now)

 

[HappyTauren]

You do not have to. It won't bug the game too much, but is still unnecessary.

 

[mckill2009]

exitwhen u == null is already set u = null, and dont use a local group in a loop enumeration, just use a global one like bj_lastCreateGroup...

 

[edo494]

if exitwhen st the u to null you couldnt work with it after the exitwhen
what is difference between local group and the global one other then 3 less calls

 

[Yixx]

What McKill means is: You do not need to do set u = null inside the loop, as you immediately use the unit again, and furthermore, since you put exitwhen u == null, you also do not have to null it after the loop, since u is already null.

 

[mckill2009]

what is difference between local group and the global one other then 3 less calls

why create a local group for enumerating when it's already there via bj_lastCreatedGroup, besides you should destoy your local group which means it's 50% slower than the method I showed you...but ofc nothing wrong with what you did...

 

[edo494]

well that was wrote from head
but thank you for suggestion