• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

Assassinate v1.1

Status
Not open for further replies.

Dr Super Good

Spell Reviewer
Level 63
Joined
Jan 18, 2005
Messages
27,180
Problem 1.
Removal of non-existent group, severity unclear. Only remove a group if you actually make one as at best it will waste CPU resources and at worst could result in unknown and unwanted behaviour.

Problem 2.
Incorrect structure move logic, severity critical. All members of the object structure must be moved during an object move for the object move to be performed correctly. You forgot to move the slash count member resulting in corruption of slash count member which will cause incorrect and hard to predict behaviour.

Problem 3.
Incorrect structure move logic, severity critical. All members of the object structure must be moved during an object move for the object move to be performed correctly. A code error resulted in assignation target destination being assigned itself rather than the value of object being moved. This will result in incorrect and had to predict behaviour.

A brief test of the ability with 3 heroes owned by the same player casting at the same time demonstrates expected behaviour with no noticeable faults or errors occurring.

Here is your map. I accept both Master Card and PayPal.
(no I am not expecting a payment for this, that is a joke that should not be taken seriously)
 

Attachments

  • Assassinate v1.2.w3x
    194.3 KB · Views: 108
Status
Not open for further replies.
Top