• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

[Snippet] AmbientUtils

Level 23
Joined
Apr 16, 2012
Messages
4,041
JASS:
        private  boolean r
        private  boolean t
        private  sound   s
       
        readonly real    duration
        readonly real    length
       
        private  real    i
        private  real    o
        private  real    v
       
        private  real    ip
        private  real    op

try writing code that is readable without comment or explanation what is what(give methods normal names, give variables normal names)

At this moment the code looks more esoterically than it could
 

Kazeon

Hosted Project: EC
Level 33
Joined
Oct 12, 2011
Messages
3,449
It's very narrow one, meaby thats why. I could try help you improve it (if possible) but you need to drop this ugly naming.
Ambient is the name. >.> Probably ugly, but it's just correct.
It's very narrow one
Remember: good system is where you don't know anything to be removed, not to be added ^^ So if this has already covers up everything needed by "ambient" then I think we don't to add any more thing ^)^

JASS:
        private  boolean r
        private  boolean t
        private  sound   s
       
        readonly real    duration
        readonly real    length
       
        private  real    i
        private  real    o
        private  real    v
       
        private  real    ip
        private  real    op

try writing code that is readable without comment or explanation what is what(give methods normal names, give variables normal names)

At this moment the code looks more esoterically than it could

Okay.
 
Top