Fisrt of all, the screenshot. Ask someone else to take a screenshot, even if you can't do that, throw a pitch black screen on, it's better than something confusing.
Moving on, the description. There's no description at all, you just throw triggers on and be done with it. You should drop a tooltip, explain some mechanics and then put triggers. Also triggers should be seperately hidden tagged, not altogether.
Trigger commentary, there is none. You are going to need that, ESPECIALLY when your spell structure is waaaay different from hive spell's, which I will cover later.
Actual triggers, you should read up on some tutorials or look at some other spells on hive before trying to upload one of your own. We appreciate you trying to fill up the spell section with content, but it also should be
quality content. The trigger structure would be like this:
- Comment of import - explain how to import the spell. The instructions should be clear even to newbies. If you look through most GUI spells, you'll find that.
- Configuration trigger - The trigger filled with configurations, also made so a newbie would understand. It should be: Comment on what the following configuration does -> Configuartion -> Comment -> Configuration, and so on. Right now your spell is not configurable, let alone importable. Even if the importer does import this spell, it will not work because "Ability being cast" equal to "Front Lotus", a spell which the importer doesn't yet have in their map.
Configuration variables should also be indexed so they can be seperated into multiple levels.
- Spell initialization trigger - it is not properly done. The variable namings are way off, try looking at your variable names after some time and say what they do without looking at the triggers, I bet you couldn't do that.
Pause dummies is okay, but pausing units is not and can lead to bad consequences.
Moving on, there are GUI functions and then bam, SetUnitAnimationByIndex. Does it really have to be a custom script?
Waits are disallowed in hive spells. They have many problems within theirselves that lead to other problems -- it's a big nope.
Put (Last created unit) into a variable for better efficiency.
Instead of instantly filtering out all units in a group, pick all units in range and filter them out with an If/Then/Else block inside.
You don't have to null global unit variables, they're harmless. In fact, it's better not to null them, for example they can interfere with a DDS or a kill/death tally for one's map.
- Loop trigger - 0.02 seconds per loop iteration is too fast. It lags most spells even on high performance computers. Acceptable values are 0.03-0.04. Alternatively you can use (1/32) which is 32 times per second.
Most of the loop code lines also have the problems you had in the initialization function.
Nothing much to say here, since the loop is really short.
Would also like to highlight what Almia said:
That's the most important part. Spell submission rules clearly state that spells must be MUI. Yours only works for one unit. I suggest reading up on tutorials on how to make your spell MUI. Preferably
dynamic indexing as it is not hard to understand and is modern, and lots of people still use it.
Overall rating of 1/5,
Unacceptable.
Approved
