Waypoint System v1.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Required changes

• Heroes controlled by non-human players can also trigger the system
• The system creates multiple overlapping visibility modifiers for the same player,
  and thus causes leaks
• The floating text lines cause location leaks
• Move hero instantly lines cause location leaks

Suggested changes

• You could make the hero not teleport when selecting a waypoint where the unit
  is at already
• Remove unneeded variables
• Use a loop instead of if/then/else in the Explore trigger
• Use a loop instead of if/then/else in the Triggers trigger

 

[Pharaoh_]

WayPointExplore triggers can be merged with each other. Use a hashtable to retrieve the number to display in the floating text.

 

[Daroth]

I've merged now the WaypointExplore0-3 triggers with each other.
But I don't get what you want with the hashtable... It would be nice if you could explain it more precisely.

 

[kalipou134]

Nice Idea

 

[Pharaoh_]

Remove any waits.

The reason why a hashtable is preferred is to avoid repetition of if/then/elses (to check what region contains the (Triggering unit) ~ btw, use (Triggering unit) instead of (Entering unit)). Using the actions

• Set i = i + 1
• Set Region[i] = Explore 1 <gen>
• call SaveInteger (udg_Hash, GetHandleId (udg_Region[udg_i]), 0, udg_i)
• Set i = i + 1
• Set Region[i] = Explore 2 <gen>
• call SaveInteger (udg_Hash, GetHandleId (udg_Region[udg_i]), 0, udg_i)
• Set i = i + 1
• Set Region[i] = Explore 2 <gen>
• call SaveInteger (udg_Hash, GetHandleId (udg_Region[udg_i]), 0, udg_i)

can help you retrieve the number of the way point with GetTriggeringRegion().

If a user has many way points, it will be hard for them to edit the system.

The system currently leaks. Store (Player number of (Triggering player)) in a variable, before calling it all the time in the same trigger.

 

[Tank-Commander]

Is that wait on one of the triggers necessary?

 

[Daroth]

I have some problems with the hashtable...
If I test the triggers the WPNumber stored in the hashtable stays always '0' regardless the area I've entered!
I think the problem is, that GetTriggeringRegion() is a region in jass and the WPExplore is a region in GUI which means a rect in Jass. So I don't find a way to convert the TriggeringRegion into a rect for having a region in GUI.

I hope you can help me...

Triggers

Init

• Initialization
  • Ereignisse
    • Map initialization
  • Bedingungen
  • Aktionen
    • Hashtabelle - Create a hashtable
    • Set WPHashtable = (Last created hashtable)
    • Set i = 0
    • Set WPExplore[i] = WaypointExplore0 <gen>
    • Set WPExploreHandle[i] = (Center of WPExplore[i])
    • Hashtabelle - Save i as 0 of (Key WPExploreHandle[i]) in WPHashtable
    • Set i = (i + 1)
    • Set WPExplore[i] = WaypointExplore1 <gen>
    • Set WPExploreHandle[i] = (Center of WPExplore[i])
    • Hashtabelle - Save i as 0 of (Key WPExploreHandle[i]) in WPHashtable
    • Set i = (i + 1)
    • Set WPExplore[i] = WaypointExplore2 <gen>
    • Set WPExploreHandle[i] = (Center of WPExplore[i])
    • Hashtabelle - Save i as 0 of (Key WPExploreHandle[i]) in WPHashtable
    • Set i = (i + 1)
    • Set WPExplore[i] = WaypointExplore3 <gen>
    • Set WPExploreHandle[i] = (Center of WPExplore[i])
    • Hashtabelle - Save i as 0 of (Key WPExploreHandle[i]) in WPHashtable

Explore

• WaypointExplore
  • Ereignisse
    • Einheit - A unit enters WaypointExplore0 <gen>
    • Einheit - A unit enters WaypointExplore1 <gen>
    • Einheit - A unit enters WaypointExplore2 <gen>
    • Einheit - A unit enters WaypointExplore3 <gen>
  • Bedingungen
    • ((Triggering unit) is Ein Held) Gleich True
  • Aktionen
    • -------- you have to adjust the WaypointExplore areas above! --------
    • Set WPPlayer = (Owner of (Triggering unit))
    • Set WPPlayerNumber = (Player number of (Owner of (Triggering unit)))
    • Custom script: set udg_WPExploreTemp = GetTriggeringRegion()
    • Set WPNumber = (Load 0 of (Key WPExploreTemp) from WPHashtable)
    • Sichtbarkeit - Create an initially Aktiviert visibility modifier for WPPlayer emitting Sichtbarkeit across WPExplore[WPNumber]
    • Schwebender Text - Create floating text that reads (Waypoint + (String(WPNumber))) at (Center of WPExplore[WPNumber]) with Z offset 150.00, using font size 8.00, color (100.00%, 80.00%, 0.00%), and 0.00% transparency
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • 'IF'-Bedingungen
        • WPNumber Gleich 0
      • 'THEN'-Aktionen
        • -------- activates the option to teleport to this waypoint --------
        • Set WPExploreBool0[WPPlayerNumber] = True
      • 'ELSE'-Aktionen
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • 'IF'-Bedingungen
        • WPNumber Gleich 1
      • 'THEN'-Aktionen
        • -------- activates the option to teleport to this waypoint --------
        • Set WPExploreBool1[WPPlayerNumber] = True
      • 'ELSE'-Aktionen
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • 'IF'-Bedingungen
        • WPNumber Gleich 2
      • 'THEN'-Aktionen
        • -------- activates the option to teleport to this waypoint --------
        • Set WPExploreBool2[WPPlayerNumber] = True
      • 'ELSE'-Aktionen
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • 'IF'-Bedingungen
        • WPNumber Gleich 3
      • 'THEN'-Aktionen
        • -------- activates the option to teleport to this waypoint --------
        • Set WPExploreBool3[WPPlayerNumber] = True
      • 'ELSE'-Aktionen